Fixed
Status Update
Comments
lp...@google.com <lp...@google.com>
cy...@gmail.com <cy...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <
Link:
Implement full screen search bar using dialog
Expand for full commit details
Implement full screen search bar using dialog
Overview of new components:
* SearchBar - visually equivalent to previous overload, except does not
apply the padding/window insets of a top bar.
* CollapsedSearchBar - One half of SearchBar. Just a text field wrapped
in a Surface.
* FullScreenSearchBarLayout - private implementation. Equivalent to
existing SearchBarImpl + SearchBarLayout but slightly cleaned up.
Predictive back support will be added in future CL.
* ExpandedFullScreenSearchBar - FullScreenSearchBarLayout wrapped in a dialog.
Bug: b/283311462
Test: n/a
Relnote: n/a
Change-Id: I71145c5528a2c0c5ee97eca75dda0904ea91108b
Files:
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt
Hash: 7ccfa611287f4388caf0b0224b4b662e9a5f44af
Date: Tue Nov 19 22:59:52 2024
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <
Link:
Introduce SearchBarState
Expand for full commit details
Introduce SearchBarState
This is part 1 of the search bar refactor. A new
InputField overload has been added to use this state.
Other component refactors will come in later CLs.
Bug: b/283311462
Test: n/a
Relnote: n/a
Change-Id: Ibb563b25de5ba76cec7612655b9b632c5f0e99d4
Files:
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt
Hash: 4f31090de77bee9f8e1e355e78125b8228e0985b
Date: Fri Aug 09 02:31:50 2024
Description
Compose Compiler: 1.5.7
Kotlin: 1.9.21
I don't expect this code to do anything sensible, but the compiler shouldn't throw an exception.
This should have a better compile time error message and not throw an exception. Something like:
e: blah blah blah is not allowed in @Composable at line XYZ
OR it should compile successfully and then throw
StackOverflowException
at runtime if that composable is called.This code:
Causes this exception at build time: