ClassCastException in WindowMetricsCalculatorCompat.computeCurrentWindowMetrics [318787482]

Fixed

Bug

Status Update

No update yet.

Description

mx...@gmail.com

created issue #1

Jan 5, 2024 09:51AM

Component used: Jetpack WindowManager

Version used: 1.2.0/latest git

Devices/Android versions reproduced on: Any devices/versions

When using WindowMetricsCalculator.getOrCreate().computeCurrentWindowMetrics(context), the following crash happens.

java.lang.ClassCastException: dagger.hilt.android.internal.managers.ViewComponentManager$FragmentContextWrapper cannot be cast to android.app.Activity
    at androidx.window.layout.WindowMetricsCalculatorCompat.computeCurrentWindowMetrics(WindowMetricsCalculatorCompat.kt:69)
	...

This is because in this line, the origin context instead of the unwrapped context (unwrapUiContext(context)) is casted to Activity.

Comments

ap...@google.com <ap...@google.com> #2Feb 2, 2024 07:13PM

Some things to work out before making the annotations type-use:

Determine guidelines for type nullability in public API
Determine rules for when type nullability can change in public API
Confirm that intellij nullability lint works as expected for type-use nullability annotations
Test what the impact would be on existing arrays (due to ambiguities of type-use annotations on arrays)
Confirm usage of type-use androidx.annotation.NonNull/Nullable in metalava won't break anything for platform

di...@google.com <di...@google.com> #3Feb 2, 2024 10:21PM

Marked as fixed.

Plan for making the annotations type-use: https://docs.google.com/document/d/1tNqV9Dgtii6wvulm8emjs0bwgSL3Fwf3F4LFXfVeyTU/edit

na...@google.com <na...@google.com> #4Mar 6, 2024 07:49PM

Tracking sheet for which projects have been migrated.

Issue 318787482

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Feb 2, 2024 07:13PM

di...@google.com <di...@google.com> #3Feb 2, 2024 10:21PM

na...@google.com <na...@google.com> #4Mar 6, 2024 07:49PM

Add comment

Issue metadata