ClassCastException in WindowMetricsCalculatorCompat.computeCurrentWindowMetrics [318787482]

Fixed

Bug

Status Update

No update yet.

Description

mx...@gmail.com

created issue #1

Jan 5, 2024 09:51AM

Component used: Jetpack WindowManager

Version used: 1.2.0/latest git

Devices/Android versions reproduced on: Any devices/versions

When using WindowMetricsCalculator.getOrCreate().computeCurrentWindowMetrics(context), the following crash happens.

java.lang.ClassCastException: dagger.hilt.android.internal.managers.ViewComponentManager$FragmentContextWrapper cannot be cast to android.app.Activity
    at androidx.window.layout.WindowMetricsCalculatorCompat.computeCurrentWindowMetrics(WindowMetricsCalculatorCompat.kt:69)
	...

This is because in this line, the origin context instead of the unwrapped context (unwrapUiContext(context)) is casted to Activity.

Comments

ap...@google.com <ap...@google.com> #2Feb 2, 2024 07:13PM

The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.

di...@google.com <di...@google.com> #3Feb 2, 2024 10:21PM

Marked as fixed.

The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.

Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.

na...@google.com <na...@google.com> #4Mar 6, 2024 07:49PM

Hi Nona,

Can you please schedule a release after you merge the fix?

Issue 318787482

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Feb 2, 2024 07:13PM

di...@google.com <di...@google.com> #3Feb 2, 2024 10:21PM

na...@google.com <na...@google.com> #4Mar 6, 2024 07:49PM

Add comment

Issue metadata