[desugared library] Desugared library version 2.1 is not compatible with previous versions of R8 [319604744]

Fixed

Bug

Status Update

No update yet.

Description

sg...@google.com

created issue #1

Jan 11, 2024 11:41AM

With change 85561 the generated machine specification is not longer compatible with previous versions of R8.

Generating com.android.tools:desugar_jdk_libs_configuration:2.1.0 in 96a5fc3f9a34ddc33e4a56861239d813ce9c297b:

tools/desugar_jdk_libs_repository.py --variant jdk11 --desugar-jdk-libs-checkout ~/prj/desugar_jdk_libs

With the following diff in the desugar-jdk-libs checkout in ~/prj/desugar_jdk_libs:

diff --git a/DEPENDENCIES_JDK11.txt b/DEPENDENCIES_JDK11.txt
index e2bcaa7..56c0411 100644
--- a/DEPENDENCIES_JDK11.txt
+++ b/DEPENDENCIES_JDK11.txt
@@ -1,2 +1,2 @@
 # Dependencies to add when releasing as JDK 11 based Maven artifact.
-com.android.tools:desugar_jdk_libs_configuration:2.0.4
+com.android.tools:desugar_jdk_libs_configuration:2.1.0
diff --git a/VERSION_JDK11.txt b/VERSION_JDK11.txt
index 07165c6..de2ebd5 100644
--- a/VERSION_JDK11.txt
+++ b/VERSION_JDK11.txt
@@ -1,2 +1,2 @@
 # Version for releasing JDK 11 based Maven artifact.
-2.0.4
+2.1.0

A project using desugared library version 2.1.0 fails Android Studio sync with AGP 8.2.0 with:

A build operation failed.
    Could not resolve all files for configuration ':app:detachedConfiguration3'.
Could not resolve all files for configuration ':app:detachedConfiguration3'.
Failed to transform FakeDependency.jar to match attributes {artifactType=_internal-d8-desugar-methods, enable-core-library-desugaring=true, org.gradle.libraryelements=jar, org.gradle.usage=java-runtime}.
Execution failed for D8BackportedMethodsGenerator: /usr/local/google/home/sgjesse/.gradle/android/FakeDependency.jar.
Multiple entries with same key: java.util.Collection=com.android.tools.r8.internal.Vg@e66b7e62 and java.util.Collection=com.android.tools.r8.internal.Vg@7a4f79c0

Building with ./gradlew :app:assembleRelease fails the same way:

Caused by: java.lang.IllegalArgumentException: Multiple entries with same key: java.util.Collection=com.android.tools.r8.internal.Vg@72f203a1 and java.util.Collection=com.android.tools.r8.internal.Vg@6cafea8c
        at com.android.tools.r8.internal.Im.a(R8_8.2.33_429c93fd24a535127db6f4e2628eb18f2f978e02f99f55740728d6b22bef16dd:1)
        ...

Same for AGP 8.1 and 8.0.

Comments

sg...@google.com <sg...@google.com> #2Jan 11, 2024 11:57AM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

sg...@google.com <sg...@google.com> #3Jan 11, 2024 12:18PM

Almost 2 months later and this is still broken

Message last modified on Jan 11, 2024 01:11PM

sg...@google.com <sg...@google.com> #4Jan 11, 2024 12:46PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

sg...@google.com <sg...@google.com> #5Jan 11, 2024 01:17PM

jb...@google.com What is the update on this?

ap...@google.com <ap...@google.com> #6Jan 11, 2024 01:24PM

What is the status of this item?

ap...@google.com <ap...@google.com> #7Jan 11, 2024 01:24PM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

ap...@google.com <ap...@google.com> #8Jan 11, 2024 01:24PM

Any ETA on next release?

ap...@google.com <ap...@google.com> #9Jan 11, 2024 02:41PM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

ap...@google.com <ap...@google.com> #10Jan 11, 2024 02:41PM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

ap...@google.com <ap...@google.com> #11Jan 11, 2024 02:41PM

Hi, is there any update to this issue? Thanks.

ap...@google.com <ap...@google.com> #12Jan 11, 2024 02:41PM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

ap...@google.com <ap...@google.com> #13Jan 11, 2024 02:41PM

Yeah, still not fixed --'

ap...@google.com <ap...@google.com> #14Jan 11, 2024 02:41PM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

ap...@google.com <ap...@google.com> #15Jan 11, 2024 02:42PM

Any updates on this? The help for this command clearly states this argument is supported.

ap...@google.com <ap...@google.com> #16Jan 11, 2024 02:42PM

Has anyone re-tried it? We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt in our Dockerfile back in March of 2021.

sg...@google.com <sg...@google.com> #17Jan 22, 2024 04:37PM

Marked as fixed.

For what it's worth, I did a quick test with the latest CLI: 11076708 (https://developer.android.com/studio#downloads) on OSX and tried it with a simple:

./sdkmanager --sdk_root="../sdk" --package_file=deps.txt

Deps.txt:

platform-tools
extras;google;instantapps
build-tools;35.0.0-rc3

So perhaps this is now resolved? I haven't tried it with more packages

an...@google.com <an...@google.com> #18Jan 23, 2024 06:00PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Hedgehog | 2023.1.1 Patch 2
Android Gradle Plugin 8.2.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

so...@google.com <so...@google.com> #19Jan 27, 2024 11:41PM

Comment added by automation: A postmortem has been automatically requested for this issue. Please author a postmortem on IRM. See go/android-postmortem-guidance for more context and details, including how to handle the case when this issue does not need a postmortem. If you have any questions not answered by go/android-postmortem-guidance, please email android-hygiene-tpm@, instead of reassigning the fixed bug. Thank you.

an...@google.com <an...@google.com> #20Feb 5, 2024 05:57PM

The fixes for this issue are now also available in:

Android Studio Iguana | 2023.2.1 RC 1
Android Gradle Plugin 8.3.0-rc01