Status Update
Comments
co...@google.com <co...@google.com> #3
ma...@gmail.com <ma...@gmail.com> #4
EnhancedIconButton just my wrapper for yours, it's okay, problem happens only on new version, and also broke the text LocalContentColor
This ones shouldn't be black, and they are only on newest version :(
ma...@gmail.com <ma...@gmail.com> #5
I found where it happens, card provides wrong content color, which is always black if there is no suitalble color for given one, i think fallback should be onSurface instead of black
co...@google.com <co...@google.com> #7
Looks like prior to [these changes], contentColor = contentColorFor(containerColor)
so it was automatically invalidated when the containerColor
changed, after this, they were not.
Looks like is currently impacting *CardColors
and would FilledIconColors
/ FilledIconToggleColors
EXCEPT they haven't been updated use a cached object yet.
ap...@google.com <ap...@google.com> #8
Branch: androidx-main
commit e7dc654fe9c80bc88b845c4138269583780e268b
Author: Connie Shi <connieshi@google.com>
Date: Fri Jan 12 12:58:47 2024
Fixed bug introduced in 1.2.0-beta02 in `CardDefaults.cardColors` that did not update `contentColor` based on the `containerColor` param value. Updated `CardDefault.elevatedCardColors` and `CardDefault.outlinedCardColors` to prevent this bug.
Bug:
Test: Added tests.
Relnote: "Fixed bug introduced in 1.2.0-beta02 in CardDefaults.cardColors that did not update `contentColor` based on the `containerColor` param value."
Change-Id: Iee041b79156739af98a1d6fc0a0b36bc99ba1586
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/CardTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Card.kt
co...@google.com <co...@google.com>
na...@google.com <na...@google.com> #9
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.2.0-rc01
androidx.compose.material3:material3-android:1.2.0-rc01
androidx.compose.material3:material3-desktop:1.2.0-rc01
Description
instead of broken content color for icons there are also bug with text
@Composable
fun ExpandableItem(
modifier: Modifier = Modifier,
visibleContent: @Composable RowScope.(Boolean) -> Unit,
expandableContent: @Composable ColumnScope.(Boolean) -> Unit,
initialState: Boolean = false,
verticalArrangement: Arrangement.Vertical = Arrangement.Top,
shape: RoundedCornerShape = RoundedCornerShape(20.dp),
color: Color = MaterialTheme.colorScheme.surfaceColorAtElevation(2.dp)
) {
val haptics = LocalHapticFeedback.current
Column(
Modifier
.animateContentSize()
.then(modifier)
.container(
color = color,
resultPadding = 0.dp,
shape = shape
)
) {
var expanded by rememberSaveable { mutableStateOf(initialState) }
val rotation by animateFloatAsState(if (expanded) 180f else 0f)
Row(
modifier = Modifier
.clip(shape)
.clickable {
haptics.performHapticFeedback(
HapticFeedbackType.LongPress
)
expanded = !expanded
}
.padding(8.dp),
verticalAlignment = Alignment.CenterVertically
) {
Row(Modifier.weight(1f)) {
visibleContent(expanded)
}
EnhancedIconButton(
containerColor = Color.Transparent,
contentColor = LocalContentColor.current,
enableAutoShadowAndBorder = false,
onClick = { expanded = !expanded }
) {
Icon(
imageVector = Icons.Rounded.KeyboardArrowDown,
contentDescription = null,
modifier = Modifier.rotate(rotation)
)
}
}
AnimatedVisibility(expanded) {
Column(verticalArrangement = verticalArrangement) {
Spacer(modifier = Modifier.height(8.dp))
expandableContent(expanded)
Spacer(modifier = Modifier.height(8.dp))
}
}
}
}
this code gives EnhancedIconButton black color instead of needed one, moreover, the text inside visible content is also black!!!!!!!!!!
BUT container modifier provides it and all were okay on previous version
fun Modifier.container(
shape: Shape = RoundedCornerShape(16.dp),
color: Color = Color.Unspecified,
resultPadding: Dp = 4.dp,
borderColor: Color? = null,
autoShadowElevation: Dp = 1.dp,
clip: Boolean = true,
composeColorOnTopOfBackground: Boolean = true,
isShadowClip: Boolean = false,
isStandaloneContainer: Boolean = true
) = composed {
val localContainerShape = LocalContainerShape.current
val resultShape = localContainerShape ?: shape
val settingsState = LocalSettingsState.current
val colorScheme = MaterialTheme.colorScheme
val color1 = if (color.isUnspecified) {
colorScheme.surfaceColorAtElevation(1.dp)
} else {
if (composeColorOnTopOfBackground) color.compositeOver(colorScheme.background)
else color
}
val density = LocalDensity.current
val genericModifier = Modifier.drawWithCache {
val outline = resultShape.createOutline(
size,
layoutDirection,
density
)
onDrawWithContent {
drawOutline(
outline = outline,
color = color1
)
if (settingsState.borderWidth > 0.dp) {
drawOutline(
outline = outline,
color = borderColor ?: colorScheme.outlineVariant(0.1f, color1),
style = Stroke(with(density) { settingsState.borderWidth.toPx() })
)
}
drawContent()
}
}
val cornerModifier = Modifier
.background(
color = color1,
shape = resultShape
)
.border(
width = LocalSettingsState.current.borderWidth,
color = borderColor ?: colorScheme.outlineVariant(0.1f, color1),
shape = resultShape
)
this
.materialShadow(
shape = resultShape,
elevation = animateDpAsState(
if (settingsState.borderWidth > 0.dp) {
0.dp
} else autoShadowElevation.coerceAtLeast(0.dp)
).value,
enabled = if (isStandaloneContainer) {
LocalSettingsState.current.drawContainerShadows
} else true,
isClipped = isShadowClip
)
.then(
if (resultShape is CornerBasedShape) cornerModifier
else genericModifier
)
.then(if (clip) Modifier.clip(resultShape) else Modifier)
.then(if (resultPadding > 0.dp) Modifier.padding(resultPadding) else Modifier)
}