Status Update
No update yet.
Comments
gr...@google.com
Hi. Thanks for reporting this. Fixed in alpha-04
gr...@google.com
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
gr...@google.com
gr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
gr...@google.com
so...@google.com
In addition to TextAlign, we've changed TextDirection, Hyphens and LineBreak at the same time. So let's update all of them at once.
gr...@google.com
Created
gr...@google.com
minimal repro attached
gr...@google.com
Verified the fix in
In Android Studio I built aosp/2918751 by running the demo app.
Then, I found the jar file used in the build at:
~/workspace/androidx-main/out/androidx/compose/ui/ui-text/build/intermediates/compile_library_classes_jar/debug/bundleLibCompileToJarDebug/classes.jar
I modified the repro project build.gradle (project, not library) to remove the module being changed via adding the following above dependencies at the top level:
configurations.all {
exclude(group = "androidx.compose.ui", module = "ui-text")
}
and then adding it back in to the project via the following inside the dependencies:
dependencies {
...
implementation(files("~/workspace/androidx-main/out/androidx/compose/ui/ui-text/build/intermediates/compile_library_classes_jar/debug/bundleLibCompileToJarDebug/classes.jar"))
}
By this not immediately crashing on start up, it verifies that the currently incompatible methods have been made compatible with the change in aosp/2918751.
ap...@google.com
Branch: androidx-main
commit 9ed6b9a2f42e3a1f0c4c5e123f0e2c703b7d4fed
Author: Grant Toepfer <grantapher@google.com>
Date: Fri Jan 19 12:36:15 2024
Fix binary backwards compatibility in Text/ParagraphStyle
go/mangling-binary-compat
Since the properties introduced for binary backwards compatibility didn't include the inline class mangling in their jvm name, the changes were not truly backwards compatible. This change adds the correct inline class mangling to the jvm names of the getter methods.
Relnote: Fixed backwards binary incompatibility in TextStyle and ParagraphStyle
Test: Manually verified (see
Fixes:
Change-Id: I179f0ff77b3b85a05d98a28405ad936d2e9413cf
M compose/ui/ui-text/api/current.ignore
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/restricted_current.ignore
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
gr...@google.com
Expect the fix in the next compose release.
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui-text:1.6.0androidx.compose.ui:ui-text-android:1.6.0androidx.compose.ui:ui-text-desktop:1.6.0
Description
Jetpack Compose version: 1.6.0-rc01
Jetpack Compose component(s) used: ui
Android Studio Build: 2023.2.1 Beta 2
Kotlin version: 1.9.20
Steps to Reproduce or Code Sample to Reproduce:
Compile a module with Compose 1.5.x, that has code reading a TextStyle.textAlign property
consume that module in another project that is using compose 1.6
at runtime crashes
Stack trace (if applicable):
I see in 1.6 there is an attempt to handle this incompatibility by adding this method, but its not working: