Fixed
Status Update
No update yet.
Comments
ma...@google.com
se...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt - M
compose/foundation/foundation/api/restricted_current.txt - M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt - M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt - M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
se...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06androidx.compose.foundation:foundation-android:1.8.0-alpha06androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
ma...@google.com
co...@google.com
ma...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit bdc6e1b597b14a0f4d58aff5e5d1b079a7c1ba5d
Author: Mariano Martin <marianomartin@google.com>
Date: Mon Mar 25 11:06:17 2024
[TabRow] Fix tab row indicator height
Bug: 321997863
Test: added tabRow_indicatorHeight
Change-Id: I2d34896eb576ed8cd99347b1192566cfebd9cd4a
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TabTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TabRow.kt
https://android-review.googlesource.com/3011353
Branch: androidx-main
commit bdc6e1b597b14a0f4d58aff5e5d1b079a7c1ba5d
Author: Mariano Martin <marianomartin@google.com>
Date: Mon Mar 25 11:06:17 2024
[TabRow] Fix tab row indicator height
Bug: 321997863
Test: added tabRow_indicatorHeight
Change-Id: I2d34896eb576ed8cd99347b1192566cfebd9cd4a
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TabTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TabRow.kt
Description
Jetpack Compose M3 version: 1.2.0-beta02
Jetpack Compose component used: PrimaryTabRow
Android Studio Build: 8.3.0-beta02
Kotlin version: 1.9.22
Steps to Reproduce or Code Sample to Reproduce:
Result:
Tab indicators overlap the tab text (see attached "broken_tabs.png")
Sample Project
I created a sample project (see attached PrimaryTabRowIssue.zip) that reproduces this issue (following the steps above). I added the ComposeView to the first_fragment.xml file.
Notes