PowerRail is restricted to LIBRARY_GROUP_SCOPE, but required to determine support availability [322121218]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Jan 24, 2024 08:47AM

Component used: Macrobenchmarks Version used: N/A Devices/Android versions reproduced on: N/A

Attempting to obtain PowerMetrics on unsupported devices sees this:

java.lang.UnsupportedOperationException: Rail metrics are not available on this device.
To check a device for power/energy measurement support, the following command's
output must contain rows underneath the "available Channels" section:

adb shell dumpsys powerstats

To check at runtime for this, use PowerRail.hasMetrics()

PowerRail though, is restricted to LIBRARY_GROUP_SCOPE and so one needs to use a lint suppress.

Comments

cc...@google.com <cc...@google.com> #2Jan 24, 2024 05:16PM

Thanks for the report, we should have a wrapper for this in PowerMetric

cc...@google.com <cc...@google.com> Apr 11, 2024 11:40PM

Accepted by cc...@google.com.

ap...@google.com <ap...@google.com> #3Apr 22, 2024 06:40PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 1c2d72fbf20c936b18a8e887f7c82aa8e2c706b5
Author: Chris Craik <ccraik@google.com>
Date: Tue Mar 19 10:45:01 2024

Add API for checking power metric device support

Fixes: 322121218
Test: PowerMetricTest
Relnote: "Added PowerMetric.deviceBatteryHasMinimumCharge() and
PowerMetric.deviceSupportsPowerEnergy() to enable changing or skipping
benchmarks based on device power measurement capability."

Change-Id: I6a591cd0c68e7a9e93069ee7f636fc1772f9a256

M benchmark/benchmark-macro/api/current.txt
M benchmark/benchmark-macro/api/restricted_current.txt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PowerMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PowerRailTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/PowerRail.kt

https://android-review.googlesource.com/3040212

Issue 322121218

Description

Issue summary

Comments

cc...@google.com <cc...@google.com> #2Jan 24, 2024 05:16PM

cc...@google.com <cc...@google.com> Apr 11, 2024 11:40PM

ap...@google.com <ap...@google.com> #3Apr 22, 2024 06:40PM

Add comment

Issue metadata