Using android=true for commonMain breaks expect/actual linking [322156458]

In Progress

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Jan 24, 2024 02:55PM

I'm converting room-runtime to Kotlin Multiplatform and the API tool in androidx is incorrectly flagging the removal of a default value in a parameter.

I had the following Android only class

class TableInfo(
  val name: String,
  // ...
  val indices: Set<String>? = null
)

and I am now converting it to an actual/expect declaration:

// TableInfo.kt
expect TableInfo(
  name: String,
  // ...
  indices: Set<String>? = null
)

// TableInfo.android.kt
actual TableInfo actual constructor(
  val name: String,
  // ...
  val indices: Set<String>?
)

then after running updateApi I get the following API change error:

error: Attempted to remove default value from parameter indices in androidx.room.util.TableInfo [DefaultValueChange]

however it is an error to have a default value in an 'actual' function param, if I try to add the default value to TableInfo.android.kt then Kotlin compiler errors out with:

TableInfo.android.kt:46:5 Actual function cannot have default argument values, they should be declared in the expected function

When looking at the .class file produced, the Kotlin generated default value constructors are present:

javap -p '/usr/local/google/home/danysantiago/.gradle/.m2/repository/androidx/room/room-runtime-android/2.7.0-alpha01/TableInfo.class' 
  ...
  public androidx.room.util.TableInfo(java.lang.String, java.util.Map<java.lang.String, androidx.room.util.TableInfo$Column>, java.util.Set<androidx.room.util.TableInfo$ForeignKey>, java.util.Set<androidx.room.util.TableInfo$Index>);
  public androidx.room.util.TableInfo(java.lang.String, java.util.Map, java.util.Set, java.util.Set, int, kotlin.jvm.internal.DefaultConstructorMarker);
  public androidx.room.util.TableInfo(java.lang.String, java.util.Map<java.lang.String, androidx.room.util.TableInfo$Column>, java.util.Set<androidx.room.util.TableInfo$ForeignKey>);
  ...

So it seems to be an incorrect API breakage flag.

Here is my full CL: aosp/2925831, notice I ignore the API change, so remember to remove the ignore to reproduce.

Comments

ap...@google.com <ap...@google.com> #2Jan 31, 2024 01:36AM

After some googling I found

https://github.com/android/camera-samples/blob/master/CameraXBasic/app/src/main/java/com/android/example/cameraxbasic/utils/AutoFitPreviewBuilder.kt which does what I want. Would it be possible to fold this into the main library or at least make it configurable without the need for that class?

ju...@google.com <ju...@google.com> Dec 17, 2024 07:12PM

Reassigned to ju...@google.com.

ju...@google.com <ju...@google.com> #3Dec 19, 2024 05:57PM

Hi Charcoal,

Are we getting a crop mode here? Thanks!

ap...@google.com <ap...@google.com> #4Jan 8, 2025 12:08AM

Hello,
Thanks for raising this up. May we know did you set aspect ratio or resolution for Preview use case? And could you also attach the captured image file?

ap...@google.com <ap...@google.com> #5Jan 8, 2025 10:19AM

The captured image file is part of the image file that I've already attached (the right part).

I did not set anything on the Preview use case other than the lens facing.

```
val cameraPreview = Preview(Builder()
.setLensFacing(CameraX.LensFacing.BACK)
.build())

cameraPreview.setOnPreviewOutputUpdateListener {
// Every time the viewfinder is updated, recompute the layout. By removing and re-adding it.
val parent = parent as ViewGroup
parent.removeView(this)
parent.addView(this, 0)

surfaceTexture = it.surfaceTexture
updateTransform()
}

CameraX.bindToLifecycle(lifecycleOwner, cameraPreview, *useCase)
```

ju...@google.com <ju...@google.com> Feb 24, 2025 09:29PM

Reassigned to bu...@google.com.

bu...@google.com <bu...@google.com> #6Feb 24, 2025 09:35PM

Accepted by bu...@google.com.

Would you also set the same TargetRotation to Preview at onOrientationChanged? Let me know if it works.