Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
We don't really need the id. You can always use -e
as a shorthand for an emulator.
na...@google.com <na...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 6fec8f186ae5d1667ea4eb17e697b70ea26539f9
Author: Chris Craik <ccraik@google.com>
Date: Fri Oct 21 14:28:32 2022
Specify device in baseline profile adb pull command
Fixes: 223359380
Test: BaselineProfilesTest
Test: BaselineProfileRuleTest
Relnote: Specify device in baseline profile `adb pull` command
Change-Id: I6ac6c7d2bbd9888dd889b1b790ba21795464f4fa
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/BaselineProfilesTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
https://android-review.googlesource.com/2264199
Branch: androidx-main
commit 6fec8f186ae5d1667ea4eb17e697b70ea26539f9
Author: Chris Craik <ccraik@google.com>
Date: Fri Oct 21 14:28:32 2022
Specify device in baseline profile adb pull command
Fixes: 223359380
Test: BaselineProfilesTest
Test: BaselineProfileRuleTest
Relnote: Specify device in baseline profile `adb pull` command
Change-Id: I6ac6c7d2bbd9888dd889b1b790ba21795464f4fa
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/BaselineProfilesTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
Description
I see
Mode.Min
andMode.Max
were recently added, would it be possible to also add a Mode for P50/P90/P95/P99, or similar? For example we may expect the first execution of a block of code to be slower due to initializations, and faster on subsequent executions. It would be great to have a metric to measure this type of situation.Mode.Average
would be convenient. This can already be figured usingMode.Sum
since it supplies the count and total duration, but condensing the result into a single line would be nice.