TextField Crashes if any accessibility service is enabled [322269946]

Verified

Bug

Status Update

No update yet.

Description

en...@gmail.com

created issue #1

Jan 25, 2024 07:40AM

Jetpack Compose version: All

Jetpack Compose component(s) used: TextField

Android Studio Build: All

Kotlin version: 1.9.20

Steps to Reproduce or Code Sample to Reproduce: Steps to Reproduce

Enable any accessibility service (Accessibility menu for example) example image in the attachments
Create any project with compose text field in it

TextField Crashes if any accessibility service is enabled

Stack trace

stacktrace sample-> java.lang.NoSuchMethodError: No static method performImeAction$default(Landroidx/compose/ui/semantics/SemanticsPropertyReceiver;Ljava/lang/String;Lkotlin/jvm/functions/Function0;ILjava/lang/Object;)V in class Landroidx/compose/ui/semantics/SemanticsPropertiesKt; or its super classes (declaration of 'androidx.compose.ui.semantics.SemanticsPropertiesKt' appears in /data/app/~~bTEBuukrv3ZR6g5DPUNbyw==/com.lightfeather.Masarify-ImR5gIfbyLM4yyFLJrUwjg==/base.apk!classes20.dex)
 at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$semanticsModifier$1.invoke(CoreTextField.kt:532)
 at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$semanticsModifier$1.invoke(CoreTextField.kt:433)
 at androidx.compose.ui.semantics.CoreSemanticsModifierNode.applySemantics(SemanticsModifier.kt:73)
 at androidx.compose.ui.node.LayoutNode$collapsedSemantics$1.invoke(LayoutNode.kt:430)
 at androidx.compose.ui.node.LayoutNode$collapsedSemantics$1.invoke(LayoutNode.kt:421)
 at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2303)
 at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:496)
 at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:256)
 at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
 at androidx.compose.ui.node.OwnerSnapshotObserver.observeSemanticsReads$ui_release(OwnerSnapshotObserver.kt:121)
 at androidx.compose.ui.node.LayoutNode.getCollapsedSemantics$ui_release(LayoutNode.kt:421)
 at androidx.compose.ui.semantics.SemanticsNodeKt.SemanticsNode(SemanticsNode.kt:48)
 at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:268)
 at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:270)
 at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:270)
 at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:270)
 at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:270)
 at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:270)
 at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:270)
 at androidx.compose.ui.semantics.SemanticsNode.unmergedChildren$ui_release(SemanticsNode.kt:248)
 at androidx.compose.ui.semantics.SemanticsNode.getChildren(SemanticsNode.kt:327)
 at androidx.compose.ui.semantics.SemanticsNode.getReplacedChildren$ui_release(SemanticsNode.kt:298)
 at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap$findAllSemanticNodesRecursive(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3648)
 at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap$findAllSemanticNodesRecursive(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3650)
 at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap$findAllSemanticNodesRecursive(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3650)
 at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3681)
 at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.getCurrentSemanticsNodes$ui_release(AndroidComposeViewAccessibilityDelegateCompat.android.kt:344)
 at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.sendAccessibilitySemanticsStructureChangeEvents(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3073)at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.checkForSemanticsChanges(AndroidComposeViewAccessibilityDelegateCompat.android.kt:2361)
 at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.semanticsChangeChecker$lambda$45(AndroidComposeViewAccessibilityDelegateCompat.android.kt:2190)
 at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.$r8$lambda$zl-dD2MYfrX1ZDGYRPCA_Ir1-pM(Unknown Source:0)
 at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat$$ExternalSyntheticLambda2.run(Unknown Source:2)
 at android.os.Handler.handleCallback(Handler.java:938)
 at android.os.Handler.dispatchMessage(Handler.java:99)
 at android.os.Looper.loopOnce(Looper.java:210)
 at android.os.Looper.loop(Looper.java:299)
 at android.app.ActivityThread.main(ActivityThread.java:8319)
 at java.lang.reflect.Method.invoke(Native Method)
 at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:556)
 at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1038)

photo_2024-01-18_21-30-42.jpg

51 KB

View

Download

photo_2024-01-18_21-30-38.jpg

36 KB

View

Download

Comments

gr...@google.com <gr...@google.com> #2Jan 25, 2024 09:09PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

bp...@atimi.com <bp...@atimi.com> #3Jan 26, 2024 09:36PM

This may be a duplicate of:

https://issuetracker.google.com/322495950

bp...@atimi.com <bp...@atimi.com> #4Jan 26, 2024 09:37PM

We can reproduce it on an emulator, the device does not matter much.

gr...@google.com <gr...@google.com> #5Jan 27, 2024 01:08AM

I'm unsure if these are related, will treat them separately for now.

gr...@google.com <gr...@google.com> #6Jan 27, 2024 01:12AM

Reporter, can you share what compose versions you are using?

The missing method from the stack trace was introduced in version 1.5.0-alpha01 (aosp/2441240) and was removed ~~before 1.6.0 (stable)~~ in 1.6.0-alpha01 (aosp/2599070)~~, so it never hit a stable release~~.

Message last modified on Jan 30, 2024 11:49PM

en...@gmail.com <en...@gmail.com> #7Jan 30, 2024 03:29PM

I will share my gradle and catalog files in the attachments
kindly note that i tried to reproduce with minimal code as mentioned but didn't work in my project however it worked when I tried in a new project
I have included my android app and my shared gradle files

libs.versions.toml

4.9 KB

Download

build.gradle.kts

11 KB

Download

build.gradle.kts

1.9 KB

Download

gr...@google.com <gr...@google.com> #8Jan 30, 2024 06:52PM

Are you using these same deps in both the new project and your other project? If not, what does the "new project" deps look like? If you mean the default compose new project, it would still help if you shared those dependencies so that android studio differences don't have an effect on reproduction.

en...@gmail.com <en...@gmail.com> #9Jan 30, 2024 06:56PM

the new project is just plain new kmp project from the jetbrains new wizard
I tried to share the same versions but no changes

gr...@google.com <gr...@google.com> #10Jan 30, 2024 11:35PM

After toying around with the deps a bit, it seems that androidx.compose.material3:material3:1.1.2 uses the 1.4.1 version of compose. Upping this to 1.2.0-rc01 seems to fix the issue by bringing the underlying compose version up to match the 1.6.0-rc01. Alternatively, dropping compose versions to 1.5.4 may help as well.

Still looking for the culprit.

gr...@google.com <gr...@google.com> #11Jan 30, 2024 11:50PM

I misread when the latter CL in #comment6 was released to a jetpack version, and have edited it to be correct. Since performImeAction was removed between 1.5 and 1.6, it should be easier to reproduce this.

gr...@google.com <gr...@google.com> #12Jan 31, 2024 01:49AM

reproducible with the following when the accessibility menu shortcut is enabled:

dependencies:

configurations.all {
    resolutionStrategy {
        force("androidx.compose.ui:ui:1.6.0")
    }
}

dependencies {
    implementation("androidx.activity:activity-compose:1.8.2")
    implementation("androidx.compose.foundation:foundation:1.5.4")
}

code:

import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.compose.foundation.text.BasicTextField
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.text.input.TextFieldValue

class MainActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContent {
            var tfv by remember { mutableStateOf(TextFieldValue("Hello!")) }
            BasicTextField(
                value = tfv,
                onValueChange = { tfv = it },
            )
        }
    }
}

gr...@google.com <gr...@google.com> #13Jan 31, 2024 08:41PM

Reassigned to gr...@google.com.

This seems to be an escaped binary incompatibility. It seems like the latter change should have landed into one of the 1.5 betas, but it ended up not being included.

gr...@google.com <gr...@google.com> #14Jan 31, 2024 10:19PM

CL introducing members: aosp/2441240
CL adding a parameter to member: aosp/2580451
CL renaming members: aosp/2599070

1 was introduced in 1.5.0-alpha01, 2 and 3 were supposed to be in any of the 1.5 betas, but ended up landing in 1.6.0-alpha01. I created aosp/2940254 to bring binary compatibility up to date with 1 above, because the APIs in 1 are the APIs released into all 1.5 stable versions.

ap...@google.com <ap...@google.com> #15Feb 1, 2024 12:17AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7c556d51a1ff4b14d50b7c7dddc496032da133fb
Author: Grant Toepfer <grantapher@google.com>
Date: Wed Jan 31 14:05:30 2024

Fix binary compatibility for PerformImeAction

Some semantics members that were supposed to be removed in 1.5 betas escaped into 1.5, and then were instead removed in 1.6. This change re-adds deprecated hidden members to maintain binary compatibility with 1.5.

Relnote: Fixed a binary compatibility issue with `SemanticsPropertyReceiver.performImeAction`.
Test: N/A
Fixes:

b/322269946

Change-Id: I658657d6a697e6c5e09cb95500410bd73f237c1b

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/2940254

kl...@google.com <kl...@google.com> #16Feb 1, 2024 12:20AM

Postmortem

gr...@google.com <gr...@google.com> #17Feb 1, 2024 12:46AM

Status: In Progress (Accepted) (reopened)

Leaving in progress until cherry-pick complete.

gr...@google.com <gr...@google.com> #18Feb 1, 2024 12:53AM

~~Cherry-pick request submitted.~~

Message last modified on Feb 1, 2024 07:08PM

gr...@google.com <gr...@google.com> #19Feb 1, 2024 07:08PM

Needed to change deprecation level, so reverted the above CL and submitting another

ap...@google.com <ap...@google.com> #20Feb 1, 2024 08:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit 53478385c1311bec3d3bdf86c8c3162ba667081c
Author: Grant Toepfer <grantapher@google.com>
Date: Wed Jan 31 14:05:30 2024

Fix backwards compatibility for PerformImeAction

Some semantics members that were supposed to be removed in 1.5 betas escaped into 1.5, and then were instead removed in 1.6. This change re-adds the members as deprecated to maintain compatibility with 1.5.

Relnote: Fixed a backwards compatibility issue with `SemanticsPropertyReceiver.performImeAction` and `SemanticsActions.PerformImeAction`.
Test: N/A
Bug:

b/322269946

Change-Id: Id0528d5c5115ce4a6f703547be943a9740c22860

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/2942308

gr...@google.com <gr...@google.com> #21Feb 6, 2024 10:27PM

Targeting 1.6.1 (the next release).

gr...@google.com <gr...@google.com> #22Feb 7, 2024 10:37PM

Marked as fixed.

Released in 1.6.1.

Reporter, can you verify the fix? Marking it as fixed for now. Feel free to re-open if you still have the same issue.

en...@gmail.com <en...@gmail.com> #23Feb 11, 2024 06:32PM

Fixed in 1.6.1 Thanks for your efforts

gr...@google.com <gr...@google.com> Feb 12, 2024 06:39PM

Verified by gr...@google.com.

pr...@google.com <pr...@google.com> #24Feb 21, 2024 07:32PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.7.0-alpha03
androidx.compose.ui:ui-android:1.7.0-alpha03
androidx.compose.ui:ui-desktop:1.7.0-alpha03

Issue 322269946

Description

Issue summary

Comments

gr...@google.com <gr...@google.com> #2Jan 25, 2024 09:09PM

bp...@atimi.com <bp...@atimi.com> #3Jan 26, 2024 09:36PM

bp...@atimi.com <bp...@atimi.com> #4Jan 26, 2024 09:37PM

gr...@google.com <gr...@google.com> #5Jan 27, 2024 01:08AM

gr...@google.com <gr...@google.com> #6Jan 27, 2024 01:12AM

en...@gmail.com <en...@gmail.com> #7Jan 30, 2024 03:29PM

gr...@google.com <gr...@google.com> #8Jan 30, 2024 06:52PM

en...@gmail.com <en...@gmail.com> #9Jan 30, 2024 06:56PM

gr...@google.com <gr...@google.com> #10Jan 30, 2024 11:35PM

gr...@google.com <gr...@google.com> #11Jan 30, 2024 11:50PM

gr...@google.com <gr...@google.com> #12Jan 31, 2024 01:49AM

gr...@google.com <gr...@google.com> #13Jan 31, 2024 08:41PM

gr...@google.com <gr...@google.com> #14Jan 31, 2024 10:19PM

ap...@google.com <ap...@google.com> #15Feb 1, 2024 12:17AM

kl...@google.com <kl...@google.com> #16Feb 1, 2024 12:20AM

gr...@google.com <gr...@google.com> #17Feb 1, 2024 12:46AM

gr...@google.com <gr...@google.com> #18Feb 1, 2024 12:53AM

gr...@google.com <gr...@google.com> #19Feb 1, 2024 07:08PM

ap...@google.com <ap...@google.com> #20Feb 1, 2024 08:02PM

gr...@google.com <gr...@google.com> #21Feb 6, 2024 10:27PM

gr...@google.com <gr...@google.com> #22Feb 7, 2024 10:37PM

en...@gmail.com <en...@gmail.com> #23Feb 11, 2024 06:32PM

gr...@google.com <gr...@google.com> Feb 12, 2024 06:39PM

pr...@google.com <pr...@google.com> #24Feb 21, 2024 07:32PM

Add comment

Issue metadata