Status Update
No update yet.
Comments
gr...@google.com
First of all thanks for this detailed issue.
This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.
The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.
Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.
bp...@atimi.com
Or is that option not available?
Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.
bp...@atimi.com
Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.
Compose 1.7 has a bug that causes ANR when the focus is on EditText.
Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus().
Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.
In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.
gr...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <
Link:
Fix POBox keyboard issue
Expand for full commit details
Fix POBox keyboard issue
Fix: 373743376
Fix: 329209241
Test: NullableInputConnectionWrapperTest
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt - M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt
Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024
gr...@google.com
Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.
en...@gmail.com
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.
gr...@google.com
Yes, this fix is planned to be included in a future 1.7.x release.
en...@gmail.com
Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.
gr...@google.com
After toying around with the deps a bit, it seems that androidx.compose.material3:material3:1.1.2 uses the 1.4.1 version of compose. Upping this to 1.2.0-rc01 seems to fix the issue by bringing the underlying compose version up to match the 1.6.0-rc01. Alternatively, dropping compose versions to 1.5.4 may help as well.
Still looking for the culprit.
gr...@google.com
reproducible with the following when the accessibility menu shortcut is enabled:
dependencies:
configurations.all {
resolutionStrategy {
force("androidx.compose.ui:ui:1.6.0")
}
}
dependencies {
implementation("androidx.activity:activity-compose:1.8.2")
implementation("androidx.compose.foundation:foundation:1.5.4")
}
code:
import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.compose.foundation.text.BasicTextField
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.text.input.TextFieldValue
class MainActivity : ComponentActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContent {
var tfv by remember { mutableStateOf(TextFieldValue("Hello!")) }
BasicTextField(
value = tfv,
onValueChange = { tfv = it },
)
}
}
}
gr...@google.com
This seems to be an escaped binary incompatibility. It seems like the latter change should have landed into one of the 1.5 betas, but it ended up not being included.
gr...@google.com
- CL introducing members:
aosp/2441240 - CL adding a parameter to member:
aosp/2580451 - CL renaming members:
aosp/2599070
1 was introduced in 1.5.0-alpha01, 2 and 3 were supposed to be in any of the 1.5 betas, but ended up landing in 1.6.0-alpha01. I created
ap...@google.com
Branch: androidx-main
commit 7c556d51a1ff4b14d50b7c7dddc496032da133fb
Author: Grant Toepfer <grantapher@google.com>
Date: Wed Jan 31 14:05:30 2024
Fix binary compatibility for PerformImeAction
Some semantics members that were supposed to be removed in 1.5 betas escaped into 1.5, and then were instead removed in 1.6. This change re-adds deprecated hidden members to maintain binary compatibility with 1.5.
Relnote: Fixed a binary compatibility issue with `SemanticsPropertyReceiver.performImeAction`.
Test: N/A
Fixes:
Change-Id: I658657d6a697e6c5e09cb95500410bd73f237c1b
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt
kl...@google.com
gr...@google.com
Leaving in progress until cherry-pick complete.
gr...@google.com
Cherry-pick request submitted.
gr...@google.com
Needed to change deprecation level, so reverted the above CL and submitting another
ap...@google.com
Branch: androidx-main
commit 53478385c1311bec3d3bdf86c8c3162ba667081c
Author: Grant Toepfer <grantapher@google.com>
Date: Wed Jan 31 14:05:30 2024
Fix backwards compatibility for PerformImeAction
Some semantics members that were supposed to be removed in 1.5 betas escaped into 1.5, and then were instead removed in 1.6. This change re-adds the members as deprecated to maintain compatibility with 1.5.
Relnote: Fixed a backwards compatibility issue with `SemanticsPropertyReceiver.performImeAction` and `SemanticsActions.PerformImeAction`.
Test: N/A
Bug:
Change-Id: Id0528d5c5115ce4a6f703547be943a9740c22860
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt
gr...@google.com
Targeting 1.6.1 (the next release).
gr...@google.com
Released in 1.6.1.
Reporter, can you verify the fix? Marking it as fixed for now. Feel free to re-open if you still have the same issue.
en...@gmail.com
gr...@google.com
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui:1.7.0-alpha03androidx.compose.ui:ui-android:1.7.0-alpha03androidx.compose.ui:ui-desktop:1.7.0-alpha03
Description
Jetpack Compose version: All
Jetpack Compose component(s) used: TextField
Android Studio Build: All
Kotlin version: 1.9.20
Steps to Reproduce or Code Sample to Reproduce: Steps to Reproduce
TextField Crashes if any accessibility service is enabled
Stack trace