Status Update
No update yet.
Comments
gr...@google.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
bp...@atimi.com
bp...@atimi.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
gr...@google.com
I'm unsure if these are related, will treat them separately for now.
gr...@google.com
Reporter, can you share what compose versions you are using?
The missing method from the stack trace was introduced in version 1.5.0-alpha01 (before in 1.6.0 (stable)1.6.0-alpha01 (, so it never hit a stable release.
en...@gmail.com
kindly note that i tried to reproduce with minimal code as mentioned but didn't work in my project however it worked when I tried in a new project
I have included my android app and my shared gradle files
gr...@google.com
Are you using these same deps in both the new project and your other project? If not, what does the "new project" deps look like? If you mean the default compose new project, it would still help if you shared those dependencies so that android studio differences don't have an effect on reproduction.
en...@gmail.com
I tried to share the same versions but no changes
gr...@google.com
After toying around with the deps a bit, it seems that androidx.compose.material3:material3:1.1.2 uses the 1.4.1 version of compose. Upping this to 1.2.0-rc01 seems to fix the issue by bringing the underlying compose version up to match the 1.6.0-rc01. Alternatively, dropping compose versions to 1.5.4 may help as well.
Still looking for the culprit.
gr...@google.com
reproducible with the following when the accessibility menu shortcut is enabled:
dependencies:
configurations.all {
resolutionStrategy {
force("androidx.compose.ui:ui:1.6.0")
}
}
dependencies {
implementation("androidx.activity:activity-compose:1.8.2")
implementation("androidx.compose.foundation:foundation:1.5.4")
}
code:
import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.compose.foundation.text.BasicTextField
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.text.input.TextFieldValue
class MainActivity : ComponentActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContent {
var tfv by remember { mutableStateOf(TextFieldValue("Hello!")) }
BasicTextField(
value = tfv,
onValueChange = { tfv = it },
)
}
}
}
gr...@google.com
This seems to be an escaped binary incompatibility. It seems like the latter change should have landed into one of the 1.5 betas, but it ended up not being included.
gr...@google.com
- CL introducing members:
aosp/2441240 - CL adding a parameter to member:
aosp/2580451 - CL renaming members:
aosp/2599070
1 was introduced in 1.5.0-alpha01, 2 and 3 were supposed to be in any of the 1.5 betas, but ended up landing in 1.6.0-alpha01. I created
ap...@google.com
Branch: androidx-main
commit 7c556d51a1ff4b14d50b7c7dddc496032da133fb
Author: Grant Toepfer <grantapher@google.com>
Date: Wed Jan 31 14:05:30 2024
Fix binary compatibility for PerformImeAction
Some semantics members that were supposed to be removed in 1.5 betas escaped into 1.5, and then were instead removed in 1.6. This change re-adds deprecated hidden members to maintain binary compatibility with 1.5.
Relnote: Fixed a binary compatibility issue with `SemanticsPropertyReceiver.performImeAction`.
Test: N/A
Fixes:
Change-Id: I658657d6a697e6c5e09cb95500410bd73f237c1b
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt
kl...@google.com
gr...@google.com
Leaving in progress until cherry-pick complete.
gr...@google.com
Cherry-pick request submitted.
gr...@google.com
Needed to change deprecation level, so reverted the above CL and submitting another
ap...@google.com
Branch: androidx-main
commit 53478385c1311bec3d3bdf86c8c3162ba667081c
Author: Grant Toepfer <grantapher@google.com>
Date: Wed Jan 31 14:05:30 2024
Fix backwards compatibility for PerformImeAction
Some semantics members that were supposed to be removed in 1.5 betas escaped into 1.5, and then were instead removed in 1.6. This change re-adds the members as deprecated to maintain compatibility with 1.5.
Relnote: Fixed a backwards compatibility issue with `SemanticsPropertyReceiver.performImeAction` and `SemanticsActions.PerformImeAction`.
Test: N/A
Bug:
Change-Id: Id0528d5c5115ce4a6f703547be943a9740c22860
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt
gr...@google.com
Targeting 1.6.1 (the next release).
gr...@google.com
Released in 1.6.1.
Reporter, can you verify the fix? Marking it as fixed for now. Feel free to re-open if you still have the same issue.
en...@gmail.com
gr...@google.com
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui:1.7.0-alpha03androidx.compose.ui:ui-android:1.7.0-alpha03androidx.compose.ui:ui-desktop:1.7.0-alpha03
Description
Jetpack Compose version: All
Jetpack Compose component(s) used: TextField
Android Studio Build: All
Kotlin version: 1.9.20
Steps to Reproduce or Code Sample to Reproduce: Steps to Reproduce
TextField Crashes if any accessibility service is enabled
Stack trace