Fixed
Status Update
Comments
al...@google.com <al...@google.com> #2
While we're at it, let's move the existing check into AndroidX lint-checks
so that it's still running.
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 0b25155d80fa2660cbbe50514326c00d63779443
Author: Alan Viverette <alanv@google.com>
Date: Mon Jan 29 10:59:22 2024
Move ReplaceWithDetector to lint-checks
Fixes: 322373864
Test: ReplaceWithDetector tests
Change-Id: I97c465617493ed34dab564a97811ccb6a1f32bdf
D annotation/annotation-replacewith-lint/build.gradle
D annotation/annotation-replacewith-lint/integration-tests/build.gradle
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ConstructorNonStaticClass.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ConstructorStaticClass.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ConstructorToStaticMethod.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/MethodExplicitThis.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/MethodImplicitThis.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ReplaceWithUsageJava.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ReplaceWithUsageKotlin.kt
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/StaticFieldExplicitClass.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/StaticFieldImplicitClass.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/StaticMethodExplicitClass.java
D annotation/annotation-replacewith-lint/src/main/java/androidx/annotation/replacewith/lint/ReplaceWithIssueRegistry.kt
D annotation/annotation-replacewith-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
D annotation/annotation-replacewith-lint/src/test/kotlin/androidx/annotation/replacewith/lint/ApiLintVersionsTest.kt
M lint-checks/integration-tests/src/main/java/replacewith/ConstructorNonStaticClass.java
M lint-checks/integration-tests/src/main/java/replacewith/ConstructorStaticClass.java
M lint-checks/integration-tests/src/main/java/replacewith/ConstructorToStaticMethod.java
M lint-checks/integration-tests/src/main/java/replacewith/MethodImplicitThis.java
M lint-checks/integration-tests/src/main/java/replacewith/ReplaceWithUsageJava.java
M lint-checks/integration-tests/src/main/java/replacewith/ReplaceWithUsageKotlin.kt
M lint-checks/integration-tests/src/main/java/replacewith/StaticFieldImplicitClass.java
M lint-checks/integration-tests/src/main/java/replacewith/StaticMethodExplicitClass.java
M lint-checks/src/main/java/androidx/build/lint/AndroidXIssueRegistry.kt
M lint-checks/src/main/java/androidx/build/lint/ReplaceWithDetector.kt
M lint-checks/src/test/java/androidx/build/lint/replacewith/ReplaceWithDetectorConstructorTest.kt
M lint-checks/src/test/java/androidx/build/lint/replacewith/ReplaceWithDetectorFieldTest.kt
M lint-checks/src/test/java/androidx/build/lint/replacewith/ReplaceWithDetectorMethodTest.kt
M lint-checks/src/test/java/androidx/build/lint/replacewith/TestUtils.kt
M settings.gradle
https://android-review.googlesource.com/2929331
Branch: androidx-main
commit 0b25155d80fa2660cbbe50514326c00d63779443
Author: Alan Viverette <alanv@google.com>
Date: Mon Jan 29 10:59:22 2024
Move ReplaceWithDetector to lint-checks
Fixes: 322373864
Test: ReplaceWithDetector tests
Change-Id: I97c465617493ed34dab564a97811ccb6a1f32bdf
D annotation/annotation-replacewith-lint/build.gradle
D annotation/annotation-replacewith-lint/integration-tests/build.gradle
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ConstructorNonStaticClass.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ConstructorStaticClass.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ConstructorToStaticMethod.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/MethodExplicitThis.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/MethodImplicitThis.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ReplaceWithUsageJava.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/ReplaceWithUsageKotlin.kt
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/StaticFieldExplicitClass.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/StaticFieldImplicitClass.java
D annotation/annotation-replacewith-lint/integration-tests/src/main/java/sample/StaticMethodExplicitClass.java
D annotation/annotation-replacewith-lint/src/main/java/androidx/annotation/replacewith/lint/ReplaceWithIssueRegistry.kt
D annotation/annotation-replacewith-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
D annotation/annotation-replacewith-lint/src/test/kotlin/androidx/annotation/replacewith/lint/ApiLintVersionsTest.kt
M lint-checks/integration-tests/src/main/java/replacewith/ConstructorNonStaticClass.java
M lint-checks/integration-tests/src/main/java/replacewith/ConstructorStaticClass.java
M lint-checks/integration-tests/src/main/java/replacewith/ConstructorToStaticMethod.java
M lint-checks/integration-tests/src/main/java/replacewith/MethodImplicitThis.java
M lint-checks/integration-tests/src/main/java/replacewith/ReplaceWithUsageJava.java
M lint-checks/integration-tests/src/main/java/replacewith/ReplaceWithUsageKotlin.kt
M lint-checks/integration-tests/src/main/java/replacewith/StaticFieldImplicitClass.java
M lint-checks/integration-tests/src/main/java/replacewith/StaticMethodExplicitClass.java
M lint-checks/src/main/java/androidx/build/lint/AndroidXIssueRegistry.kt
M lint-checks/src/main/java/androidx/build/lint/ReplaceWithDetector.kt
M lint-checks/src/test/java/androidx/build/lint/replacewith/ReplaceWithDetectorConstructorTest.kt
M lint-checks/src/test/java/androidx/build/lint/replacewith/ReplaceWithDetectorFieldTest.kt
M lint-checks/src/test/java/androidx/build/lint/replacewith/ReplaceWithDetectorMethodTest.kt
M lint-checks/src/test/java/androidx/build/lint/replacewith/TestUtils.kt
M settings.gradle
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 4f1327f2263009c5259a80eae32899e374143b40
Author: Alan Viverette <alanv@google.com>
Date: Thu Jan 25 15:41:34 2024
Move @ReplaceWith annotation to Annotations library
- Removes annotation-replacewith project
- Converts annotation to Kotlin (the irony...)
A follow-up CL will move annotation-replacewith-lint to lint-checks.
Relnote: Add annotation to express replacements for deprecated APIs
Test: ./gradlew checkApi
Bug: 322373864
Change-Id: I38db39789f657e70e962cae2e3360023db50ecb5
M annotation/annotation-experimental-lint/build.gradle
M annotation/annotation-replacewith-lint/build.gradle
M annotation/annotation-replacewith-lint/integration-tests/build.gradle
D annotation/annotation-replacewith/api/current.txt
D annotation/annotation-replacewith/api/res-current.txt
D annotation/annotation-replacewith/api/restricted_current.txt
D annotation/annotation-replacewith/build.gradle
M annotation/annotation/api/current.txt
M annotation/annotation/api/restricted_current.txt
M annotation/annotation/src/commonMain/kotlin/androidx/annotation/RestrictTo.kt
M annotation/annotation/src/jvmMain/kotlin/androidx/annotation/ReplaceWith.jvm.kt
M docs-tip-of-tree/build.gradle
M libraryversions.toml
M lint-checks/integration-tests/build.gradle
A lint-checks/integration-tests/src/main/java/replacewith/ConstructorNonStaticClass.java
A lint-checks/integration-tests/src/main/java/replacewith/ConstructorStaticClass.java
A lint-checks/integration-tests/src/main/java/replacewith/ConstructorToStaticMethod.java
A lint-checks/integration-tests/src/main/java/replacewith/MethodExplicitThis.java
A lint-checks/integration-tests/src/main/java/replacewith/MethodImplicitThis.java
A lint-checks/integration-tests/src/main/java/replacewith/ReplaceWithUsageJava.java
A lint-checks/integration-tests/src/main/java/replacewith/ReplaceWithUsageKotlin.kt
A lint-checks/integration-tests/src/main/java/replacewith/StaticFieldExplicitClass.java
A lint-checks/integration-tests/src/main/java/replacewith/StaticFieldImplicitClass.java
A lint-checks/integration-tests/src/main/java/replacewith/StaticMethodExplicitClass.java
M settings.gradle
https://android-review.googlesource.com/2929330
Branch: androidx-main
commit 4f1327f2263009c5259a80eae32899e374143b40
Author: Alan Viverette <alanv@google.com>
Date: Thu Jan 25 15:41:34 2024
Move @ReplaceWith annotation to Annotations library
- Removes annotation-replacewith project
- Converts annotation to Kotlin (the irony...)
A follow-up CL will move annotation-replacewith-lint to lint-checks.
Relnote: Add annotation to express replacements for deprecated APIs
Test: ./gradlew checkApi
Bug: 322373864
Change-Id: I38db39789f657e70e962cae2e3360023db50ecb5
M annotation/annotation-experimental-lint/build.gradle
M annotation/annotation-replacewith-lint/build.gradle
M annotation/annotation-replacewith-lint/integration-tests/build.gradle
D annotation/annotation-replacewith/api/current.txt
D annotation/annotation-replacewith/api/res-current.txt
D annotation/annotation-replacewith/api/restricted_current.txt
D annotation/annotation-replacewith/build.gradle
M annotation/annotation/api/current.txt
M annotation/annotation/api/restricted_current.txt
M annotation/annotation/src/commonMain/kotlin/androidx/annotation/RestrictTo.kt
M annotation/annotation/src/jvmMain/kotlin/androidx/annotation/ReplaceWith.jvm.kt
M docs-tip-of-tree/build.gradle
M libraryversions.toml
M lint-checks/integration-tests/build.gradle
A lint-checks/integration-tests/src/main/java/replacewith/ConstructorNonStaticClass.java
A lint-checks/integration-tests/src/main/java/replacewith/ConstructorStaticClass.java
A lint-checks/integration-tests/src/main/java/replacewith/ConstructorToStaticMethod.java
A lint-checks/integration-tests/src/main/java/replacewith/MethodExplicitThis.java
A lint-checks/integration-tests/src/main/java/replacewith/MethodImplicitThis.java
A lint-checks/integration-tests/src/main/java/replacewith/ReplaceWithUsageJava.java
A lint-checks/integration-tests/src/main/java/replacewith/ReplaceWithUsageKotlin.kt
A lint-checks/integration-tests/src/main/java/replacewith/StaticFieldExplicitClass.java
A lint-checks/integration-tests/src/main/java/replacewith/StaticFieldImplicitClass.java
A lint-checks/integration-tests/src/main/java/replacewith/StaticMethodExplicitClass.java
M settings.gradle
Description
We don't have a check in Studio lint for this yet, so we might not want to expose it as a public API, but we should move the annotation to the base Annotations library.