lifecycle-common baseline profile is not used/included [322382422]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jan 25, 2024 09:25PM

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:lifecycle/lifecycle-common/src/main/baseline-prof.txt was added in

r.android.com/1847148 but because this is a non-android project, it is actually never picked up or used.

Please move these entries to an android library that uses this library (maybe lifecycle-runtime).

Comments

il...@google.com <il...@google.com> #2Jan 31, 2024 11:08PM

Assigned to mg...@google.com.

With the change of lifecycle-common to KMP, we might be able to just move this into the right spot (since it'll mirror the same structure as lifecycle-runtime, which does work).

au...@google.com <au...@google.com> #3Jan 31, 2024 11:11PM

lifecycle-common even after conversion to KMP is still a jar. We do not want to change that to an AAR as that is a breaking change for consumers, so i dont think we can make it work this project.

il...@google.com <il...@google.com> #4Jan 31, 2024 11:18PM

Ah yeah good point.

mg...@google.com <mg...@google.com> Apr 11, 2024 02:31PM

Accepted by mg...@google.com.

ap...@google.com <ap...@google.com> #5Apr 15, 2024 09:27AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a00e293b59bdbe5746941171fe793b863aaafabe
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Apr 11 15:42:42 2024

Move baseline-prof.txt from Lifecycle common to runtime

* Move `baseline-prof.txt` from `lifecycle-common` to `lifecycle-runtime`;
* Because there are multiple files now in `lifecycle-runtime`, group them inside a `baselineProfiles` folder.
* Rename the files to match what modules they target.

Test: N/A
Fixes: 322382422
Change-Id: Iaced653d78e6fe6c107e389ed76cd3ca37e46347

D lifecycle/lifecycle-common/src/jvmMain/baseline-prof.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidMain/baseline-prof.txt

https://android-review.googlesource.com/3038274

Issue 322382422