Status Update
Comments
ma...@google.com <ma...@google.com> #2
Connie, could this be related to your recent color performance work?
co...@google.com <co...@google.com> #3
An ElevatedFilterChip
that is disabled and selected will use disabledSelectedContainerColor
, which has the correct implementation.
An ElevatedFitlerChip
that is disabled and NOT selected (as shown in the code snippet in disabledContainerColor
Which contains a bug that was introduced in
Before: disabledContainerColor: Color = FilterChipTokens.ElevatedDisabledContainerColor.value .copy(alpha = FilterChipTokens.ElevatedDisabledContainerOpacity)
After disabledContainerColor = fromToken(FilterChipTokens.ElevatedDisabledContainerColor),
co...@google.com <co...@google.com> #4
Reporter, can you please confirm that you ElevatedFilterChip
is turning black when enabled
and selected
are both false?
co...@google.com <co...@google.com>
ap...@google.com <ap...@google.com> #5
Branch: androidx-main
commit 861482972954cdbca67bc26426d7251d0c3645b8
Author: Connie Shi <connieshi@google.com>
Date: Mon Feb 26 20:08:02 2024
Fix bug introduced in aosp/2867454 that caused a regression in ElevatedFilterChip's unselected, disabled container color, and
the trailing icon color for both FilterChip and ElevatedFilterChip.
Bug:
Test: Added unit test.
Relnote: "Fixed bug that caused ElevatedFilterChip's unselected, disabled container color to be black."
Change-Id: I400e69a7f00c00c3c77e3fdef1e947156483731b
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ChipTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Chip.kt
co...@google.com <co...@google.com>
na...@google.com <na...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.2.1
androidx.compose.material3:material3-android:1.2.1
androidx.compose.material3:material3-desktop:1.2.1
androidx.compose.material3:material3:1.3.0-alpha02
androidx.compose.material3:material3-android:1.3.0-alpha02
androidx.compose.material3:material3-desktop:1.3.0-alpha02
Description
Jetpack Compose component used: ElevatedFilterChip
Android Studio Build: Android Studio Hedgehog | 2023.1.1 RC 3
Kotlin version: 1.9.21
Steps to Reproduce or Code Sample to Reproduce:
Declared an ElevatedFilterChip setting it as disabled and selected
ElevatedFilterChip(
onClick = {},
selected = false,
enabled = false,
label = { Text("Chip 3") },
)
Seems like it is using the onSurface color as the disabledContainerColor which is turning it totally black.
Stack trace (if applicable):