ElevatedFilterChip turns black when it is NOT selected and NOT enabled [322407043]

Fixed

Bug

Status Update

No update yet.

Description

ne...@dockyard.com

created issue #1

Jan 26, 2024 03:12PM

Jetpack Compose version: Compose BOM 2023.10.01 | Material 3 version 1.2.0-beta02
Jetpack Compose component used: ElevatedFilterChip
Android Studio Build: Android Studio Hedgehog | 2023.1.1 RC 3
Kotlin version: 1.9.21

Steps to Reproduce or Code Sample to Reproduce:
Declared an ElevatedFilterChip setting it as disabled and selected

ElevatedFilterChip(
onClick = {},
selected = false,
enabled = false,
label = { Text("Chip 3") },
)

Seems like it is using the onSurface color as the disabledContainerColor which is turning it totally black.

Stack trace (if applicable):

Comments

ma...@google.com <ma...@google.com> #2Jan 26, 2024 06:11PM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

co...@google.com <co...@google.com> #3Feb 26, 2024 11:27PM

Reassigned to co...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

Message last modified on Feb 26, 2024 11:51PM

co...@google.com <co...@google.com> #4Feb 26, 2024 11:52PM

Reporter, can you please confirm that you ElevatedFilterChip is turning black when enabled and selected are both false?

co...@google.com <co...@google.com> Feb 27, 2024 04:20PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #5Feb 27, 2024 11:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit 861482972954cdbca67bc26426d7251d0c3645b8
Author: Connie Shi <connieshi@google.com>
Date: Mon Feb 26 20:08:02 2024

Fix bug introduced in aosp/2867454 that caused a regression in ElevatedFilterChip's unselected, disabled container color, and
the trailing icon color for both FilterChip and ElevatedFilterChip.

Bug:

b/322407043

Test: Added unit test.
Relnote: "Fixed bug that caused ElevatedFilterChip's unselected, disabled container color to be black."
Change-Id: I400e69a7f00c00c3c77e3fdef1e947156483731b

M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ChipTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Chip.kt

https://android-review.googlesource.com/2978592

co...@google.com <co...@google.com> Mar 4, 2024 04:26PM

Marked as fixed.

na...@google.com <na...@google.com> #6Mar 6, 2024 07:49PM