Disabling system keyboard for TextFields no longer works [322680547]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Jan 29, 2024 07:35AM

Jetpack Compose version: 1.7.0-alpha01

Jetpack Compose component(s) used: foundation.text2

Android Studio Build: Android Studio Hedgehog | 2023.1.1 Patch 2 Build #AI-231.9392.1.2311.11330709, built on January 19, 2024

Kotlin version: 1.9.22

Steps to Reproduce or Code Sample to Reproduce:

I develop a calculator and don't use system keyboard. Before 1.7.0 and BasicTextField2 I could disable system keyboard with this approach. (see below)

@Composable
fun TextFieldWithoutKeyboard() {
    CompositionLocalProvider(
        LocalTextInputService provides null,
    ) {
        BasicTextField(
            ...
        )
    }
}

But in 1.7.0 and BasicTextField2 this doesn't work as LocalTextInputService is now deprecated and not used in BasicTextField2. What migration steps are required to achieve same result in 1.7.0?

Comments

sa...@gmail.com <sa...@gmail.com> #2Jan 29, 2024 08:28PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

Message last modified on Jan 30, 2024 01:46PM

le...@google.com <le...@google.com> Jan 30, 2024 09:16AM

Reassigned to an...@google.com.

kl...@google.com <kl...@google.com> #3Jan 31, 2024 09:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

sa...@gmail.com <sa...@gmail.com> #4Jan 31, 2024 09:17PM

deleted

kl...@google.com <kl...@google.com> #5Feb 2, 2024 09:10PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

sa...@gmail.com <sa...@gmail.com> #6Feb 2, 2024 10:19PM

Yes, this would be great.

kl...@google.com <kl...@google.com> #7Feb 6, 2024 12:13AM

ha...@google.com <ha...@google.com> Feb 6, 2024 01:28PM

Reassigned to kl...@google.com.

kl...@google.com <kl...@google.com> #8Feb 16, 2024 03:06AM

Prototype of the interceptor approach: https://r.android.com/2966982

ap...@google.com <ap...@google.com> #9Mar 4, 2024 05:15PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 5ef99a1da4efd83f38bf1538cd5fa2c5809d7869
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Feb 15 18:58:10 2024

Introduce PlatformTextInput interceptor composable function.

Design doc: go/pti-interceptor

Keeps the old test-only code around but deprecates it.

Fixes:

b/322680547

Fixes:

b/325141632

Test: InterceptPlatformTextInputTest
Relnote: "Introduced `InterceptPlatformTextInput`
for helping write low-level IME-related tests and other
low-level IME use cases. `PlatformTextInputTestOverride` has been
deprecated."
Change-Id: I862ed2e997d6a98e33a25da2ff536a2779ae173d

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/InputMethodInterceptor.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/TextFieldFocusTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/OutlinedTextFieldTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TextFieldTest.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/PlatformTextInputMethodOverride.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/PlatformTextInputModifierNodeSample.kt
A compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/InterceptPlatformTextInputTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/PlatformTextInputMethodTestOverrideTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/PlatformTextInputModifierNode.kt

https://android-review.googlesource.com/2978991

pr...@google.com <pr...@google.com> #10Mar 20, 2024 08:26PM