java.lang.IllegalStateException: No value to animate to at 108 millis [322839811]

Fixed

Bug

Status Update

No update yet.

Description

va...@gmail.com

created issue #1

Jan 30, 2024 08:01AM

Jetpack Compose version: 1.7.0-alpha01

Jetpack Compose component(s) used: all

Android Studio Build: N/A

Kotlin version: 1.9.22

Steps to Reproduce or Code Sample to Reproduce:

Reproducibility: 100%


object RRitualProgressCardDefaults {

    val MinSize = 52.dp
    val MaxSize = 440.dp
    const val AnimationDurationMs = 600
    const val AnimationDelayMs = 100
    val AnimationEasing = CubicBezierEasing(0.2f, 0f, 0f, 1f)
}

@Composable
fun OngoingRitualPill(
    habit: OngoingRitualHabit?,
    onClick: (ritualId: Uuid) -> Unit,
    modifier: Modifier = Modifier,
) {
    val state = remember { MutableTransitionState(false) }
    LaunchedEffect(habit) {
        state.targetState = habit != null
    }
    val updateTransition = rememberTransition(transitionState = state, label = "ongoing habit pill")
    val width by updateTransition.animateDp(
        transitionSpec = {
            tween(
                durationMillis = AnimationDurationMs,
                delayMillis = AnimationDelayMs,
                easing = AnimationEasing,
            )
        },
        label = "pill size",
        targetValueByState = { visible -> if (visible) MaxSize else MinSize }
    )
    val alpha by updateTransition.animateFloat(
        transitionSpec = {
            keyframes {
                durationMillis = AnimationDurationMs / 2
                delayMillis = AnimationDelayMs
                0f at AnimationDelayMs
                1f at AnimationDurationMs using EaseInOutCubic
            }
        },
        label = "text alpha",
        targetValueByState = { it.toInt().toFloat() }
    )

    AnimatedVisibility(
        visibleState = state,
        enter = slideInVertically { it } + fadeIn(),
        exit = slideOutVertically { it } + fadeOut(),
        modifier = modifier,
    ) {
        if (habit == null) return@AnimatedVisibility
        with(habit) {
            RRitualProgressCard( // no animations inside the composable. Uses AnimatedVisibility internally
                title = title,
                onClick = { onClick(id) },
                textAlpha = alpha,
                modifier = Modifier.sizeIn(maxWidth = width, minHeight = MinSize),
            )
        }
    }
}

Stack trace (if applicable):

Fatal Exception: java.lang.IllegalStateException: No value to animate to at 108 millis
       at androidx.compose.animation.core.VectorizedKeyframesSpec.getValueFromNanos(VectorizedAnimationSpec.kt:434)
       at androidx.compose.animation.core.TargetBasedAnimation.getValueFromNanos(Animation.kt:262)
       at androidx.compose.animation.core.Transition$TransitionAnimationState.onPlayTimeChanged$animation_core_release(Transition.java:1007)
       at androidx.compose.animation.core.Transition.onFrame$animation_core_release(Transition.kt:681)
       at androidx.compose.animation.core.Transition$animateTo$1$1$1.invoke(Transition.kt:842)
       at androidx.compose.animation.core.Transition$animateTo$1$1$1.invoke(Transition.kt:837)
       at androidx.compose.runtime.BroadcastFrameClock$FrameAwaiter.resume(BroadcastFrameClock.java:42)
       at androidx.compose.runtime.BroadcastFrameClock.sendFrame(BroadcastFrameClock.kt:71)
       at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke(Recomposer.kt:579)
       at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke(Recomposer.kt:572)
       at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:41)
       at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.java:109)
       at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.java:41)
       at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1550)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1561)
       at android.view.Choreographer.doCallbacks(Choreographer.java:1117)
       at android.view.Choreographer.doFrame(Choreographer.java:992)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1535)
       at android.os.Handler.handleCallback(Handler.java:958)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:257)
       at android.os.Looper.loop(Looper.java:368)
       at android.app.ActivityThread.main(ActivityThread.java:8832)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:572)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1049)

Comments

va...@gmail.com <va...@gmail.com> #2Jan 30, 2024 08:08AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

mo...@google.com <mo...@google.com> Jan 30, 2024 02:15PM

Assigned to os...@google.com.

os...@google.com <os...@google.com> #3Jan 30, 2024 10:01PM

Thanks for the reproducible example. We've identified a fix.

The "issue" comes from defining a timestamp outside the range of the animation.

In this case:

            keyframes {
                durationMillis = AnimationDurationMs / 2
                delayMillis = AnimationDelayMs
                0f at AnimationDelayMs
                1f at AnimationDurationMs using EaseInOutCubic
            }

1f at AnimationDurationMs using EaseInOutCubic is defined outside the duration of the animation (AnimationDurationMs / 2), so it has no effect on the animation (well, other than this crash).

Keep in mind delayMillis has no effect in how you define each timestamp.

The timeStamp value passed to T.at(timeStamp: Int) should always be within 0 and durationMillis, regardless of amount of delay.

Bringing this up since I'm assuming is not what you intended.

ap...@google.com <ap...@google.com> #4Jan 30, 2024 11:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 74588de03bdfcaa395189f628262d7f94f2cee65
Author: Oscar Adame Vázquez <oscarad@google.com>
Date: Tue Jan 30 13:44:44 2024

Fix IllegalStateException on keyframes

This relaxes boundary condition checks in VectorizedKeyframesSpec to
avoid possibly incorrect assumptions.

Possible Illegal states are already handled by public API that makes use
of it.

Bug: 322839811
Test: KeyframeAnimationTest
Change-Id: I341b862ed2c5acb92ec596e5d4cb0445c5663ad6

M compose/animation/animation-core/src/androidUnitTest/kotlin/androidx/compose/animation/core/KeyframeAnimationTest.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/VectorizedAnimationSpec.kt

https://android-review.googlesource.com/2937682

va...@gmail.com <va...@gmail.com> #5Jan 31, 2024 05:47AM

Yes, it wasn't what was intended initially, however the code crashed even when I have removed the durationMillis = and delayMillis = calls. That was the reason I decided to report the issue.

os...@google.com <os...@google.com> #6Jan 31, 2024 06:19PM

Yes it definitely shouldn't crash, thanks for the report!

A fix has been merged, I'll close this issue once I can confirm it's availability.

cl...@google.com <cl...@google.com> Jun 27, 2024 04:35PM

Marked as fixed.