Status Update
Comments
va...@gmail.com <va...@gmail.com> #2
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
mo...@google.com <mo...@google.com>
os...@google.com <os...@google.com> #3
Thanks for the reproducible example. We've identified a fix.
The "issue" comes from defining a timestamp outside the range of the animation.
In this case:
keyframes {
durationMillis = AnimationDurationMs / 2
delayMillis = AnimationDelayMs
0f at AnimationDelayMs
1f at AnimationDurationMs using EaseInOutCubic
}
1f at AnimationDurationMs using EaseInOutCubic
is defined outside the duration of the animation (AnimationDurationMs / 2
), so it has no effect on the animation (well, other than this crash).
Keep in mind delayMillis
has no effect in how you define each timestamp.
The timeStamp
value passed to T.at(timeStamp: Int)
should always be within 0
and durationMillis
, regardless of amount of delay.
Bringing this up since I'm assuming is not what you intended.
ap...@google.com <ap...@google.com> #4
Branch: androidx-main
commit 74588de03bdfcaa395189f628262d7f94f2cee65
Author: Oscar Adame Vázquez <oscarad@google.com>
Date: Tue Jan 30 13:44:44 2024
Fix IllegalStateException on keyframes
This relaxes boundary condition checks in VectorizedKeyframesSpec to
avoid possibly incorrect assumptions.
Possible Illegal states are already handled by public API that makes use
of it.
Bug: 322839811
Test: KeyframeAnimationTest
Change-Id: I341b862ed2c5acb92ec596e5d4cb0445c5663ad6
M compose/animation/animation-core/src/androidUnitTest/kotlin/androidx/compose/animation/core/KeyframeAnimationTest.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/VectorizedAnimationSpec.kt
va...@gmail.com <va...@gmail.com> #5
Yes, it wasn't what was intended initially, however the code crashed even when I have removed the durationMillis =
and delayMillis =
calls. That was the reason I decided to report the issue.
os...@google.com <os...@google.com> #6
A fix has been merged, I'll close this issue once I can confirm it's availability.
Description
Jetpack Compose version: 1.7.0-alpha01
Jetpack Compose component(s) used: all
Android Studio Build: N/A
Kotlin version: 1.9.22
Steps to Reproduce or Code Sample to Reproduce:
Reproducibility: 100%
Stack trace (if applicable):