Fixed
Status Update
No update yet.
Comments
se...@google.com
sg...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 94c9c1be861c2cc6640411680244cde9c4e2372e
Author: Shalom Gibly <sgibly@google.com>
Date: Wed Mar 13 17:10:06 2024
Adds size customization to top app bars
- Added parameters to allow changing the fixed and expanded heights for
all types of top app bars.
- Deprecated (with Hidden) the previous experimental functions and
created new ones that take those params.
- Removed an older deprecated SmallTopAppBar functions
- Fix a performance issue where the single-line top app bars were
recomposing too much when scrolling content.
- Applied a heightIn with a max value to the app bar to better support
showing of DropDown menus from the app bar.
- Fix an accessibility issue with the Medium app bar that was cutting
some of the displayed title when using large font and display.
Fixes: 316594552
Fixes: 323403446
Fixes: 300953236
Fixes: 286296147
Fixes: 330410290
Bug: 308540676
Test: Added tests to AppBarTest.kt
Relnote: "Top app bar APIs now support custom heights for both fixed
and collapsible sections.
Fixed an issue that caused single-line top app bars to recompose too
many times when scrolling content.
Resolved an issue where MediumTopAppBar truncated titles on devices
with large font/display settings."
Change-Id: Ib8b0ce45ed461e7d5110e1473a90ab48c268caa6
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
https://android-review.googlesource.com/3000717
Branch: androidx-main
commit 94c9c1be861c2cc6640411680244cde9c4e2372e
Author: Shalom Gibly <sgibly@google.com>
Date: Wed Mar 13 17:10:06 2024
Adds size customization to top app bars
- Added parameters to allow changing the fixed and expanded heights for
all types of top app bars.
- Deprecated (with Hidden) the previous experimental functions and
created new ones that take those params.
- Removed an older deprecated SmallTopAppBar functions
- Fix a performance issue where the single-line top app bars were
recomposing too much when scrolling content.
- Applied a heightIn with a max value to the app bar to better support
showing of DropDown menus from the app bar.
- Fix an accessibility issue with the Medium app bar that was cutting
some of the displayed title when using large font and display.
Fixes: 316594552
Fixes: 323403446
Fixes: 300953236
Fixes: 286296147
Fixes: 330410290
Bug: 308540676
Test: Added tests to AppBarTest.kt
Relnote: "Top app bar APIs now support custom heights for both fixed
and collapsible sections.
Fixed an issue that caused single-line top app bars to recompose too
many times when scrolling content.
Resolved an issue where MediumTopAppBar truncated titles on devices
with large font/display settings."
Change-Id: Ib8b0ce45ed461e7d5110e1473a90ab48c268caa6
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
sa...@gmail.com
But i am not able to add height on topappbar (modifier.height(56.dp)) when i am adding the height i can able to see the topappbar its got disappeared
sg...@google.com
As there is a bit more involved code that deals with the height of the app-bar and the scroll-behavior, each app-bar has dedicated params to control the heights and it's not done through a Modifier.
See for example the
collapsedHeight: Dp = TopAppBarDefaults.LargeAppBarCollapsedHeight,
expandedHeight: Dp = TopAppBarDefaults.LargeAppBarExpandedHeight,
bo...@gmail.com
Sorry for some ignorance here: The Status of this issue is "Fixed", but there's no indication of what release it is in, or is targeting. In fact, "Public Project Status" is "Not started". What does this all mean? Is this code released?
sg...@google.com
I believe this will be released with 1.4.0-alpha01, which should be available shortly.
Description
Jetpack Compose component used: TopAppBar
The Material3 spec says the TopAppBar height must always be 64dp and this is enforced in the library, but sometimes it's just too big, and one good example of this is in landscape mode where vertical space is at at a premium.
Factoring in the system bars, 64dp is around 20% of the available vertical space in landscape mode on typical phones. There's even less space if an app uses a bottom navigation bar. The Play Store app is a good example that even first party apps are affected by this. In landscape mode, there is only space for a single row of app icons when browsing apps on the Play Store.
There is currently no standard pattern to add anything more to the TopAppBar in Landscape mode than a navigation icon, title and action icon buttons which are there in portrait. This means that the extra horizontal space in landscape mode ends up unused.
It would be great if we could have some more control over the TopAppBar height, to make it smaller than 64.dp. Due to the minimum touch target size of 48dp, I've used a 48dp height TopAppBar in my app which I'm quite happy with.
In portrait mode too, having a 56dp height TopAppBar allows for a slightly more compact layout on devices with smaller screens.
Thanks!