[Bug] PullRefreshIndicator for Material 3 [323787138]

Fixed

Bug

Status Update

No update yet.

Description

br...@pappin.ca

created issue #1

Feb 5, 2024 02:47PM

Observed Behaviour

The PullToRefreshContainer leaves an outline of the indeterminate indicator on the screen, even when the state is not refreshing.

Expected Behaviour

The expected behaviour is that PullToRefreshContainer would hide all traces, including that outer box with a background colour, based on the PullToRefreshState state.

Steps to Reproduce

This is the outer Box in PullToRefreshContainer, which has the background colour set to containerColor: Color = PullToRefreshDefaults.containerColor, and does not get hidden when isRefreshing is false. See: PullToRefresh.kt:135

To reproduce, and check this accuracy, simple set the containerColor on the PullToRefreshContainer, like this:

PullToRefreshContainer(
    modifier = Modifier.align(Alignment.Center),
    state = state,
    containerColor = Color.Red
)

Other Notes

This is somewhat related to: https://issuetracker.google.com/issues/261760718

Screenshot_20240205_092833.png

74 KB

View

Download

Comments

se...@google.com <se...@google.com> Feb 5, 2024 03:15PM

Reassigned to ma...@google.com.

br...@pappin.ca <br...@pappin.ca> #2Feb 5, 2024 03:23PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

Message last modified on Feb 5, 2024 03:26PM

br...@pappin.ca <br...@pappin.ca> #3Feb 5, 2024 09:36PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

Message last modified on Feb 6, 2024 03:06PM

ma...@google.com <ma...@google.com> Apr 4, 2024 10:38PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> Apr 11, 2024 06:34PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #4Apr 18, 2024 06:28PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a1154475dd101bcf9867c11ceb567f9511dc7c1c
Author: Mariano Martin <marianomartin@google.com>
Date: Fri Apr 05 12:00:06 2024

[PullToRefresh] Update Material 3 PullToRefresh APIs

Test: updated existing tests

Fixes: 314496282, 317177684, 323787138, 324573502, 317177683

Relnote: "New pull-to-refresh APIs:

- Simplified PullToRefreshState to use fractional values instead of Dp units.
- isRefreshing state is controlled by the user instead of PullToRefreshState.
- Separated out the nested scroll connection from PullToRefreshState. It is handled by the new PullToRefreshBox or Modifier.pullToRefresh.

- This update is a breaking change to previous experimental APIs."

Change-Id: I0adeb950063988d1a05aca7aa135ccd982431423

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
M compose/material3/material3/integration-tests/material3-demos/src/main/java/androidx/compose/material3/demos/PullToRefreshDemo.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/PullToRefreshSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/pulltorefresh/PullToRefreshIndicatorScreenshotTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/pulltorefresh/PullToRefreshIndicatorTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/pulltorefresh/PullToRefreshStateImplTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/pulltorefresh/PullToRefresh.kt

https://android-review.googlesource.com/3029663