[Bug] PullRefreshIndicator for Material 3 [323787138]

Fixed

Bug

Status Update

No update yet.

Description

br...@pappin.ca

created issue #1

Feb 5, 2024 02:47PM

Observed Behaviour

The PullToRefreshContainer leaves an outline of the indeterminate indicator on the screen, even when the state is not refreshing.

Expected Behaviour

The expected behaviour is that PullToRefreshContainer would hide all traces, including that outer box with a background colour, based on the PullToRefreshState state.

Steps to Reproduce

This is the outer Box in PullToRefreshContainer, which has the background colour set to containerColor: Color = PullToRefreshDefaults.containerColor, and does not get hidden when isRefreshing is false. See: PullToRefresh.kt:135

To reproduce, and check this accuracy, simple set the containerColor on the PullToRefreshContainer, like this:

PullToRefreshContainer(
    modifier = Modifier.align(Alignment.Center),
    state = state,
    containerColor = Color.Red
)

Other Notes

This is somewhat related to: https://issuetracker.google.com/issues/261760718

Screenshot_20240205_092833.png

74 KB

View

Download

Comments

se...@google.com <se...@google.com> Feb 5, 2024 03:15PM

Reassigned to ma...@google.com.

br...@pappin.ca <br...@pappin.ca> #2Feb 5, 2024 03:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

Message last modified on Feb 5, 2024 03:26PM

br...@pappin.ca <br...@pappin.ca> #3Feb 5, 2024 09:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 now with workaround for

https://youtrack.jetbrains.com/issue/KT-62653

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3156121

Message last modified on Feb 6, 2024 03:06PM

ma...@google.com <ma...@google.com> Apr 4, 2024 10:38PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> Apr 11, 2024 06:34PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #4Apr 18, 2024 06:28PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit c3a06e79cf427aef1cf0ede1bacb463eb89472be
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 /

r.android.com/3156121 but now with
moving to project(":annotation:annotation") in commonMain as due to

https://youtrack.jetbrains.com/issue/KT-62653 we cannot depend on
project in one source set and prebuilt in the other.

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: I7f2a1bddbe79ab5e920cdb01ca6a428950a8c2c3

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M busytown/androidx_multiplatform_mac_host_tests_arm64.sh
M camera/integration-tests/avsynctestapp/build.gradle
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt
M test/uiautomator/integration-tests/testapp/build.gradle
M wear/compose/integration-tests/navigation/build.gradle

https://android-review.googlesource.com/3156423