If a custom tab is opened from a singleInstance activity, it is launched in a different window [323904203]

Bug

Status Update

No update yet.

Description

mo...@plaid.com

created issue #1

Feb 6, 2024 05:19PM

When a custom tab is opened from a singleInstance Activity, it opens in a new window. In every other case of launchMode option it seems to open in the same window. Also if the partial custom tab feature is used (even from a singleInstance Activity) it will open in the same window. I think all of the cases should open in the same window and this new window is a bug. At least, I can't find any documentation about it. Is there any way for a Custom Tab opened from a singleInstance Activity to be in the same window rather than a new window?

Thanks,
Melissa

Component used: androidx.browser:browser
Version used: 1.7.0
Devices/Android versions reproduced on:Pixel 7, Android 14

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue -

https://github.com/melissaosullivan/CustomTabNewWindowBug
- A screenrecord or screenshots showing the issue (if UI related) -

https://drive.google.com/file/d/1j5Pz8jHOZSyuqX2JMpiGOpMdf3zUtVb2/view?usp=sharing

screen-20240206-121202.mp4 -

https://drive.google.com/open?id=1j5Pz8jHOZSyuqX2JMpiGOpMdf3zUtVb2&authuser=0

Comments

tw...@google.com <tw...@google.com> #2Feb 14, 2024 05:53PM

Reassigned to kg...@google.com.

Issue with notification access code in core. Unclear where, but probably safe to assume NotificationCompat.

kg...@google.com <kg...@google.com> #3Feb 14, 2024 05:58PM

Note that this is a lint error and can be suppressed or lowered to warning-level on the client side. Lowering back to P2.

kg...@google.com <kg...@google.com> #4Feb 14, 2024 06:49PM

To find cause of issue, update
androidx/platform/frameworks/support/+/androidx-main:buildSrc/public/src/main/kotlin/androidx/build/SupportConfig.kt;l=50 to 33 and then run ./gradlew :core:core:lintDebug

mo...@plaid.com <mo...@plaid.com> #5Feb 15, 2024 06:25PM

It's at

frameworks/support/core/core/src/main/java/androidx/core/app/NotificationManagerCompat.java:223: Error: When targeting Android 13 or higher, posting a permission requires holding the POST_NOTIFICATIONS permission [NotificationPermission]
            mNotificationManager.notify(tag, id, notification);
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "NotificationPermission":
   When targeting Android 13 and higher, posting permissions requires holding
   the runtime permission android.permission.POST_NOTIFICATIONS.

kg...@google.com <kg...@google.com> #6Feb 15, 2024 07:59PM

Handling this as part of b/238790278.

is...@google.com <is...@google.com> Apr 12, 2024 07:22AM

Status: New

Issue 323904203