If a custom tab is opened from a singleInstance activity, it is launched in a different window [323904203]

Bug

Status Update

No update yet.

Description

mo...@plaid.com

created issue #1

Feb 6, 2024 05:19PM

When a custom tab is opened from a singleInstance Activity, it opens in a new window. In every other case of launchMode option it seems to open in the same window. Also if the partial custom tab feature is used (even from a singleInstance Activity) it will open in the same window. I think all of the cases should open in the same window and this new window is a bug. At least, I can't find any documentation about it. Is there any way for a Custom Tab opened from a singleInstance Activity to be in the same window rather than a new window?

Thanks,
Melissa

Component used: androidx.browser:browser
Version used: 1.7.0
Devices/Android versions reproduced on:Pixel 7, Android 14

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue -

https://github.com/melissaosullivan/CustomTabNewWindowBug
- A screenrecord or screenshots showing the issue (if UI related) -

https://drive.google.com/file/d/1j5Pz8jHOZSyuqX2JMpiGOpMdf3zUtVb2/view?usp=sharing

screen-20240206-121202.mp4 -

https://drive.google.com/open?id=1j5Pz8jHOZSyuqX2JMpiGOpMdf3zUtVb2&authuser=0

Comments

tw...@google.com <tw...@google.com> #2Feb 14, 2024 05:53PM

Reassigned to kg...@google.com.

having the same issue
Room version > 2.7.0-alpha08
agp = "8.2.2"
kotlin = "2.0.20"
ksp-plugin = "2.0.20-1.0.24"

also Reverting to Room version 2.7.0-alpha07 solves the issue.

kg...@google.com <kg...@google.com> #3Feb 14, 2024 05:58PM

Thanks for the report, this issue is likely due to the Room Gradle Plugin changes that try to also configure the android test app asset directory to include the schemas so the MigrationTestHelper can pick them up. I'll try to work on a fix soon.

kg...@google.com <kg...@google.com> #4Feb 14, 2024 06:49PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3391005

Configure the schema asset android copy task within its register block and not within AGP's wiredWith lambda.

Expand for full commit details

Configure the schema asset android copy task within its register block and not within AGP's wiredWith lambda. 
 
Otherwise the tasks inputs are locked by the time the wiredWith lambda passed to addGeneratedSourceDirector() is invoked and will lead to "property 'inputDirectory' is final and cannot be changed any further". 
 
Bug: 376071291 
Test: Manual with sample repro app 
Change-Id: I2c9da4855cd31d7df3276424546aba4c53edf7ea

Files:

M room/room-gradle-plugin/src/main/java/androidx/room/gradle/integration/AndroidPluginIntegration.kt

Hash: 1dbb4c1876e1e8a8e930bec4625741ac6dc05a0b
Date: Thu Dec 05 14:21:51 2024

mo...@plaid.com <mo...@plaid.com> #5Feb 15, 2024 06:25PM

I'm having the same problem in my Compose Multiplatform project and I'm using the latest version available 2.7.0-alpha12. The way I found to get around this was by adding the following task to my build.gradle

tasks.matching { it.name.startsWith("copyRoomSchemasToAndroidTestAssetsDebugAndroidTest") }.configureEach {
enabled = false
}

But I believe this is not the right thing to do, since I'm hiding the error. Is there another way to solve it or will the library be updated to fix it?

kg...@google.com <kg...@google.com> #6Feb 15, 2024 07:59PM

Unfortunately the fix did not make it to the alpha12 release, but it will indeed be in the next release.

is...@google.com <is...@google.com> Apr 12, 2024 07:22AM

Status: New

Issue 323904203