[Feature Request] Expose enabled parameter of Modifier.anchoredDraggable parameter through SwipeToDismissBox [324170119]

Fixed

Feature Request

Status Update

No update yet.

Description

su...@gmail.com

created issue #1

Feb 7, 2024 09:13AM

Jetpack Compose version: 2024.01.00

Jetpack Compose component used: material3.SwipeToDismissBox

When a user scrolls quickly in a vertical list, the horizontal swipe gesture could be triggered by mistake frequently, which consumes the velocity in x-axis from the flinging of a verticle scrolling.

This unexpected behavior is a really annoying experience.

One possible solution is to pass the enabled to the Modifier.anchoredDraggable:

        modifier.anchoredDraggable(
                enabled = enabled && state.currentValue == SwipeToDismissBoxValue.Settled,
                ...
            ),

Then pass the LazyListState down to the SwipeToDismissBox:

val isScrollInProgress: () -> Boolean = { listState.isScrollInProgress() }

...

SwipeToDismissBox(enabled = !isScrollInProgress(), ...) { }

Comments

ma...@google.com <ma...@google.com> Feb 7, 2024 03:19PM

Reassigned to ma...@google.com.

se...@google.com <se...@google.com> #2Mar 13, 2024 05:19PM

Thanks for filing this issue!

While it doesn't seem directly related to third-party cookie dependencies or Privacy Sandbox, we may be missing something. If you are confident that this issue is related to third-party cookies, please submit a new report with more details about how the issue might be impacted by third-party cookies.

This thread will no longer be monitored for responses.

km...@google.com <km...@google.com> Mar 14, 2024 05:32PM

Reassigned to km...@google.com.

ap...@google.com <ap...@google.com> #3Mar 15, 2024 07:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit bf2a40df838a34d48b27ccf55050a9435486a512
Author: Kevin Most <kmost@google.com>
Date: Fri Mar 15 11:40:29 2024

[SwipeToDismissBox] Add `gesturesEnabled` parameter

This can be used to conditionally disable swipe-to-drag, for example
while scrolling in a `LazyList`

Change-Id: Idc59f4bc393c36d58022b459056074b1e9986b37
Test: Unit tests pass
Relnote: Added a `gesturesEnabled` parameter to `SwipeToDismissBox`
Bug: 324170119

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/SwipeToDismissTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SwipeToDismissBox.kt

https://android-review.googlesource.com/3004252

km...@google.com <km...@google.com> Mar 15, 2024 08:42PM

Marked as fixed.

co...@gmail.com <co...@gmail.com> #4Apr 3, 2025 07:46PM

We appreciate the fix, however this introduces its own tradeoffs with the scenario the original reporter detailed. When isScrollInProgress() changes, gesturesEnabled changes between true/false, which in turn causes SwipeToDismissBox to re-compose. This is causing a performance hit for us, as everytime scrolling starts/stops, all of our list items are re-composed.

Now, we're left in the situation where we have to pick between having the annoyance of accidental swipes when scrolling, or having poor performance on lower-end devices.

Is it possible to get a solution where changing gesturesEnabled doesn't re-invoke the composition phase?

Issue 324170119