Fixed
Status Update
No update yet.
Comments
di...@google.com
Thanks, this was an error on my part. The real replacement should be the size selector. I can add a set of default width based size classes to resolve this.
di...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3a044f77295084b283b3291f4cbe7a62294a8e19
Author: Diego Vela <diegovela@google.com>
Date: Thu Feb 08 00:25:52 2024
Restore WindowSizeClass#compute
Restore WindowSizeClass#compute to maintain the current guidance.
Relnote: Restore WindowSizeClass#compute
Bug: 324293374
Test: ./gradlew window:window-core:test
Change-Id: I213553e2526ff370b02f9c1a7943252faa918be3
M window/window-core/api/current.txt
M window/window-core/api/restricted_current.txt
M window/window-core/src/commonMain/kotlin/androidx/window/core/layout/WindowSizeClass.kt
M window/window-core/src/commonTest/kotlin/androidx/window/core/layout/WindowSizeClassTest.kt
https://android-review.googlesource.com/2954665
Branch: androidx-main
commit 3a044f77295084b283b3291f4cbe7a62294a8e19
Author: Diego Vela <diegovela@google.com>
Date: Thu Feb 08 00:25:52 2024
Restore WindowSizeClass#compute
Restore WindowSizeClass#compute to maintain the current guidance.
Relnote: Restore WindowSizeClass#compute
Bug: 324293374
Test: ./gradlew window:window-core:test
Change-Id: I213553e2526ff370b02f9c1a7943252faa918be3
M window/window-core/api/current.txt
M window/window-core/api/restricted_current.txt
M window/window-core/src/commonMain/kotlin/androidx/window/core/layout/WindowSizeClass.kt
M window/window-core/src/commonTest/kotlin/androidx/window/core/layout/WindowSizeClassTest.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.window:window-core:1.3.0-alpha03androidx.window:window-core-android:1.3.0-alpha03androidx.window:window-core-jvm:1.3.0-alpha03
Description
The deprecated
WindowSizeClass.Companion.computeWindowSizeClassconstructor, which is unexpected.I would expect to only need to call the
WindowSizeClassconstructor if I am trying to define my own, customWindowSizeClass.If I am trying to determine the
WindowSizeClassfor a specific window size, I would expect to call thecomputemethod instead.