Fixed
Status Update
Comments
di...@google.com <di...@google.com> #2
The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.
di...@google.com <di...@google.com>
ap...@google.com <ap...@google.com> #3
The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.
Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.
na...@google.com <na...@google.com> #4
Hi Nona,
Can you please schedule a release after you merge the fix?
Description
The deprecated method has a replacement of the
WindowSizeClass.Companion.compute
WindowSizeClass
constructor, which is unexpected.I would expect to only need to call the
WindowSizeClass
constructor if I am trying to define my own, customWindowSizeClass
.If I am trying to determine the
WindowSizeClass
for a specific window size, I would expect to call thecompute
method instead.