Fixed
Status Update
No update yet.
Comments
ml...@google.com
targetPackageOnly needs to be updated to understand process_tracks in addition to thread_tracks. E.g. could union the current result with one around process_tracks, something like:
select * from slice
inner join process_track on slice.track_id = process_track.id
inner join process USING(upid)
where slice.id=23647
ap...@google.com
I was thinking, since this is already in beta03, should we treat it as a bug and not addition to 1.3?
ma...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3bfcb889231d3254cf9e8db8df0c2a06f58c152a
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Apr 02 14:14:17 2024
TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
* TraceSectionMetric now additionally looks at Perfetto `process_track`s when looking at named slices.
Test: PerfettoTraceProcessorTest
Fixes: 300434906
Relnote: TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
Change-Id: I91b326e121fcca4b3ce8f65381eea87de796cdd1
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt
https://android-review.googlesource.com/3023506
Branch: androidx-main
commit 3bfcb889231d3254cf9e8db8df0c2a06f58c152a
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Apr 02 14:14:17 2024
TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
* TraceSectionMetric now additionally looks at Perfetto `process_track`s when looking at named slices.
Test: PerfettoTraceProcessorTest
Fixes: 300434906
Relnote: TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
Change-Id: I91b326e121fcca4b3ce8f65381eea87de796cdd1
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt
ma...@google.com
ma...@google.com
ma...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.3.0-alpha03
Description
Baseline Profile Gradle Plugin (BPGP) creates custom build types that are properly set up to generate optimal baseline profiles.
There's no way though to tweak the configuration to app's specific needs and prevent creating duplicate confusing build types.
Consider the
applicationIdSuffix.Either the application has duplicate build types
benchmarkBenchmark, or there's no way to defineapplicationIdSuffixinbenchmarkbuild type generated by BPGP.I think we should allow developers telling BPGP to either: a) define their own
benchmarkbuild type b) allowing customization of thebenchmarkbuild type created by BPGP.