Status Update
Comments
ma...@wmg.com <ma...@wmg.com> #2
I cannot repro this exactly do you need?
var isRefreshing by rememberSaveable { mutableStateOf(false) }
I think my latest change helps with these kind of issues too
But It hasn't been released yet.
Any chance you can upload the full sample on github, so I can double check?
ma...@wmg.com <ma...@wmg.com> #3
ke...@google.com <ke...@google.com>
64...@gmail.com <64...@gmail.com> #5
Thanks I think I was able to identify the issue and a potential fix
tj...@fieldwire.com <tj...@fieldwire.com> #6
Branch: androidx-main
commit f1515ea14143b5754df3dcbcb47537eee49c30f2
Author: Mariano Martin <ymarian@google.com>
Date: Thu Sep 05 13:12:04 2024
[PullToRefresh] Fix issue where graphics layer doesnt invalidate
Test: tested manually that now graphics layer invalidates, in some edge cases
where pullToRefresh is used in fragments
Bug: 356039090
Change-Id: Ib80663f6dcf2f7f05bda4189b0931ee697230698
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/pulltorefresh/PullToRefresh.kt
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.4.0-alpha01
androidx.compose.material3:material3-android:1.4.0-alpha01
se...@google.com <se...@google.com>
le...@gmail.com <le...@gmail.com> #8
Project: platform/frameworks/support
Branch: androidx-main
Author: Mariano Martin <
Link:
[WideNavigationRail] API Feedback
Expand for full commit details
[WideNavigationRail] API Feedback
Update State classes to use booleans, and current/target value.
Change expect/actual properties constructor.
Test: existing tests
Relnote: Change WideNavigationRailState to have current/target value, remove enums in favor of boolean.
Bug: 356039090
Change-Id: Idfa29aad7efd1d0e943bf175f5bcb1fc347fdf0e
Files:
- M
compose/material3/benchmark/src/androidTest/java/androidx/compose/material3/benchmark/NavigationRailBenchmark.kt
- M
compose/material3/material3/api/current.txt
- M
compose/material3/material3/api/restricted_current.txt
- M
compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/NavigationRailSamples.kt
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalWideNavigationRailScreenshotTest.kt
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalWideNavigationRailTest.kt
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/WideNavigationRailScreenshotTest.kt
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/WideNavigationRailTest.kt
- M
compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/WideNavigationRail.android.kt
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/WideNavigationRail.kt
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/WideNavigationRailState.kt
- M
compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/WideNavigationRail.commonStubs.kt
Hash: 724c3f7eb85d05c92ce724d5c529f579d771edd4
Date: Mon Nov 18 13:19:35 2024
ri...@td.com <ri...@td.com> #9
This behavior is pretty frustrating for our users, can we port this backwards to a stable version instead of an alpha version? I'd rather not consume an alpha version and ship it to production.
Description
Jetpack Compose version: 1.5.9 Jetpack Compose component used: BottomModalSheet Android Studio Build: Hedgehog 2023.1.1 Patch 2 Kotlin version: 1.9.22
Steps to Reproduce or Code Sample to Reproduce:
We have a
ModalBottomSheet
with a stickyTextField
on the bottom. We allow bothPartiallyExpanded
andExpanded
states. Whenever we are in theExpanded
state and focus on theTextField
, the resulting screen resize from the keyboard showing causes theModalBottomSheet
to switch its target state toPartiallyExpanded
.This is a pretty jarring UI experience and ideally we would just stay in the
Expanded
state.I've traced it down to these lines in
ModalBottomSheet.android.kt
that prioritizePartiallyExpanded
whenever the anchors change (via the screen size changing).Here is a sample project and video is included: