Status Update
Comments
ma...@wmg.com <ma...@wmg.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
ma...@wmg.com <ma...@wmg.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
ke...@google.com <ke...@google.com>
ap...@google.com <ap...@google.com> #4
Branch: main
commit 0fe5e3c558992a1c0b5b2aef2594049862b1c703
Author: Zach Katz <katzz@google.com>
Date: Fri May 03 23:02:15 2024
[ASH] Add fieldtrial_testing_config
Bug: 324934884
Change-Id: Ib9d0ade90999a67cd74d1b94e6ab43087b5e1ead
Reviewed-on:
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Zach Katz <katzz@google.com>
Cr-Commit-Position: refs/heads/main@{#1296421}
M testing/variations/fieldtrial_testing_config.json
64...@gmail.com <64...@gmail.com> #5
any update on this? 😅
tj...@fieldwire.com <tj...@fieldwire.com> #6
any updates?
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <
Link:
[M3][BottomSheets] Update Expanded target to remain expanded on resize.
Expand for full commit details
[M3][BottomSheets] Update Expanded target to remain expanded on resize.
Expanded anchor is always defined.
Bug: 324934884
Test: Add Expanded check to anchor testing
RelNote: "Expanded bottom sheet remains expanded on size change."
Change-Id: I2870ba38420d18b02676e6f280ef96dddc6a3a8a
Files:
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
Hash: 0a8673ffe397d5cfe341fa60a281212388c3f1e0
Date: Fri Nov 08 16:59:04 2024
se...@google.com <se...@google.com>
le...@gmail.com <le...@gmail.com> #8
not fixed
ri...@td.com <ri...@td.com> #9
This behavior is pretty frustrating for our users, can we port this backwards to a stable version instead of an alpha version? I'd rather not consume an alpha version and ship it to production.
Description
Jetpack Compose version: 1.5.9 Jetpack Compose component used: BottomModalSheet Android Studio Build: Hedgehog 2023.1.1 Patch 2 Kotlin version: 1.9.22
Steps to Reproduce or Code Sample to Reproduce:
We have a
ModalBottomSheet
with a stickyTextField
on the bottom. We allow bothPartiallyExpanded
andExpanded
states. Whenever we are in theExpanded
state and focus on theTextField
, the resulting screen resize from the keyboard showing causes theModalBottomSheet
to switch its target state toPartiallyExpanded
.This is a pretty jarring UI experience and ideally we would just stay in the
Expanded
state.I've traced it down to these lines in
ModalBottomSheet.android.kt
that prioritizePartiallyExpanded
whenever the anchors change (via the screen size changing).Here is a sample project and video is included: