Status Update
Comments
ma...@wmg.com <ma...@wmg.com> #3
Thanks for the report!
ke...@google.com <ke...@google.com>
ap...@google.com <ap...@google.com> #4
The release notes documentation has been edited to clarify this change in behavior for line height.
To support non-standard text sizes, we encourage users to follow the Material design system and use a different style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified)
, or create a custom Typography
entirely.
64...@gmail.com <64...@gmail.com> #5
tj...@fieldwire.com <tj...@fieldwire.com> #6
In my case, I have multiple font sizes in the same Text
(using SpanStyle
in AnnotatedString
). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <
Link:
[M3][BottomSheets] Update Expanded target to remain expanded on resize.
Expand for full commit details
[M3][BottomSheets] Update Expanded target to remain expanded on resize.
Expanded anchor is always defined.
Bug: 324934884
Test: Add Expanded check to anchor testing
RelNote: "Expanded bottom sheet remains expanded on size change."
Change-Id: I2870ba38420d18b02676e6f280ef96dddc6a3a8a
Files:
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
Hash: 0a8673ffe397d5cfe341fa60a281212388c3f1e0
Date: Fri Nov 08 16:59:04 2024
se...@google.com <se...@google.com>
le...@gmail.com <le...@gmail.com> #8
not fixed
ri...@td.com <ri...@td.com> #9
This behavior is pretty frustrating for our users, can we port this backwards to a stable version instead of an alpha version? I'd rather not consume an alpha version and ship it to production.
Description
Jetpack Compose version: 1.5.9 Jetpack Compose component used: BottomModalSheet Android Studio Build: Hedgehog 2023.1.1 Patch 2 Kotlin version: 1.9.22
Steps to Reproduce or Code Sample to Reproduce:
We have a
ModalBottomSheet
with a stickyTextField
on the bottom. We allow bothPartiallyExpanded
andExpanded
states. Whenever we are in theExpanded
state and focus on theTextField
, the resulting screen resize from the keyboard showing causes theModalBottomSheet
to switch its target state toPartiallyExpanded
.This is a pretty jarring UI experience and ideally we would just stay in the
Expanded
state.I've traced it down to these lines in
ModalBottomSheet.android.kt
that prioritizePartiallyExpanded
whenever the anchors change (via the screen size changing).Here is a sample project and video is included: