Modal/Standard Bottomsheet size change changes Expanded state to PartiallyExpanded [324934884]

Fixed

Bug

Status Update

No update yet.

Description

ma...@wmg.com

created issue #1

Feb 12, 2024 09:49PM

Jetpack Compose version: 1.5.9 Jetpack Compose component used: BottomModalSheet Android Studio Build: Hedgehog 2023.1.1 Patch 2 Kotlin version: 1.9.22

Steps to Reproduce or Code Sample to Reproduce:

We have a ModalBottomSheet with a sticky TextField on the bottom. We allow both PartiallyExpanded and Expanded states. Whenever we are in the Expanded state and focus on the TextField, the resulting screen resize from the keyboard showing causes the ModalBottomSheet to switch its target state to PartiallyExpanded.

This is a pretty jarring UI experience and ideally we would just stay in the Expanded state.

I've traced it down to these lines in ModalBottomSheet.android.kt that prioritize PartiallyExpanded whenever the anchors change (via the screen size changing).

Here is a sample project and video is included:

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun Screen() {
    var isShowingDialog by remember { mutableStateOf(false) }
    var text by remember { mutableStateOf("") }

    var modalHeight by remember { mutableIntStateOf(0) }
    val sheetState = rememberModalBottomSheetState()

    Box(Modifier.fillMaxSize(), contentAlignment = Alignment.Center) {
        Button(onClick = { isShowingDialog = true }) {
            Text(text = "Show dialog")
        }
    }

    if (isShowingDialog) {
        ModalBottomSheet(
            onDismissRequest = { isShowingDialog = false },
            modifier = Modifier.onGloballyPositioned { modalHeight = it.size.height },
            sheetState = sheetState,
        ) {
            Column {
                Text("Content", modifier = Modifier.weight(1f))
                TextField(
                    value = text,
                    onValueChange = { text = it},
                    modifier = Modifier
                        .padding(16.dp)
                        .fillMaxWidth()
                        .offset {
                            IntOffset(
                                x = 0,
                                y = -sheetState
                                    .requireOffset()
                                    .toInt()
                                    .coerceAtMost(modalHeight / 2)
                            )
                        }
                )
            }
        }
    }
}

modalbottomsheet.mp4

2.2 MB

Download

Comments

ma...@wmg.com <ma...@wmg.com> #2Feb 12, 2024 09:53PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ma...@wmg.com <ma...@wmg.com> #3Feb 12, 2024 10:10PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

Message last modified on Feb 12, 2024 10:12PM

ke...@google.com <ke...@google.com> Feb 13, 2024 03:44PM

Reassigned to ma...@google.com.

ap...@google.com <ap...@google.com> #4May 3, 2024 11:03PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

64...@gmail.com <64...@gmail.com> #5Sep 22, 2024 08:40PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

tj...@fieldwire.com <tj...@fieldwire.com> #6Oct 23, 2024 05:45PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

se...@google.com <se...@google.com> Nov 8, 2024 09:57PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #7Nov 13, 2024 02:28PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

se...@google.com <se...@google.com> Nov 13, 2024 02:31PM

Marked as fixed.

le...@gmail.com <le...@gmail.com> #8Dec 20, 2024 01:35AM

Thank you, I'll try it and check.

ri...@td.com <ri...@td.com> #9Feb 4, 2025 03:29PM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.