exception and crash in RangeSlider in stepped mode, when the end thumb is drag-pulled below start thumb [324934900]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 13, 2024 06:04AM

Jetpack Compose version: 2024.01.00

Jetpack Compose component(s) used: RangeSlider

Android Studio Build: Build #AI-231.9392.1.2311.11330709, built on January 19, 2024

Kotlin version: 1.9.22

Material 3 version : 1.2.0-beta02

Steps to Reproduce or Code Sample to Reproduce:

Use a RangeSlider
Specify a range
Specify a selected range
Specify number of steps greater than 0 (in my case it is 5) - Note with steps = 0 this error does not happen
Run the app and attempt to drag the start thumb beyond the end thumb or vice versa
Observe application crashing with the following error and stack trace
Observe that SliderRange is failing the require(isUnspecified || start <= endInclusive ) check on line 2120 due to rounding error as can be seen in the first line of the stack trace, where start is only 0.00005 of a pixel greater than the endInclusive

Suggestion of a solution to fix this error

It is a known issue that floating point calculation is inherently imprecise in a sense that the resulting value is correct up to a specific decimal position. I suspect that the same is happening here when the start point and end point coordinates are being calculated. The start point may have gotten 593.6667500000000000000000... rounded to 593.66675 and endInclusive may have gotten 593.66674999999999999999.... rounded to 593.6667.

When doing floating point calculations for UI it is imperative to have a consistent cut off strategy for how many decimal places should be considered system-wise for rendering. In my experience 2 decimal places are ample for pixel-related arithmetics; anything beyond makes no visual difference.

So trim pixel values to only carry 2 decimal positions and discard everything from 3rd decimal position onwards. (Do NOT round the values!)

Following the strategy above system-wide for UI pixel-related arithmetics, will make sure that elusive errors like this do not happen.

Stack trace:

java.lang.IllegalArgumentException: start(593.66675) must be <= endInclusive(593.6667)
   at androidx.compose.material3.SliderKt.SliderRange(Slider.kt:2120)
   at androidx.compose.material3.RangeSliderState.onDrag$material3_release(Slider.kt:1990)
   at androidx.compose.material3.RangeSliderLogic.captureThumb(Slider.kt:1574)
   at androidx.compose.material3.SliderKt$rangeSliderPressDragModifier$1$1$1.invokeSuspend(Slider.kt:1519)
   at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
   at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:179)
   at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:168)
   at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:474)
   at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:508)
   at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:497)
   at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:368)
   at
                 androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl$PointerEventHandlerCoroutine.offerPointerEvent(SuspendingPointerInputFilter.kt:665)
   at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.dispatchPointerEvent(SuspendingPointerInputFilter.kt:544)
   at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.onPointerEvent-H0pRuoY(SuspendingPointerInputFilter.kt:566)
   at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:317)
   at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
   at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
   at androidx.compose.ui.input.pointer.NodeParent.dispatchMainEventPass(HitPathTracker.kt:185)
   at androidx.compose.ui.input.pointer.HitPathTracker.dispatchChanges(HitPathTracker.kt:104)
   at androidx.compose.ui.input.pointer.PointerInputEventProcessor.process-BIzXfog(PointerInputEventProcessor.kt:113)
   at androidx.compose.ui.platform.AndroidComposeView.sendMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1576)
   at androidx.compose.ui.platform.AndroidComposeView.handleMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1527)
   at androidx.compose.ui.platform.AndroidComposeView.dispatchTouchEvent(AndroidComposeView.android.kt:1466)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:502)
   at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1890)
   at android.app.Activity.dispatchTouchEvent(Activity.java:4199)
   at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:460)
   at android.view.View.dispatchPointerEvent(View.java:14858)
   at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6446)
   at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6247)
   at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5725)
   at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782)
   at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748)
   at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5913)
   at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756)
16:18:24.369  E  	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5970)
   at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729)
   at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782)
   at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748)
   at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756)
   at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729)
   at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8696)
   at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8647)
   at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8616)
   at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:8819)
   at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:259)
   at android.view.InputEventReceiver.nativeConsumeBatchedInputEvents(Native Method)
   at android.view.InputEventReceiver.consumeBatchedInputEvents(InputEventReceiver.java:239)
   at android.view.ViewRootImpl.doConsumeBatchedInput(ViewRootImpl.java:8776)
   at android.view.ViewRootImpl$ConsumeBatchedInputRunnable.run(ViewRootImpl.java:8905)
   at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
   at android.view.Choreographer.doCallbacks(Choreographer.java:845)
   at android.view.Choreographer.doFrame(Choreographer.java:772)
   at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
   at android.os.Handler.handleCallback(Handler.java:938)
   at android.os.Handler.dispatchMessage(Handler.java:99)
   at android.os.Looper.loopOnce(Looper.java:201)
   at android.os.Looper.loop(Looper.java:288)
   at android.app.ActivityThread.main(ActivityThread.java:7842)
   at java.lang.reflect.Method.invoke(Native Method)
   at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
   Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@e8f0b9c, androidx.compose.runtime.BroadcastFrameClock@f19a9a5, StandaloneCoroutine{Cancelling}@a3bb17a, AndroidUiDispatcher@9d9ed2b]

Screen Recording 2024-02-13 at 5.01.48 pm.mov

33 MB

Download

Comments

ae...@google.com <ae...@google.com> Feb 16, 2024 09:01PM

Assigned to ke...@google.com.

ke...@google.com <ke...@google.com> Feb 27, 2024 04:17PM

Marked as fixed.

ap...@google.com <ap...@google.com> #2Feb 27, 2024 04:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2099e20d0af61318ec59b5c6391498304979e024
Author: Clara Fok <clarafok@google.com>
Date: Wed May 03 14:38:14 2023

Migrate paging-testing to PagingSourceFactory

Migrate existing usages of lambda type () -> PagingSource<Key, Value> to concrete PagingSourceFactory<Key, Value> type

Test: ./gradlew paging:paging-testing:cC
Bug: 280655188
Relnote: "Migrated paging-testing's use of lambda type () -> PagingSource<Key, Value> to type PagingSourceFactory<Key, Value>."
Change-Id: I4a95067989fabf8258a3392007dbf8abd35d8efa

M paging/paging-testing/api/current.txt
M paging/paging-testing/api/public_plus_experimental_current.txt
M paging/paging-testing/api/restricted_current.txt
M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/PagerFlowSnapshotTest.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/StaticListPagingSourceFactoryTest.kt

https://android-review.googlesource.com/2579311

na...@google.com <na...@google.com> #3Mar 6, 2024 07:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit f06753ed29d67623b4061cb222717948d0a37ef7
Author: Clara Fok <clarafok@google.com>
Date: Wed May 03 13:16:53 2023

Add PagingSourceFactory interface

This functional interface allows creating a PagingSourceFactory by passing in a lambda that returns a PagingSource, or by creating a class that extends this interface. The factory can be passed into Pager as the pagingSourceFactory.

Test: ./gradlew paging:paging-common:test
Bug: 280655188
Relnote: "Added a new PagingSourceFactory functional interface. Override the invoke() method with an implementation that returns a new instance of PagingSource. This factory can be used to instantiate a Pager."
Change-Id: I3316590a0d667566edeb40d4e99e005cd6cee3ac

M paging/paging-common/api/current.txt
M paging/paging-common/api/public_plus_experimental_current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-common/src/main/kotlin/androidx/paging/InvalidatingPagingSourceFactory.kt
A paging/paging-common/src/main/kotlin/androidx/paging/PagingSourceFactory.kt

https://android-review.googlesource.com/2579310

lo...@gmail.com <lo...@gmail.com> #4Aug 13, 2024 02:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit 967c97f18d7f2a717222b09be6227f0f7dabb323
Author: Clara Fok <clarafok@google.com>
Date: Thu May 04 13:06:24 2023

Update documentation for asPagingSourceFactory API

Kdocs updated to reflec the API's migration from returning a lambda to returning a Class.

Test: n/a
Bug: 280655188
Change-Id: Ib3f9b5c9215ba9e5ee38d6b192e9858bbe080346

M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt

https://android-review.googlesource.com/2580094

ty...@gmail.com <ty...@gmail.com> #5Feb 4, 2025 03:18PM

Project: platform/frameworks/support
Branch: androidx-main

commit 59e0f757ba85b81b800e6fb0d60dd25dd88bee54
Author: Clara Fok <clarafok@google.com>
Date: Thu May 04 12:52:34 2023

Expand asPagingSourceFactory API to singe list

In addition to Flow<List<Value>>.asPagingSourceFactory API, we added a List<Value>.asPagingSourceFactory. All PagingSoruces produced by this new API will load from the exact same static list of data. It supports multi-generational operations such as refresh, but it does not support any updates to the source data. Because it operates on a static list, collection is not required which removes the requirement for a coroutineScope.

Test: ./gradlew paging:paging-testing:test
Bug: 280655188
Relnote: "Added new API List<Value>.asPagingSourceFactory to get a factory that creates PagingSource instances that loads from the immutable list of data."
Change-Id: Id34d1361119413d0c19a054a2e23dd26241faa6f

M paging/paging-testing/api/current.txt
M paging/paging-testing/api/public_plus_experimental_current.txt
M paging/paging-testing/api/restricted_current.txt
M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/PagerFlowSnapshotTest.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/StaticListPagingSourceFactoryTest.kt

https://android-review.googlesource.com/2580093

lo...@gmail.com <lo...@gmail.com> #6Feb 26, 2025 02:39PM

Fixed internally and will be available in paging 3.2.0-alpha06.