exception and crash in RangeSlider in stepped mode, when the end thumb is drag-pulled below start thumb [324934900]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 13, 2024 06:04AM

Jetpack Compose version: 2024.01.00

Jetpack Compose component(s) used: RangeSlider

Android Studio Build: Build #AI-231.9392.1.2311.11330709, built on January 19, 2024

Kotlin version: 1.9.22

Material 3 version : 1.2.0-beta02

Steps to Reproduce or Code Sample to Reproduce:

Use a RangeSlider
Specify a range
Specify a selected range
Specify number of steps greater than 0 (in my case it is 5) - Note with steps = 0 this error does not happen
Run the app and attempt to drag the start thumb beyond the end thumb or vice versa
Observe application crashing with the following error and stack trace
Observe that SliderRange is failing the require(isUnspecified || start <= endInclusive ) check on line 2120 due to rounding error as can be seen in the first line of the stack trace, where start is only 0.00005 of a pixel greater than the endInclusive

Suggestion of a solution to fix this error

It is a known issue that floating point calculation is inherently imprecise in a sense that the resulting value is correct up to a specific decimal position. I suspect that the same is happening here when the start point and end point coordinates are being calculated. The start point may have gotten 593.6667500000000000000000... rounded to 593.66675 and endInclusive may have gotten 593.66674999999999999999.... rounded to 593.6667.

When doing floating point calculations for UI it is imperative to have a consistent cut off strategy for how many decimal places should be considered system-wise for rendering. In my experience 2 decimal places are ample for pixel-related arithmetics; anything beyond makes no visual difference.

So trim pixel values to only carry 2 decimal positions and discard everything from 3rd decimal position onwards. (Do NOT round the values!)

Following the strategy above system-wide for UI pixel-related arithmetics, will make sure that elusive errors like this do not happen.

Stack trace:

java.lang.IllegalArgumentException: start(593.66675) must be <= endInclusive(593.6667)
   at androidx.compose.material3.SliderKt.SliderRange(Slider.kt:2120)
   at androidx.compose.material3.RangeSliderState.onDrag$material3_release(Slider.kt:1990)
   at androidx.compose.material3.RangeSliderLogic.captureThumb(Slider.kt:1574)
   at androidx.compose.material3.SliderKt$rangeSliderPressDragModifier$1$1$1.invokeSuspend(Slider.kt:1519)
   at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
   at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:179)
   at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:168)
   at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:474)
   at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:508)
   at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:497)
   at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:368)
   at
                 androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl$PointerEventHandlerCoroutine.offerPointerEvent(SuspendingPointerInputFilter.kt:665)
   at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.dispatchPointerEvent(SuspendingPointerInputFilter.kt:544)
   at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.onPointerEvent-H0pRuoY(SuspendingPointerInputFilter.kt:566)
   at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:317)
   at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
   at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
   at androidx.compose.ui.input.pointer.NodeParent.dispatchMainEventPass(HitPathTracker.kt:185)
   at androidx.compose.ui.input.pointer.HitPathTracker.dispatchChanges(HitPathTracker.kt:104)
   at androidx.compose.ui.input.pointer.PointerInputEventProcessor.process-BIzXfog(PointerInputEventProcessor.kt:113)
   at androidx.compose.ui.platform.AndroidComposeView.sendMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1576)
   at androidx.compose.ui.platform.AndroidComposeView.handleMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1527)
   at androidx.compose.ui.platform.AndroidComposeView.dispatchTouchEvent(AndroidComposeView.android.kt:1466)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:502)
   at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1890)
   at android.app.Activity.dispatchTouchEvent(Activity.java:4199)
   at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:460)
   at android.view.View.dispatchPointerEvent(View.java:14858)
   at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6446)
   at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6247)
   at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5725)
   at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782)
   at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748)
   at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5913)
   at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756)
16:18:24.369  E  	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5970)
   at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729)
   at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782)
   at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748)
   at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756)
   at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729)
   at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8696)
   at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8647)
   at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8616)
   at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:8819)
   at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:259)
   at android.view.InputEventReceiver.nativeConsumeBatchedInputEvents(Native Method)
   at android.view.InputEventReceiver.consumeBatchedInputEvents(InputEventReceiver.java:239)
   at android.view.ViewRootImpl.doConsumeBatchedInput(ViewRootImpl.java:8776)
   at android.view.ViewRootImpl$ConsumeBatchedInputRunnable.run(ViewRootImpl.java:8905)
   at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
   at android.view.Choreographer.doCallbacks(Choreographer.java:845)
   at android.view.Choreographer.doFrame(Choreographer.java:772)
   at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
   at android.os.Handler.handleCallback(Handler.java:938)
   at android.os.Handler.dispatchMessage(Handler.java:99)
   at android.os.Looper.loopOnce(Looper.java:201)
   at android.os.Looper.loop(Looper.java:288)
   at android.app.ActivityThread.main(ActivityThread.java:7842)
   at java.lang.reflect.Method.invoke(Native Method)
   at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
   Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@e8f0b9c, androidx.compose.runtime.BroadcastFrameClock@f19a9a5, StandaloneCoroutine{Cancelling}@a3bb17a, AndroidUiDispatcher@9d9ed2b]

Screen Recording 2024-02-13 at 5.01.48 pm.mov

33 MB

Download

Comments

ae...@google.com <ae...@google.com> Feb 16, 2024 09:01PM

Assigned to ke...@google.com.

ke...@google.com <ke...@google.com> Feb 27, 2024 04:17PM

Marked as fixed.

ap...@google.com <ap...@google.com> #2Feb 27, 2024 04:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

na...@google.com <na...@google.com> #3Mar 6, 2024 07:49PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.0-alpha02
androidx.compose.material3:material3-android:1.3.0-alpha02
androidx.compose.material3:material3-desktop:1.3.0-alpha02

lo...@gmail.com <lo...@gmail.com> #4Aug 13, 2024 02:52PM

Unfortunately, this fix is not sufficient. We got the first crash with the updated version:

java.lang.IllegalArgumentException: start(3467.0002) must be <= endInclusive(3467.0)

Note that our slider usually has to take care of 4 to 5 digit numbers (prices). I think there will probably always be a case where the selected tolerance is not large enough if you increase the slider value range accordingly.

ty...@gmail.com <ty...@gmail.com> #5Feb 4, 2025 03:18PM

I am encountering this crash as well. In our case we use the range slider for a min and max year selector. When sliding the min or max to be equal to the other then it crashes. This is what our slider code looks like.

Column(modifier = Modifier.padding(horizontal = 16.dp)) {
    var sliderRange = (state.minYear.toFloat())..state.maxYear.toFloat()
    var cachedMin by remember { mutableIntStateOf(YearEstablishedFilterState.MIN_YEAR) }
    var cachedMax by remember { mutableIntStateOf(Year.now().value) }
    RangeSlider(
        value = sliderRange,
        valueRange = YearEstablishedFilterState.MIN_YEAR.toFloat()..Year.now().value.toFloat(),
        steps = Year.now().value - YearEstablishedFilterState.MIN_YEAR,
        colors = SliderDefaults.colors(
            thumbColor = ExtendedTheme.colors.secondaryText,
            activeTrackColor = ExtendedTheme.colors.secondaryText,
            inactiveTrackColor = ExtendedTheme.colors.divider,
            activeTickColor = ExtendedTheme.colors.secondaryText,
            inactiveTickColor = ExtendedTheme.colors.divider
        ),
        onValueChange = { range ->
            sliderRange = range

            val minYear = range.start.roundToInt()
            val maxYear = range.endInclusive.roundToInt()

            if (minYear != cachedMin || maxYear != cachedMax) {
                haptic.performHapticFeedback(HapticFeedbackType.TextHandleMove)
                cachedMin = minYear
                cachedMax = maxYear
            }

            onRangeChanged(
                minYear,
                maxYear
            )
        }
    )
}

lo...@gmail.com <lo...@gmail.com> #6Feb 26, 2025 02:39PM

I already created a follow up ticket: https://issuetracker.google.com/issues/368982579