exception and crash in RangeSlider in stepped mode, when the end thumb is drag-pulled below start thumb [324934900]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 13, 2024 06:04AM

Jetpack Compose version: 2024.01.00

Jetpack Compose component(s) used: RangeSlider

Android Studio Build: Build #AI-231.9392.1.2311.11330709, built on January 19, 2024

Kotlin version: 1.9.22

Material 3 version : 1.2.0-beta02

Steps to Reproduce or Code Sample to Reproduce:

Use a RangeSlider
Specify a range
Specify a selected range
Specify number of steps greater than 0 (in my case it is 5) - Note with steps = 0 this error does not happen
Run the app and attempt to drag the start thumb beyond the end thumb or vice versa
Observe application crashing with the following error and stack trace
Observe that SliderRange is failing the require(isUnspecified || start <= endInclusive ) check on line 2120 due to rounding error as can be seen in the first line of the stack trace, where start is only 0.00005 of a pixel greater than the endInclusive

Suggestion of a solution to fix this error

It is a known issue that floating point calculation is inherently imprecise in a sense that the resulting value is correct up to a specific decimal position. I suspect that the same is happening here when the start point and end point coordinates are being calculated. The start point may have gotten 593.6667500000000000000000... rounded to 593.66675 and endInclusive may have gotten 593.66674999999999999999.... rounded to 593.6667.

When doing floating point calculations for UI it is imperative to have a consistent cut off strategy for how many decimal places should be considered system-wise for rendering. In my experience 2 decimal places are ample for pixel-related arithmetics; anything beyond makes no visual difference.

So trim pixel values to only carry 2 decimal positions and discard everything from 3rd decimal position onwards. (Do NOT round the values!)

Following the strategy above system-wide for UI pixel-related arithmetics, will make sure that elusive errors like this do not happen.

Stack trace:

java.lang.IllegalArgumentException: start(593.66675) must be <= endInclusive(593.6667)
   at androidx.compose.material3.SliderKt.SliderRange(Slider.kt:2120)
   at androidx.compose.material3.RangeSliderState.onDrag$material3_release(Slider.kt:1990)
   at androidx.compose.material3.RangeSliderLogic.captureThumb(Slider.kt:1574)
   at androidx.compose.material3.SliderKt$rangeSliderPressDragModifier$1$1$1.invokeSuspend(Slider.kt:1519)
   at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
   at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:179)
   at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:168)
   at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:474)
   at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:508)
   at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:497)
   at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:368)
   at
                 androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl$PointerEventHandlerCoroutine.offerPointerEvent(SuspendingPointerInputFilter.kt:665)
   at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.dispatchPointerEvent(SuspendingPointerInputFilter.kt:544)
   at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl.onPointerEvent-H0pRuoY(SuspendingPointerInputFilter.kt:566)
   at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:317)
   at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
   at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:303)
   at androidx.compose.ui.input.pointer.NodeParent.dispatchMainEventPass(HitPathTracker.kt:185)
   at androidx.compose.ui.input.pointer.HitPathTracker.dispatchChanges(HitPathTracker.kt:104)
   at androidx.compose.ui.input.pointer.PointerInputEventProcessor.process-BIzXfog(PointerInputEventProcessor.kt:113)
   at androidx.compose.ui.platform.AndroidComposeView.sendMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1576)
   at androidx.compose.ui.platform.AndroidComposeView.handleMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1527)
   at androidx.compose.ui.platform.AndroidComposeView.dispatchTouchEvent(AndroidComposeView.android.kt:1466)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3120)
   at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2801)
   at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:502)
   at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1890)
   at android.app.Activity.dispatchTouchEvent(Activity.java:4199)
   at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:460)
   at android.view.View.dispatchPointerEvent(View.java:14858)
   at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6446)
   at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6247)
   at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5725)
   at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782)
   at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748)
   at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5913)
   at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756)
16:18:24.369  E  	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5970)
   at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729)
   at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782)
   at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748)
   at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756)
   at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729)
   at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8696)
   at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8647)
   at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8616)
   at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:8819)
   at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:259)
   at android.view.InputEventReceiver.nativeConsumeBatchedInputEvents(Native Method)
   at android.view.InputEventReceiver.consumeBatchedInputEvents(InputEventReceiver.java:239)
   at android.view.ViewRootImpl.doConsumeBatchedInput(ViewRootImpl.java:8776)
   at android.view.ViewRootImpl$ConsumeBatchedInputRunnable.run(ViewRootImpl.java:8905)
   at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
   at android.view.Choreographer.doCallbacks(Choreographer.java:845)
   at android.view.Choreographer.doFrame(Choreographer.java:772)
   at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
   at android.os.Handler.handleCallback(Handler.java:938)
   at android.os.Handler.dispatchMessage(Handler.java:99)
   at android.os.Looper.loopOnce(Looper.java:201)
   at android.os.Looper.loop(Looper.java:288)
   at android.app.ActivityThread.main(ActivityThread.java:7842)
   at java.lang.reflect.Method.invoke(Native Method)
   at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
   Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@e8f0b9c, androidx.compose.runtime.BroadcastFrameClock@f19a9a5, StandaloneCoroutine{Cancelling}@a3bb17a, AndroidUiDispatcher@9d9ed2b]

Screen Recording 2024-02-13 at 5.01.48 pm.mov

33 MB

Download

Comments

ae...@google.com <ae...@google.com> Feb 16, 2024 09:01PM

Assigned to ke...@google.com.

ke...@google.com <ke...@google.com> Feb 27, 2024 04:17PM

Marked as fixed.

ap...@google.com <ap...@google.com> #2Feb 27, 2024 04:19PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

na...@google.com <na...@google.com> #3Mar 6, 2024 07:49PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

lo...@gmail.com <lo...@gmail.com> #4Aug 13, 2024 02:52PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ty...@gmail.com <ty...@gmail.com> #5Feb 4, 2025 03:18PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

lo...@gmail.com <lo...@gmail.com> #6Feb 26, 2025 02:39PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)