Support multiple stability configuration files [325326744]

Fixed

Bug

Status Update

No update yet.

Description

be...@google.com

created issue #1

Feb 14, 2024 10:11PM

The plugin option is set to allow multiple occurrences, but then we only read one path.

We should either just disable that, or support multiple files.

Comments

be...@google.com <be...@google.com> Feb 14, 2024 10:33PM

Reassigned to be...@google.com.

be...@google.com <be...@google.com> Feb 14, 2024 11:38PM

Accepted by be...@google.com.

ni...@ansman.se <ni...@ansman.se> #2Feb 15, 2024 12:45AM

I simpler example would be appreciated. I tried to download the pull request and build it but it relies on, for example, `rustc` to be installed which I don't have installed on my compose development machine.

Does the program work without the compiler switch. That is, is `"-P", "plugin:androidx.compose.compiler.plugins.kotlin:experimentalStrongSkipping=true",` required to reproduce or is just changing the runtime enough?

be...@google.com <be...@google.com> #3Feb 15, 2024 02:26AM

Yeah, changing compiler switch(enable/disable StrongSkipping, enable/disable nonSkippingGroup) has no effect, only changing runtime make sense.
Sorry for that, I will try to extract an example when I'm free.

ap...@google.com <ap...@google.com> #4Feb 19, 2024 09:03PM

Marked as fixed.

I have find a sample code to reproduce that

        setContent {
            val dialogState = remember { DialogState() }
            dialogState.Intercept()
            LaunchedEffect(Unit) {
                delay(1000)
                dialogState.bgWork {
                    delay(5000)
                }
                dialogState.showSelectActions {
                    onSelect("a") {

                    }
                    onSelect("b") {

                    }
                }
            }
        }

You can find implementation of DialogState here https://github.com/FooIbar/EhViewer/blob/ef16bdeb755ae888c74eaa4a337bd5b708fcc97e/app/src/main/kotlin/com/hippo/ehviewer/ui/tools/Dialog.kt#L92
https://github.com/FooIbar/EhViewer/blob/main/app/src/main/kotlin/com/hippo/ehviewer/util/Progress.kt Launch that Activity, wait 6 seconds and it will crash

ub...@gmail.com <ub...@gmail.com> #5Mar 20, 2024 05:53PM

Let me sort it out

The first crash
Reproduce: navigate to a gallery and navigate back
The reason is we have some code assume the forget order of RememberObserver(DisposableEffect), and 52835066c9044647a65dfb566f03131aab46e793 changed the order. Seems this is a intended behaviour.
I will fix it from my side. My bad

The second crash
Reproduce: #4 comment
StackTrace: https://bin.kv2.dev/~65d5c6175de7ed6bfdbdf1bd
We got a wrong object from SlotTable during recompose

pr...@google.com <pr...@google.com> #6Mar 20, 2024 08:26PM

And interestingly, if we insert delay(1000) between two dialog suspend usage

                dialogState.bgWork {
                    delay(5000)
                }
                delay(1000)
                dialogState.showSelectActions {
                    onSelect("a") {

                    }
                    onSelect("b") {

                    }
                }

It will not crash