Document and support AOT in microbenchmarks [325512900]

Fixed

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Feb 15, 2024 10:10PM

Enable experimentalProperties.put("android.experimental.force-aot-compilation", true) via benchmark plugin, removing from AndroidXImplPlugin
Switching to new API when available, ideally before we stabilize on the experimental property: b/288167775
Insert process compilation state into benchmark JSON
Consider options for throwing if compilation state unset (e.g. prevent CI runs failing to be compiled, unless dev opts for this)

Comments

cc...@google.com <cc...@google.com> Mar 14, 2024 11:23PM

Reassigned to ra...@google.com.

cc...@google.com <cc...@google.com> May 17, 2024 04:57PM

Reassigned to ma...@google.com.

ap...@google.com <ap...@google.com> #2May 29, 2024 09:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 782378852514e76eac3dfd115f7aca6c6ac6eec2
Author: Marcello Albano <maralb@google.com>
Date: Fri May 17 10:53:04 2024

Added enabling aot compilation prop in benchmark plugin

Test: ./gradlew benchmark:benchmark-gradle-plugin:test
Bug: 325512900
Change-Id: Ie049719ecb7e17ae46abf7c858120f03a35d9222

M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
M benchmark/gradle-plugin/src/test/kotlin/androidx/benchmark/gradle/BenchmarkPluginTest.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt

https://android-review.googlesource.com/3094561

ma...@google.com <ma...@google.com> May 31, 2024 05:32PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #3May 31, 2024 06:51PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5ba0e94ed48d43e30c51c999b247497e1ad675b0
Author: Marcello Albano <maralb@google.com>
Date: Sat May 18 11:58:28 2024

Added compilation mode into benchmark context

Bug: 325512900
Change-Id: If5612552a718b459e95cd96dc721e92a88e3fa8a
Test: ShellTest
Relnote: Added compilation mode to benchmark context

M benchmark/benchmark-common/src/androidTest/assets/macro-legacy-trivialscrollbench.json
M benchmark/benchmark-common/src/androidTest/assets/micro-legacy-trivialbench.json
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ResultWriterTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ShellTest.kt
A benchmark/benchmark-common/src/main/java/androidx/benchmark/PackageInfo.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/json/BenchmarkData.kt
M benchmark/integration-tests/macrobenchmark/src/main/java/androidx/benchmark/integration/macrobenchmark/CompilationModeTest.kt

https://android-review.googlesource.com/3094294

ma...@google.com <ma...@google.com> #4May 31, 2024 06:53PM

Marked as fixed.

Closing this one - remaining things to do will be in benchmark 1.4. Follow up on b/343983464

pr...@google.com <pr...@google.com> #5Jun 12, 2024 10:45PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.3.0-beta01
androidx.benchmark:benchmark-gradle-plugin:1.3.0-beta01