Lint cannot resolve sibling source sets' types in AGP 8.3.0-rc02 [325650375]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Feb 17, 2024 07:40PM

DESCRIBE THE ISSUE IN DETAIL:

While testing AGP 8.3 RCs, I noticed a strange issue where lint models types from sibling source sets as <ErrorType>. The simplest example of this is having a type in main that is used in test sources.

Example:

We have a kotlin.jvm project that defines this class in its main source set

abstract class SlackJvmTest {

}

Then we also have a test in its test source set that uses SlackJvmTest like so

class SubjectsTest : SlackJvmTest() {

}

Where things get weird is we have a lint check that enforces use of our common base test classes like SlackJvmTest, and that lint check suddenly started reporting an error on this case. After investigating, we found it's because lint reports the superclass as an ErrorType, where the asSourceString() of that class looks like this

class SubjectsTest : <ErrorType> {

}

Reproduced using both the bundled lint and also android.experimental.lint.version=8.4.0-alpha10. This also appears to affect all references (methods, classes, etc).

Studio Build: N/A
Version of Gradle Plugin: 8.3.0-rc01
Version of Gradle: 8.6
Version of Java: 21
OS: macOS Sonoma 14.3.1

Comments

za...@gmail.com <za...@gmail.com> #2Feb 17, 2024 07:59PM

Quick edit: This is with AGP 8.3.0-rc02, not rc01

za...@gmail.com <za...@gmail.com> #3Feb 17, 2024 08:03PM

It does seem to work correctly across module, so just specific to friend compilations within the same module

ga...@google.com <ga...@google.com> #4Feb 19, 2024 05:27PM

This is a regression from AGP 8.2.2.

ga...@google.com <ga...@google.com> #5Feb 19, 2024 06:05PM

Assigned to sp...@google.com.

Using the attached project and running ./gradlew :lib2:jar :lib:lint fails in 8.3.0-rc02. Updating gradle/libs.versions.toml with 8.2.2 fixes the issues.

Superclass detection in detector fails (see SampleCodeDetector.kt):

override fun createUastHandler(context: JavaContext): UElementHandler {
        return object : UElementHandler() {
            override fun visitClass(node: UClass) {
                if (node.name == "MyClassTest") {
                    val supertype = node.uastSuperTypes.single().getQualifiedName()
                    check(supertype == "com.example.lib.SlackJvmTest")
                }
            }
        }
    }

It does look like test has no reference on main in build/intermediates/unit_test_lint_model/global/generateJvmTestLintModel/main.xml. Scott, can you please take a look?

Message last modified on Feb 19, 2024 06:10PM

myapp-lint-test.zip

1.9 MB

Download

sp...@google.com <sp...@google.com> Feb 20, 2024 07:00PM

Accepted by sp...@google.com.

sp...@google.com <sp...@google.com> #6Feb 29, 2024 04:44PM

Marked as fixed.

Fixed here, which will be included in AGP 8.4.0-alpha14 and 8.3.1

an...@google.com <an...@google.com> #7Mar 18, 2024 05:53PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Iguana | 2023.2.1 Patch 1
Android Gradle Plugin 8.3.1

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!