Support handwriting rich gestures in Compose [325660505]

Fixed

Feature Request

Status Update

No update yet.

Description

ha...@google.com

created issue #1

Feb 16, 2024 10:26PM

Support handwriting rich gestures in Jetpack Compose

Comments

ap...@google.com <ap...@google.com> #2Mar 12, 2024 10:08PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ap...@google.com <ap...@google.com> #3Mar 26, 2024 09:54PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Apr 4, 2024 12:11AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5Apr 4, 2024 12:11AM

Project: platform/frameworks/support
Branch: androidx-main

commit 347ca4b6f293160e386a9050287006051fa144a2
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Tue Mar 19 14:33:13 2024

Support Stylus Select and Delete Handwriting Gestures

Bug: 325660505
Test: BasicTextFieldHandwritingGestureTest
Change-Id: I0b1ab54b248185db5a131dd627d3fb9c81e4251c

A compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/BasicTextFieldHandwritingGestureTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/internal/EditorInfoTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/internal/StatelessInputConnectionTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/AndroidTextInputSession.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/EditorInfo.android.kt
A compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/HandwritingGesture.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/StatelessInputConnection.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/TextInputSession.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

https://android-review.googlesource.com/3007793

ap...@google.com <ap...@google.com> #6Apr 5, 2024 07:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8b4dc0ded10d67cd5466e2a8046252b39293b393
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Wed Apr 03 18:11:02 2024

Support Selection/DeletionRangeGesture for CoreTextField

Bug: 325660505
Test: CoreTextFieldHandwritingGestureTest
Change-Id: I61f617b504000c40eb3ffafdf91a6ed8319c5584

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/CoreTextFieldHandwritingGestureTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/HandwritingGesture.android.kt

https://android-review.googlesource.com/3025754

ap...@google.com <ap...@google.com> #7Apr 5, 2024 07:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9b74f0014936faf17b34ede561ea85bb067966b9
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Wed Mar 27 14:24:06 2024

Support Selection/DeletionRangeGesture for BasicTextField

Bug:325660505
Test: BasicTextFieldHandwritingGestureTest
Change-Id: Ifbcf5ae9b0f4579f5813d16384c37daf2bd94fbe

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/BasicTextFieldHandwritingGestureTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/EditorInfo.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/HandwritingGesture.android.kt

https://android-review.googlesource.com/3017982

ap...@google.com <ap...@google.com> #8Apr 10, 2024 06:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit d74b4abc1ad3fef5a1975b9dec72b849d06a46e1
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Thu Apr 04 14:55:11 2024

Support JoinOrSplit gestures for BTF and BTF2

RelNote: "Introduce ViewConfiguration.HandwritingGestureLineMargin for handwriting gestures.
Support JoinOrSplit gesture for BasicTextField and BasicTextField2"
Bug: 325660505
Test: CoreTextFieldHandwritingGestureTest BasicTextFieldHandwritingGestureTest

Change-Id: Ie6e13b41cc82da1fd3c9ecc7ac34c3ff88dfa235

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/CoreTextFieldHandwritingGestureTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/TextTestExtensions.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/BasicTextFieldHandwritingGestureTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/AndroidTextInputSession.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/EditorInfo.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/HandwritingGesture.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/LegacyPlatformTextInputServiceAdapter.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/RecordingInputConnection.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/CodepointHelpers.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/LegacyAdaptingPlatformTextInputModifierNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/LegacyPlatformTextInputServiceAdapter.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldDecoratorModifier.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/input/internal/DesktopTextInputSession.desktop.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/text/input/internal/LegacyPlatformTextInputServiceAdapterTest.kt
M compose/foundation/foundation/src/jvmMain/kotlin/androidx/compose/foundation/text/input/internal/CodepointHelpers.jvm.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidViewConfiguration.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/ViewConfiguration.kt
M compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/DefaultViewConfiguration.skiko.kt

https://android-review.googlesource.com/3027864

ap...@google.com <ap...@google.com> #9Apr 10, 2024 10:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit b465a2073f8972da639b671527ae4c6c553a4e4f
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Tue Apr 09 17:45:27 2024

Support insert gesture for BTF and BTF2

Bug: 325660505
Test: CoreTextFieldHandwritingGestureTest BasicTextFieldHandwritingGestureTest
Change-Id: I04410216f3475ea0df3193657d510ee7d56e5df4

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/CoreTextFieldHandwritingGestureTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/BasicTextFieldHandwritingGestureTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/EditorInfo.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/HandwritingGesture.android.kt

https://android-review.googlesource.com/3035876

ap...@google.com <ap...@google.com> #10Apr 10, 2024 11:15PM

Project: platform/frameworks/support
Branch: androidx-main

commit eed7c2ed7a6f48b3e6458258e8cd84b21d65785f
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Tue Apr 09 20:30:19 2024

Support RemoveSpaceGesture for BTF and BTF2

Bug: 325660505
Test: CoreTextFieldHandwritingGesteureTest BasicTextFieldHandwritingGestureTest
Change-Id: If2960ca05d2e876745692bfa2c1059d50e048750

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/CoreTextFieldHandwritingGestureTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/BasicTextFieldHandwritingGestureTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/EditorInfo.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/HandwritingGesture.android.kt

https://android-review.googlesource.com/3037818

ha...@google.com <ha...@google.com> #11Apr 12, 2024 08:27PM

Marked as fixed.

Mark fixed for 1.7 changes. The remaining InsertModeGesture and gesture previews have separate tracking tickets.

na...@google.com <na...@google.com> #12Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.7.0-alpha07
androidx.compose.foundation:foundation-android:1.7.0-alpha07
androidx.compose.foundation:foundation-desktop:1.7.0-alpha07
androidx.compose.ui:ui:1.7.0-alpha07
androidx.compose.ui:ui-android:1.7.0-alpha07
androidx.compose.ui:ui-desktop:1.7.0-alpha07

ap...@google.com <ap...@google.com> #13Apr 17, 2024 11:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit f57756087a5a8319764d7530c81e52adccadfed0
Author: Justin Ghan <justinghan@google.com>
Date: Wed Apr 17 13:31:21 2024

Helper method for two rectangle range

Bug: 325660505
Test: BasicTextFieldHandwritingGestureTest
Change-Id: I0c74450971eebb01065546000a7d873ac42a2569

M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/HandwritingGesture.android.kt

https://android-review.googlesource.com/3047198