Predictive back transition ends prematurely in Navigation Compose [325998468]

Fixed

Bug

Status Update

No update yet.

Description

ky...@gmail.com

created issue #1

Feb 20, 2024 10:23AM

Component used: Navigation

Version used: 2.8.0-SNAPSHOT

Android versions reproduced on: U

Introduced in https://android-review.googlesource.com/c/platform/frameworks/support/+/2853474

PredictiveBackHandler(currentBackStack.size > 1) { backEvent ->
    inPredictiveBack = true
    progress = 0f
    val currentBackStackEntry = currentBackStack.lastOrNull()
    composeNavigator.prepareForTransition(currentBackStackEntry!!)
    val previousEntry = currentBackStack[currentBackStack.size - 2]
    composeNavigator.prepareForTransition(previousEntry)
    try {
        backEvent.collect {
            progress = it.progress
            logcat("NavHost") { "progress: $progress" }
        }
        inPredictiveBack = false
        composeNavigator.popBackStack(currentBackStackEntry, false)
    } catch (e: CancellationException) {
        inPredictiveBack = false
    }
}

When a regular back is performed, inPredictiveBack will be set to false immediately, causing the AnimatedContent to recompose.

Transition may not complete by the time but will jump to the final state.

Comments

il...@google.com <il...@google.com> #2Feb 22, 2024 12:08AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ky...@gmail.com <ky...@gmail.com> #3Feb 22, 2024 01:48AM

It means back button (in 3-button navigation) or quick gesture (in gesture navigation).

ky...@gmail.com <ky...@gmail.com> #4Feb 22, 2024 02:39AM

It can be reproduced with https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-compose/samples/src/main/java/androidx/navigation/compose/samples/NavigationSamples.kt

navigation.mp4

1.4 MB

Download

jb...@google.com <jb...@google.com> Feb 23, 2024 01:00AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #5Feb 27, 2024 02:23AM

Project: platform/frameworks/support
Branch: androidx-main

commit ba9207cd04a8e832b6bcdd38e39d0084cefba6ec
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Feb 22 20:56:27 2024

Ensure non-gesture Systemback has transition in Compose

When using system back, the NavHost `inPredictiveBack` flag flips from
false to true, starting a predictive back gesture, then back to false
which cancels the started gesture and pushes it to completion. This
result in the incoming destination immediately appearing on the screen
instead of transitioning.

We can fix the system back case, by waiting to get progress before
changing the `inPredictiveBack` flag.

There is still the "flick" case that will remain as it is. What we would
need for that is a way to seek the transition to completion from the
current state.

RelNote: "Fixed an issue where NavHost in Compose Navigation failed to
properly transition when using System back without a gesture."
Test: tested in sample app
Bug: 325998468

Change-Id: Iceeae260189dd12af8cb3fe690523646a90f57de

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/2974195

jb...@google.com <jb...@google.com> #6Feb 28, 2024 04:03AM

Marked as fixed.

The basic system back case has been fixed in Navigation 2.8.0-alpha04, the flick case will likely remain for now as we need some further transition support.

ky...@gmail.com <ky...@gmail.com> #7Feb 28, 2024 04:05AM

Will that be tracked in a separate issue?

jb...@google.com <jb...@google.com> #8Feb 28, 2024 04:12AM

You can follow https://issuetracker.google.com/327292110 for that update.

na...@google.com <na...@google.com> #9Mar 6, 2024 07:49PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-compose:2.8.0-alpha04