Add support for mutable shapes [326070216]

Fixed

Feature Request

Status Update

No update yet.

Description

sg...@google.com

created issue #1

Feb 20, 2024 05:14PM

We would like to have support for Compose Shapes that can have a mutable Outline that can change as a result of a morphing shape.

At this time, we are forced to provide a new Shape with the component API, which means a lot more recompositions.

This sample WIP CL has some changes that Andrey provided before as a quick solution (specifically, the changes around the OutlineResolver, RenderNodeLayer, GraphicsLayerScope, and NodeCoordinator).

Optionally, we can perhaps consider a more targeted solution towards a specific type of shape.

Comments

lp...@google.com <lp...@google.com> #2Feb 20, 2024 05:48PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

nj...@google.com <nj...@google.com> #3Mar 5, 2024 07:08PM

Reassigned to lp...@google.com.

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ap...@google.com <ap...@google.com> #4Apr 24, 2024 04:26PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

lp...@google.com <lp...@google.com> #5Apr 29, 2024 09:07PM

deleted

ap...@google.com <ap...@google.com> #6Apr 30, 2024 04:04PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

ap...@google.com <ap...@google.com> #7Apr 30, 2024 04:04PM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

lp...@google.com <lp...@google.com> #8Apr 30, 2024 04:06PM

Marked as fixed.

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

pr...@google.com <pr...@google.com> #9May 14, 2024 05:21PM

@lo...@gmail.com comment#8

what version of compose are you using? I'm using latest alpha and the above doesn't work for me. 😭