Add support for mutable shapes [326070216]

Fixed

Feature Request

Status Update

No update yet.

Description

sg...@google.com

created issue #1

Feb 20, 2024 05:14PM

We would like to have support for Compose Shapes that can have a mutable Outline that can change as a result of a morphing shape.

At this time, we are forced to provide a new Shape with the component API, which means a lot more recompositions.

This sample WIP CL has some changes that Andrey provided before as a quick solution (specifically, the changes around the OutlineResolver, RenderNodeLayer, GraphicsLayerScope, and NodeCoordinator).

Optionally, we can perhaps consider a more targeted solution towards a specific type of shape.

Comments

lp...@google.com <lp...@google.com> #2Feb 20, 2024 05:48PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

nj...@google.com <nj...@google.com> #3Mar 5, 2024 07:08PM

Reassigned to lp...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ap...@google.com <ap...@google.com> #4Apr 24, 2024 04:26PM

deleted

lp...@google.com <lp...@google.com> #5Apr 29, 2024 09:07PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Apr 30, 2024 04:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2322852111d65e0f10a1a1ec5674807c3eac9334
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Apr 29 18:58:43 2024

Adds support for mutable shapes in Modifier.background

We recently landed support for shapes to be mutable / observable, so callers of createOutline now need to observe state reads inside createOutline.

Bug:

b/326070216

Test: BackgroundTest
Change-Id: Id94fdd7bf92f2df7e825bb58a6af0974d6cd0bd3

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/BackgroundTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Background.kt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/TraverseModifierDemo.kt

https://android-review.googlesource.com/3065423

ap...@google.com <ap...@google.com> #7Apr 30, 2024 04:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0a2d0511e593a900ad5184438b55e7898434053e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Apr 29 21:18:13 2024

Adds tests to Modifier.border for changing shape / mutable shapes

This currently works because we create the outline inside an observable draw scope, so adding tests to ensure that this behavior remains part of the contract, now that shapes can be mutable / observable.

Bug:

b/326070216

Test: BorderTest
Change-Id: I863df052e31efc1b09a1abc4ab43954238ea8ea1

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/BorderTest.kt

https://android-review.googlesource.com/3065842

lp...@google.com <lp...@google.com> #8Apr 30, 2024 04:06PM

Marked as fixed.

Filed separate bugs to track manual usages of createOutline outside of our core APIs, none of these should be high traffic / block ongoing work here though.

pr...@google.com <pr...@google.com> #9May 14, 2024 05:21PM