Assigned
Status Update
No update yet.
Comments
ju...@google.com
The engineering team has identified an issue that is preventing the iframe API from functioning at the moment. They have traced the root cause to a disruption caused by an ongoing server-side push, and once that push is fully complete, the JavaScript errors should completely subside. It will likely be several more hours before the push is complete, unfortunately.
This is not expected to be a regular occurrence, and we apologize for the inconvenience caused by this outage.
This is not expected to be a regular occurrence, and we apologize for the inconvenience caused by this outage.
ju...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 558f17c6f9e237897fcc87fa556ca4af5c1808c6
Author: Julia McClellan <juliamcclellan@google.com>
Date: Thu Sep 19 14:50:25 2024
Add JSpecify to list of Dackka allowed nullness annotations
Test: Compared the output of `./gradlew docs-tip-of-tree:docs` with the current codebase and aosp/3190072, which switches all nullness annotations to jspecify. Only observed changes were updated nullness annotation links and additional copies of some inherited methods when a parent used a different nullness annotation (similar to
Bug: 326456246
Change-Id: I40ede9c84dbae3a1ac7d3d4e98f77a56e119caaa
M buildSrc/private/src/main/kotlin/androidx/build/docs/AndroidXDocsImplPlugin.kt
https://android-review.googlesource.com/3272873
Branch: androidx-main
commit 558f17c6f9e237897fcc87fa556ca4af5c1808c6
Author: Julia McClellan <juliamcclellan@google.com>
Date: Thu Sep 19 14:50:25 2024
Add JSpecify to list of Dackka allowed nullness annotations
Test: Compared the output of `./gradlew docs-tip-of-tree:docs` with the current codebase and aosp/3190072, which switches all nullness annotations to jspecify. Only observed changes were updated nullness annotation links and additional copies of some inherited methods when a parent used a different nullness annotation (similar to
Bug: 326456246
Change-Id: I40ede9c84dbae3a1ac7d3d4e98f77a56e119caaa
M buildSrc/private/src/main/kotlin/androidx/build/docs/AndroidXDocsImplPlugin.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit c8f5025ba9bf1deb5effbebb7e79683ee7ff9f50
Author: Julia McClellan <juliamcclellan@google.com>
Date: Fri Sep 20 12:31:45 2024
Add JSpecify package-list
Bug: 326456246
Test: checking links in output of `./gradlew docs-tip-of-tree:docs` with aosp/3190072 which switches annotations to jspecify
Change-Id: Ic52ecc37cfb84002ba830dfca6186db2dc5bae67
M buildSrc/private/src/main/kotlin/androidx/build/dackka/DackkaTask.kt
A docs-public/package-lists/jspecify/package-list
https://android-review.googlesource.com/3275171
Branch: androidx-main
commit c8f5025ba9bf1deb5effbebb7e79683ee7ff9f50
Author: Julia McClellan <juliamcclellan@google.com>
Date: Fri Sep 20 12:31:45 2024
Add JSpecify package-list
Bug: 326456246
Test: checking links in output of `./gradlew docs-tip-of-tree:docs` with aosp/3190072 which switches annotations to jspecify
Change-Id: Ic52ecc37cfb84002ba830dfca6186db2dc5bae67
M buildSrc/private/src/main/kotlin/androidx/build/dackka/DackkaTask.kt
A docs-public/package-lists/jspecify/package-list
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit b05578cabee04fdccd2f24c7e2d6a8b25b94a97a
Author: Julia McClellan <juliamcclellan@google.com>
Date: Mon Sep 23 11:21:48 2024
Add java format task
Will be used by the jspecify update script
Bug: 326456246
Test: `./gradlew core:core:javaFormat`, `./gradlew core:core:javaFormat --fix-imports-only` to check java diffs. `./gradlew paging:paging-guava:javaFormat` to check the task succeeds for a project with no java files
Change-Id: I6027419d4ad520a4bd82decd009d252b7077d8a6
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
A buildSrc/private/src/main/kotlin/androidx/build/JavaFormat.kt
M gradle/libs.versions.toml
https://android-review.googlesource.com/3277031
Branch: androidx-main
commit b05578cabee04fdccd2f24c7e2d6a8b25b94a97a
Author: Julia McClellan <juliamcclellan@google.com>
Date: Mon Sep 23 11:21:48 2024
Add java format task
Will be used by the jspecify update script
Bug: 326456246
Test: `./gradlew core:core:javaFormat`, `./gradlew core:core:javaFormat --fix-imports-only` to check java diffs. `./gradlew paging:paging-guava:javaFormat` to check the task succeeds for a project with no java files
Change-Id: I6027419d4ad520a4bd82decd009d252b7077d8a6
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
A buildSrc/private/src/main/kotlin/androidx/build/JavaFormat.kt
M gradle/libs.versions.toml
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7d0e9ad06dd1a8372872053b882be71ec2208df7
Author: Julia McClellan <juliamcclellan@google.com>
Date: Fri Sep 20 13:55:03 2024
Add script to migrate projects to JSpecify
This script runs lint to update usage of AndroidX nullness annotations to type-use position, switches the imports to point to JSpecify, and adds a dependency in each build.gradle file.
Bug: 326456246
Test: `development/jspecify_update.py` runs over all projects and created aosp/3190072. Tested `development/jspecify_update.py cursoradapter` to run over a specific directory.
Change-Id: Id0b0620d4d2dd12f88bdd6ece6885b8abb7b7843
A development/jspecify_update.py
https://android-review.googlesource.com/3275093
Branch: androidx-main
commit 7d0e9ad06dd1a8372872053b882be71ec2208df7
Author: Julia McClellan <juliamcclellan@google.com>
Date: Fri Sep 20 13:55:03 2024
Add script to migrate projects to JSpecify
This script runs lint to update usage of AndroidX nullness annotations to type-use position, switches the imports to point to JSpecify, and adds a dependency in each build.gradle file.
Bug: 326456246
Test: `development/jspecify_update.py` runs over all projects and created aosp/3190072. Tested `development/jspecify_update.py cursoradapter` to run over a specific directory.
Change-Id: Id0b0620d4d2dd12f88bdd6ece6885b8abb7b7843
A development/jspecify_update.py
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 619650cc911ddda040d11f5162d6cdd3bcd48b04
Author: Julia McClellan <juliamcclellan@google.com>
Date: Mon Sep 23 11:38:03 2024
Add kotlin compiler args for JSpecify
These arguments make the kotlin compiler enforce correct usage of jspecify nullness annotations. They will become default in language version 2.1 but are needed until then.
Bug: 326456246
Test: Local testing of running `compileKotlin` when using jspecify nullness incorrectly
Change-Id: I635baf825df0e67d489879dcb2e812b3ee3cffb4
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
https://android-review.googlesource.com/3277032
Branch: androidx-main
commit 619650cc911ddda040d11f5162d6cdd3bcd48b04
Author: Julia McClellan <juliamcclellan@google.com>
Date: Mon Sep 23 11:38:03 2024
Add kotlin compiler args for JSpecify
These arguments make the kotlin compiler enforce correct usage of jspecify nullness annotations. They will become default in language version 2.1 but are needed until then.
Bug: 326456246
Test: Local testing of running `compileKotlin` when using jspecify nullness incorrectly
Change-Id: I635baf825df0e67d489879dcb2e812b3ee3cffb4
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Migrate cursoradapter to use JSpecify annotations
Expand for full commit details
Migrate cursoradapter to use JSpecify annotations
CL created by running `development/jspecify_update.py cursoradapter`
This is the first test of switching to JSpecify annotations. cursoradapter was chosen to check that google3 drops go smoothly because:
* Only a few files need updating
* There have been no recent code updates so merge conflicts are unlikely
* There are usages of it in google3
* No other libraries have a tip-of-tree dependency on it
Bug: 326456246
Test: `checkApi`, `lint`, `runErrorProne` for `cursoradapter:cursoradapter`
Relnote: "This library now uses [JSpecify nullness annotations](https://jspecify.dev/), which are type-use. Kotlin developers should use the following compiler arguments to enforce correct usage: -Xjspecify-annotations=strict, -Xtype-enhancement-improvements-strict-mode"
Change-Id: I02c0c11b0cd80d4a725dc78bb1cff0de937927cf
Files:
- M
cursoradapter/cursoradapter/build.gradle - M
cursoradapter/cursoradapter/src/main/java/androidx/cursoradapter/widget/CursorAdapter.java - M
cursoradapter/cursoradapter/src/main/java/androidx/cursoradapter/widget/CursorFilter.java - M
cursoradapter/cursoradapter/src/main/java/androidx/cursoradapter/widget/ResourceCursorAdapter.java - M
cursoradapter/cursoradapter/src/main/java/androidx/cursoradapter/widget/SimpleCursorAdapter.java
Hash: 7be429cb0f283d0ba3f2dfcc3355e7a5eea47a6c
Date: Mon Sep 23 12:09:09 2024
jl...@google.com
It seems
Here is the error we get when trying to roll the commit (
ERROR Unresolved dependencies.
//third_party/androidx:androidx_cursoradapter_cursoradapter_java__classes(//build/toolchain/android:android_clang_arm)
needs //third_party/android_deps:org_jspecify_jspecify_java(//build/toolchain/android:android_clang_arm
Don't really know how to fix this dependency, is this something you've seen somewhere else ?
ju...@google.com
It looks like you need to add JSpecify as a dependency somewhere. I'm not familiar with WebRTC, what are you trying to merge the commit into, and do you know how new dependencies are normally handled? What build system is it using?
To drop the library to g3, we needed to manually add the new dependency to the BUILD file for the library (cl/681488587).
jl...@google.com
what are you trying to merge the commit into
So this is a bit convoluted, the commit got in Chromium with
What build system is it using?
The build system is gn (the same as Chromium).
do you know how new dependencies are normally handled?
Usually new dependencies added in androidx are transparent to WebRTC. I'm actually not sure where the library is defined in the first place.
jl...@google.com
FYI issue is fixed @head (no idea how it got fixed), sorry for the spam.
ju...@google.com
I will be adding the dependency to most other AndroidX libraries, so if this comes up again we can try to figure out what changed -- from looking at the build history, it seems to have switched from the dependency error to a different error later in the build with changes
jl...@google.com
Right, the new error was unrelated (caused by https://chromium-review.googlesource.com/c/chromium/src/+/5901711 ).
When I fixed this one then it just worked ¯\_(ツ)_/¯
> so if this comes up again we can try to figure out what changed
SG, thank you !
When I fixed this one then it just worked ¯\_(ツ)_/¯
> so if this comes up again we can try to figure out what changed
SG, thank you !
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Migrate benchmark to use JSpecify annotations
Expand for full commit details
Migrate benchmark to use JSpecify annotations
CL created by running `development/jspecify_update.py benchmark`
We are updating all AndroidX libraries to use the Jspecify nullness annotations (https://docs.google.com/document/d/1XjainD032hUdCfgXIzRThHvP9FJANYuocKaTDXWuLXo/edit?usp=sharing)
Bug: 326456246
Test: `checkApi`, `lint`, `runErrorProne`
Relnote: "This library now uses [JSpecify nullness annotations](https://jspecify.dev/), which are type-use. Kotlin developers should use the following compiler arguments to enforce correct usage: -Xjspecify-annotations=strict, -Xtype-enhancement-improvements-strict-mode"
Change-Id: I7104f0ca68a72a7e996b79f1609cde685e6c61e6
Files:
- M
benchmark/benchmark-common/build.gradle - M
benchmark/benchmark-common/src/main/java/androidx/benchmark/simpleperf/ProfileSession.java - M
benchmark/benchmark-common/src/main/java/androidx/benchmark/simpleperf/RecordOptions.java - M
benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/ByteBufferUtil.java - M
benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/MethodInfo.java - M
benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/VmTraceHandler.java - M
benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/VmTraceParser.java - M
benchmark/benchmark-macro/build.gradle - M
benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/JankCollectionHelper.java
Hash: aa1b06262eb961422573cf16839740a2b1ed232d
Date: Wed Oct 09 09:55:35 2024
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Migrate dynamicanimation to use JSpecify annotations
Expand for full commit details
Migrate dynamicanimation to use JSpecify annotations
CL created by running `development/jspecify_update.py dynamicanimation`
We are updating all AndroidX libraries to use the Jspecify nullness annotations (https://docs.google.com/document/d/1XjainD032hUdCfgXIzRThHvP9FJANYuocKaTDXWuLXo/edit?usp=sharing)
Bug: 326456246
Test: `checkApi`, `lint`, `runErrorProne`
Relnote: "This library now uses [JSpecify nullness annotations](https://jspecify.dev/), which are type-use. Kotlin developers should use the following compiler arguments to enforce correct usage: -Xjspecify-annotations=strict, -Xtype-enhancement-improvements-strict-mode"
Change-Id: I707835de5ef50bb485fbb79d26600153ca22f6e2
Files:
- M
dynamicanimation/dynamicanimation/build.gradle - M
dynamicanimation/dynamicanimation/src/androidTest/java/androidx/dynamicanimation/tests/SpringTests.java - M
dynamicanimation/dynamicanimation/src/main/java/androidx/dynamicanimation/animation/AnimationHandler.java - M
dynamicanimation/dynamicanimation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java - M
dynamicanimation/dynamicanimation/src/main/java/androidx/dynamicanimation/animation/FrameCallbackScheduler.java
Hash: 6d164f6b510ed6296644c50473eae909e7842c4d
Date: Wed Oct 09 13:12:26 2024
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Migrate appcompat to use JSpecify annotations
Expand for full commit details
Migrate appcompat to use JSpecify annotations
CL created by running `development/jspecify_update.py appcompat`
We are updating all AndroidX libraries to use the Jspecify nullness annotations (https://docs.google.com/document/d/1XjainD032hUdCfgXIzRThHvP9FJANYuocKaTDXWuLXo/edit?usp=sharing)
Bug: 326456246
Test: `checkApi`, `lint`, `runErrorProne`
Relnote: "This library now uses [JSpecify nullness annotations](https://jspecify.dev/), which are type-use. Kotlin developers should use the following compiler arguments to enforce correct usage: -Xjspecify-annotations=strict, -Xtype-enhancement-improvements-strict-mode"
Change-Id: Ifdbade99c3de977d8c7e99dfac3858e516a914f7
Files:
- M
appcompat/appcompat-lint/integration-tests/build.gradle - M
appcompat/appcompat-lint/integration-tests/src/main/java/com/example/android/appcompat/ActivityWithClick.java - M
appcompat/appcompat-resources/build.gradle - M
appcompat/appcompat-resources/src/androidTest/java/androidx/appcompat/widget/TestResources.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/content/res/AppCompatResources.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/AnimatedStateListDrawableCompat.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableContainerCompat.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableWrapperCompat.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/StateListDrawableCompat.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/resources/Compatibility.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/DrawableUtils.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/ResourceManagerInternal.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/TintContextWrapper.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/TintResources.java - M
appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/VectorEnabledTintResources.java - M
appcompat/appcompat/build.gradle - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/AppCompatDialogFragmentTest.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/AppCompatMenuItemIconTintingTest.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/BaseBasicsTestCase.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/CustomCollapsibleView.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/FragmentContentIdActivity.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/LocalesUpdateActivity.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeActivity.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/TestDialogFragment.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/g3/FilternatorActivity.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/g3/FilternatorActivityWithCustomDefault.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/g3/OldTranslateActivity.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/inflater/CustomViewInflater.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/inflater/MisbehavingViewInflater.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/testutils/BaseTestActivity.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/testutils/DrawerLayoutActions.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/testutils/TestUtils.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatAutoCompleteTextViewEmojiTest.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatBaseImageViewTest.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatBaseViewTest.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextReceiveContentTest.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatMultiAutoCompleteTextViewEmojiTest.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatTextViewAutoSizeTest.java - M
appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/ToolbarTestActivity.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/ActionBar.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/ActionBarDrawerToggle.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AlertController.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AlertDialog.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatActivity.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatCallback.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegate.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegateImpl.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDialog.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDialogFragment.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatViewInflater.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/AppLocalesMetadataHolderService.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/LayoutIncludeDetector.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/ResourcesFlusher.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/ToolbarActionBar.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/TwilightManager.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/app/WindowDecorActionBar.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/graphics/drawable/DrawerArrowDrawable.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/StandaloneActionMode.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/ActionMenuItem.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/CascadingMenuPopup.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/MenuBuilder.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/MenuDialogHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/MenuItemImpl.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/MenuItemWrapperICS.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/MenuPopup.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/MenuPopupHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/MenuPresenter.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/view/menu/SubMenuBuilder.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AbsActionBarView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ActionBarBackgroundDrawable.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ActionBarContainer.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ActionBarContextView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ActionBarOverlayLayout.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ActionMenuPresenter.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ActionMenuView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ActivityChooserView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AlertDialogLayout.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatAutoCompleteTextView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatBackgroundHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatButton.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatCheckBox.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatCheckedTextView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatCheckedTextViewHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatCompoundButtonHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatDrawableManager.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEditText.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiEditTextHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEmojiTextHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatImageButton.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatImageHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatImageView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatMultiAutoCompleteTextView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatPopupWindow.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatRadioButton.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatRatingBar.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatReceiveContentHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatSeekBar.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatSeekBarHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatSpinner.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextClassifierHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextViewAutoSizeHelper.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatToggleButton.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ButtonBarLayout.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ContentFrameLayout.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/DialogTitle.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/DropDownListView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/FitWindowsFrameLayout.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/FitWindowsLinearLayout.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/LinearLayoutCompat.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ListPopupWindow.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/MenuItemHoverListener.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/MenuPopupWindow.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/PopupMenu.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ScrollingTabContainerView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/SearchView.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/SwitchCompat.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ThemeUtils.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ThemedSpinnerAdapter.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/TintTypedArray.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/Toolbar.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/TooltipCompat.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/TooltipPopup.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ViewStubCompat.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/ViewUtils.java - M
appcompat/appcompat/src/main/java/androidx/appcompat/widget/WithHint.java - M
appcompat/integration-tests/receive-content-testapp/build.gradle - M
appcompat/integration-tests/receive-content-testapp/src/main/java/androidx/appcompat/demo/receivecontent/AttachmentsRecyclerViewAdapter.java - M
appcompat/integration-tests/receive-content-testapp/src/main/java/androidx/appcompat/demo/receivecontent/AttachmentsRepo.java - M
appcompat/integration-tests/receive-content-testapp/src/main/java/androidx/appcompat/demo/receivecontent/MainActivity.java - M
appcompat/integration-tests/receive-content-testapp/src/main/java/androidx/appcompat/demo/receivecontent/MyExecutors.java - M
appcompat/integration-tests/receive-content-testapp/src/main/java/androidx/appcompat/demo/receivecontent/MyReceiver.java
Hash: 2fe0f867b44f83c71ff0dbe3ec31d510f394ae86
Date: Wed Oct 09 11:37:32 2024
ap...@google.com
I'm going to leave this bug open until we can confirm that this is resolved, but I wanted to update folks: The push is very close to completion. Could a few folks test again (in an Incognito window or after clearing browser cache, ideally) and let us know if you're seeing the expected functionality? Things are currently working for me at https://developers.google.com/youtube/youtube_player_demo for instance.
ap...@google.com
Thanks for the update
We are seeing functions like playVideo() and pauseVideo() working now, however we are not getting callbacks from the "onStateChange" event
We are seeing functions like playVideo() and pauseVideo() working now, however we are not getting callbacks from the "onStateChange" event
so...@gmail.com
The player issue with loadVideoById appears to be fixed.
However the player is now not calling onStateChange for any events! Shall I file a new issue about this?
However the player is now not calling onStateChange for any events! Shall I file a new issue about this?
ap...@google.com
Rather than completely erroring out, my app is now improved but not back to expected/normal functionality. In particular, videos are playing again but my custom controls aren't noticing that playback has started, so I'm guessing some player events aren't quite firing right? Looking into it.
ap...@google.com
Same here, no state change events fired.
ap...@google.com
onStateChange has been broken the whole time, even though it wasn't mentioned in the issue report..
ap...@google.com
It was mentioned in some of the many other tickets that were merged into this ticket.
ap...@google.com
[Comment deleted]
ap...@google.com
Hi there was a code break, then it was removed just now but now events are still not working. Playback can begin with playVideo but no statechange event is working.
ap...@google.com
Thanks for responding.
It sounds like the issue with JavaScript execution errors ("Array.prototype.forEach called on null or undefined") is resolved following the push, but there's still an outstanding issue with the onStateChange() handler not being properly invoked.
The Players API engineering team is aware of that issue as well and is working on a resolution—at this time, it's not clear whether the fix for onStateChange() will be pushed out tonight (June 12) or if it will be pushed out tomorrow.
I'm going to leave this issue open to track the resolution of onStateChange() not firing.
It sounds like the issue with JavaScript execution errors ("Array.prototype.forEach called on null or undefined") is resolved following the push, but there's still an outstanding issue with the onStateChange() handler not being properly invoked.
The Players API engineering team is aware of that issue as well and is working on a resolution—at this time, it's not clear whether the fix for onStateChange() will be pushed out tonight (June 12) or if it will be pushed out tomorrow.
I'm going to leave this issue open to track the resolution of onStateChange() not firing.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Migrate concurrent-futures to use JSpecify annotations
Expand for full commit details
Migrate concurrent-futures to use JSpecify annotations
CL created by running `development/jspecify_update.py concurrent`
We are updating all AndroidX libraries to use the Jspecify nullness annotations (https://docs.google.com/document/d/1XjainD032hUdCfgXIzRThHvP9FJANYuocKaTDXWuLXo/edit?usp=sharing)
Bug: 326456246
Test: `checkApi`, `lint`, `runErrorProne`
Relnote: "This library now uses [JSpecify nullness annotations](https://jspecify.dev/), which are type-use. Kotlin developers should use the following compiler arguments to enforce correct usage: -Xjspecify-annotations=strict, -Xtype-enhancement-improvements-strict-mode"
Change-Id: I0faf40c26ac0d0e45f1e549ef2c4d04df653d2f3
Files:
- M
concurrent/concurrent-futures/build.gradle - M
concurrent/concurrent-futures/src/main/java/androidx/concurrent/futures/AbstractResolvableFuture.java - M
concurrent/concurrent-futures/src/main/java/androidx/concurrent/futures/CallbackToFutureAdapter.java - M
concurrent/concurrent-futures/src/main/java/androidx/concurrent/futures/ResolvableFuture.java - M
concurrent/concurrent-futures/src/test/java/androidx/concurrent/futures/AbstractResolvableFutureTest.java
Hash: acfceda440b2788ea7c425e11414f57ad0a9ba4d
Date: Mon Sep 30 15:21:50 2024
ap...@google.com
There is a workaround for those who need an immediate fix: calling
addEventListener('onStateChange', callbackFunction)
on the YT.Player object *after* the onReady callback has been invoked should mimic the broken functionality. There's a working example athttp://jsfiddle.net/jeffposnick/yhWsG/3/
That being said, supplying the onStateChange callback as part of the events object in the YT.Player constructor will start working again as soon as the fix is deployed.
addEventListener('onStateChange', callbackFunction)
on the YT.Player object *after* the onReady callback has been invoked should mimic the broken functionality. There's a working example at
That being said, supplying the onStateChange callback as part of the events object in the YT.Player constructor will start working again as soon as the fix is deployed.
ap...@google.com
I've tested on many browsers and from my perspective the issue was resolved around 5:00pm PST. I was in the middle of a record traffic day, so, THANKS YT TEAM!!!!
ap...@google.com
Thanks for the workaround - that seems to be working.
ap...@google.com
Are you sure, is onStateChange callback woking???. My end, it seems not working..
ap...@google.com
Yes, the workaround works.
ap...@google.com
The workaround does not seems to work either on our side. The error is now solved so we are getting the last version.
ap...@google.com
[Comment deleted]
ap...@google.com
I have a mobile app which uses the iframe API. In addition to the onStateChange no firing, I'm also experiencing problems with the Flash version not playing at all if the browser doesn't support HTML5. The video thumbnail displays properly and when tapped, the spinner spins for a few seconds and then just stops without playback.
ap...@google.com
...and I can also report that the onStateChange workaround on the player object, posted above, doesn't work for me either.
ap...@google.com
PlayerState is not working, maybe we're late here in Europe ?
still have an issue on www-widgetapi-vflwt8QCF.js:22
still have an issue on www-widgetapi-vflwt8QCF.js:22
ap...@google.com
I confirm that we have this issue both on the PT timezone than the GMT time zone. This cause any html5 video player and embedded html5 video players to break. Please fix.
ap...@google.com
[UPDATE] 00.58 PT the issue is not fixed yet. The workaround seems to works. Just set the event listener for 'onStateChange' after the 'onReady' method.
ap...@google.com
The workaround works - in my case after I made sure to configure *only* the onReady attribute in the "events" object, exactly as in the Fiddle.
Question to Youtube: will this workaround work after you finalize the fix? Should the code change be permanent? And as a side note: This is a catastrophic bug in your recommended embedding code..... I'm frankly stunned that the most basic testing was not done prior to your code upgrade. I was lucky to be pre-launch on my site........
Question to Youtube: will this workaround work after you finalize the fix? Should the code change be permanent? And as a side note: This is a catastrophic bug in your recommended embedding code..... I'm frankly stunned that the most basic testing was not done prior to your code upgrade. I was lucky to be pre-launch on my site........
ap...@google.com
I agree. This caused us a severe crash in the embedded video player and potentially it just destroy any embedded html5 video player preventing to work.
I assume that patching the "onstatechange" with the workaround it should not cause problems when the fix is done, since it's javascript, you are just overwriting the event handler for the same event, but at two different times.
I assume that patching the "onstatechange" with the workaround it should not cause problems when the fix is done, since it's javascript, you are just overwriting the event handler for the same event, but at two different times.
ap...@google.com
The addEventListener workaround doesn't work for everyone. With the workaround you'll miss the UNSTARTED player state. In my case, my code (currently) depends on seeing that event.
ap...@google.com
I can confirm that I finally got the workaround to work (thanks to
ap...@google.com
The iframe API still doesn't serve Flash video in mobile browsers (Android) that have Flash installed and don't support HTML5. As I wrote earlier, the video thumbnail displays properly and when tapped, the spinner spins for a few seconds and then just stops without playback.
It's been working flawlessly for months up until this whole iframe-API issue started.
It's been working flawlessly for months up until this whole iframe-API issue started.
ap...@google.com
For me it's not working console.log("onStateChange has fired!\nNew state:" + event.data); is totally empty
ap...@google.com
Here an example which I use and doesn't work anymore
http://jsfiddle.net/YzvXa/197/
ap...@google.com
onStateChange not working for me either.
ap...@google.com
Come on Google, how hard is it to tweak a line or two of JS.
ap...@google.com
@#52/da...@torchbox.com
You obviously never deployed to hundreds of servers and/or to millions (and even billions) of clients.
You obviously never deployed to hundreds of servers and/or to millions (and even billions) of clients.
ap...@google.com
"You obviously never deployed to hundreds of servers and/or to millions (and even billions) of clients."
Uhm...fix the text javascript file, upload to cdn. Wait 24-48h. What else?
Uhm...fix the text javascript file, upload to cdn. Wait 24-48h. What else?
ap...@google.com
onStateChange not working for me over here.
ap...@google.com
onStateChange still not working, but the fix #31 luckily does
ap...@google.com
onStateChange still not working in Cambodia...
ap...@google.com
Haven't seen anybody mention this: the onPlaybackRateChange callback isn't working either.
ap...@google.com
onStateChange still not working !!!!!
ap...@google.com
I, too, continue to experience issues with the API.
I do have a question, though. It would appear that most problems have transitioned to onStateChange not firing. I continue to receive the following error:
"Uncaught TypeError: Array.prototype.forEach called on null or undefined "
My understanding is that this issue was resolved yesterday. I'm wondering how I can get my extension to "move on" to the next error. I have wiped my settings back to the start of time, uninstalled/reinstalled the extension and unpublished/published from the web store.
Are there any other course of actions I should be taking?
I do have a question, though. It would appear that most problems have transitioned to onStateChange not firing. I continue to receive the following error:
"Uncaught TypeError: Array.prototype.forEach called on null or undefined "
My understanding is that this issue was resolved yesterday. I'm wondering how I can get my extension to "move on" to the next error. I have wiped my settings back to the start of time, uninstalled/reinstalled the extension and unpublished/published from the web store.
Are there any other course of actions I should be taking?
ap...@google.com
The workaround did not work for me. But I was able to find a solution by periodically polling 'getPlayerState()'. If you're going to try that, remember not to set up polling until 'onReady', because 'getPlayerState' won't exist before that event fires.
ap...@google.com
If you're trying the workaround and it's not working, make sure you've commented out the previous 'onStateChange' event that was already in your code
ap...@google.com
Just to make a quick point here, about 20 hours after this outage started... Google encourages people to build entire products around their YouTube APIs -- as we have done.
I think if they want anybody to actually build a product largely based around YouTube APIs, they need to move the standard of maintenance and uptime higher. Our product has been unusable for the last 20 hours. If this were any other of our critical infrastructure providers (AWS, Heroku, MongoHQ, etc.) this would be a huge deal: they would be in panic mode and updating us as much as possible as they rushed to a solution. Instead we get this. And this isn't the first time this has happened... the last Player API outage, which I reported, was only a couple of months ago.
Of course Google provides this service for free, and I'm glad for that. But it's difficult to build a site on a service that seems to place little priority on availability. If that involved paying a small fee for a version of the Player API that stayed up, I think it would be a no-brainer for us. For now we will continue to diversify our video source options, but I hope in the future we will be able to trust the YouTube APIs to stay available.
I think if they want anybody to actually build a product largely based around YouTube APIs, they need to move the standard of maintenance and uptime higher. Our product has been unusable for the last 20 hours. If this were any other of our critical infrastructure providers (AWS, Heroku, MongoHQ, etc.) this would be a huge deal: they would be in panic mode and updating us as much as possible as they rushed to a solution. Instead we get this. And this isn't the first time this has happened... the last Player API outage, which I reported, was only a couple of months ago.
Of course Google provides this service for free, and I'm glad for that. But it's difficult to build a site on a service that seems to place little priority on availability. If that involved paying a small fee for a version of the Player API that stayed up, I think it would be a no-brainer for us. For now we will continue to diversify our video source options, but I hope in the future we will be able to trust the YouTube APIs to stay available.
ap...@google.com
First of all, I just want to acknowledge the gigantic task that the YouTube team is up against with thousands of servers and 1 billion users. It's definitely no easy technical challenge.
Second, given the enormity of YouTube and the ecosystem of 3rd party developers relying and making a living on YouTube's platform, I'm thinking about what steps could be taken to improve the deployment process for everyone and reduce the occurance of crisis situations like this one in the future.
(Our app has more than a million users and we get a lot of angry users each time this happens, and I've had to wake up my team members at 3am in Asia twice in the last 30 days to handle the sudden crises, which are causing a lot strains internally)
Here are my two cents about possible process improvements, and I hope other with more experience than I do can weigh in as well with better ideas:
1. STAGING SITE URL
Instead of deploying new code directly to the live site, make new code pushes available at a staging URL one week in advance, before deploying to live site. This will give us 3rd-party developers at least one week's buffer time to test our app compatibility and help debug if necessary, instead of finding out AFTER the fact when our apps break.
2. AUTO-TEST SCRIPTS
I'm pretty sure there'd be something in place already, but somehow it didn't catch the full javascript breakdown earlier on yesterday, and then even after it was supposedly fixed, we then realize that onStateChange doesn't work. If an auto-test script can be incorporated into the deployment process to test each server after code-push before bringing it live into the server fleet, we can prevent future crises like this one.
Just my two cents.
John.
Second, given the enormity of YouTube and the ecosystem of 3rd party developers relying and making a living on YouTube's platform, I'm thinking about what steps could be taken to improve the deployment process for everyone and reduce the occurance of crisis situations like this one in the future.
(Our app has more than a million users and we get a lot of angry users each time this happens, and I've had to wake up my team members at 3am in Asia twice in the last 30 days to handle the sudden crises, which are causing a lot strains internally)
Here are my two cents about possible process improvements, and I hope other with more experience than I do can weigh in as well with better ideas:
1. STAGING SITE URL
Instead of deploying new code directly to the live site, make new code pushes available at a staging URL one week in advance, before deploying to live site. This will give us 3rd-party developers at least one week's buffer time to test our app compatibility and help debug if necessary, instead of finding out AFTER the fact when our apps break.
2. AUTO-TEST SCRIPTS
I'm pretty sure there'd be something in place already, but somehow it didn't catch the full javascript breakdown earlier on yesterday, and then even after it was supposedly fixed, we then realize that onStateChange doesn't work. If an auto-test script can be incorporated into the deployment process to test each server after code-push before bringing it live into the server fleet, we can prevent future crises like this one.
Just my two cents.
John.
ap...@google.com
We're also not seeing onStateChange working.
ap...@google.com
Hi,
Someone have posted a fix that work for me. It is based on polling like someone has suggested before.
Here is a sample that you can use (to set after onPlayerReady has been called):
setInterval( function
() {
var state = player.getPlayerState();
if ( playerState !== state ) {
onPlayerStateChange( {
data: state
} );
}
}, 10 );
Someone have posted a fix that work for me. It is based on polling like someone has suggested before.
Here is a sample that you can use (to set after onPlayerReady has been called):
setInterval( function
() {
var state = player.getPlayerState();
if ( playerState !== state ) {
onPlayerStateChange( {
data: state
} );
}
}, 10 );
ap...@google.com
The lack of proper eventing is still causing tons of trouble for our app -- any ETA on a fix, Googlers?
ap...@google.com
onError is not firing either - just thought I'd let you know. Manually adding an event listener will fix this same as onStateChange.
ap...@google.com
onStateChange is still not firing for me either. Having lots of complaints about it with my product - can we expecta fix anytime soon?
ap...@google.com
The code to restore the previous onStateChange behavior is underway, and should be complete within the next few hours.
Apologies again for the breakage that this caused. Folks should probably hold off on implementing any workarounds at this point, since the restoration of the old, documented behavior is imminent.
If you have already changed you code to, say, explicitly call addEventListener(), that *should* continue to work, but I'd recommend switching things back to the original approach, as it's cleaner.
Apologies again for the breakage that this caused. Folks should probably hold off on implementing any workarounds at this point, since the restoration of the old, documented behavior is imminent.
If you have already changed you code to, say, explicitly call addEventListener(), that *should* continue to work, but I'd recommend switching things back to the original approach, as it's cleaner.
ap...@google.com
Jeff Posnick posted a temporary workaround here:
Basically, you just need to add the event listener within the onReady event (just a temporary fix):
function onReady() {
player.addEventListener('onStateChange', function(e) {
console.log('State is:', e.data);
});
}
ap...@google.com
I confirm now that on the PT the onStateChange now works again. 8 hours debugging. 2 hours updating the cdn with the hot fix. Now back. Very funny.
ap...@google.com
+1 to apps that were all but unusable for almost 24 hours. Will be very glad when all the serving CDN endpoints are updated.
I'm curious about this: Was this handled as high priority? My gut tells me that if it were Ads that weren't working (in embeds), it would have been resolved by now. Perhaps even by rolling back the breaking changes and re-pushing when ready (bug-free). Am I too much of a cynic?
I'm curious about this: Was this handled as high priority? My gut tells me that if it were Ads that weren't working (in embeds), it would have been resolved by now. Perhaps even by rolling back the breaking changes and re-pushing when ready (bug-free). Am I too much of a cynic?
ap...@google.com
Can you confirm that a fix is being rolled out soon?
ap...@google.com
onReady and onStateChange are still not working for us.
ap...@google.com
Still not working for us too.
We have an iPhone/iPad app so there is no option for workarounds.
We have an iPhone/iPad app so there is no option for workarounds.
ap...@google.com
[Comment deleted]
ap...@google.com
ap...@google.com
Fix #31 and 71, thank you guys for the workaround.
ap...@google.com
confirmed that onStateChange is working!
ap...@google.com
Glad to hear that some folks have already confirmed that the previous onStateChange syntax is working agian.
My understanding is that the push isn't globally complete yet, so your continued patience is appreciated. Testing in an Incognito window or after clearing your browser cache is also a good idea.
My understanding is that the push isn't globally complete yet, so your continued patience is appreciated. Testing in an Incognito window or after clearing your browser cache is also a good idea.
ap...@google.com
On the iphone/ipad what you can do is to force the javascript to call that function from the objectiveC code ;) It works I tried.
ap...@google.com
Okay, I'm told that the push is complete. Please allow for some additional time for browser caches to clear (unless you're testing with a clean cache). I just confirmed that assigning an onStateChange handler in the documented fashion is working again, and others are reporting the same thing. I'm going to mark this as Fixed.
If there's anyone who was seeing any issue unrelated to onStateChange handlers and can still reproduce it, I'd ask that you please open a new bug so that we can track that independently. Thanks, and apologies again.
If there's anyone who was seeing any issue unrelated to onStateChange handlers and can still reproduce it, I'd ask that you please open a new bug so that we can track that independently. Thanks, and apologies again.
ap...@google.com
Neither onReady nor onStateChange is working for me in Firefox
ap...@google.com
Sorry but 'onStateChange' is not working to me. I'm based in the UK.
ap...@google.com
I just cleared cache and tried it out, onStateChange did fire for me.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Migrate camera integration tests to use JSpecify annotations
Expand for full commit details
Migrate camera integration tests to use JSpecify annotations
CL created by running `development/jspecify_update.py camera/integration-tests`
We are updating all AndroidX libraries to use the Jspecify nullness annotations (https://docs.google.com/document/d/1XjainD032hUdCfgXIzRThHvP9FJANYuocKaTDXWuLXo/edit?usp=sharing)
Bug: 326456246
Test: `checkApi`, `lint`, `runErrorProne`
Change-Id: Ic5e69ed1890481f708f5577f48fe27b0c03d4a24
Files:
- M
camera/integration-tests/coretestapp/build.gradle - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraPipeActivity.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXActivity.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXService.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXViewModel.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/ConcurrentCameraActivity.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/OpenGLActivity.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/OpenGLRenderer.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/ServiceSettingActivity.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/SingleThreadHandlerExecutor.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/SurfaceViewRenderSurface.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/TextureViewRenderSurface.java - M
camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/VideoCameraSwitchingActivity.java - M
camera/integration-tests/coretestapp/src/test/java/androidx/camera/integration/core/FpsRecorderTest.java - M
camera/integration-tests/extensionstestapp/build.gradle - M
camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/CameraExtensionsActivity.java - M
camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/ExtensionsApplication.java - M
camera/integration-tests/viewtestapp/build.gradle - M
camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/BlurBitmap.java - M
camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/CameraControllerFragment.java - M
camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/MainActivity.java - M
camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/OverlayView.java - M
camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/PreviewViewFragment.java - M
camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/PreviewViewScaleTypePresenter.java - M
camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/TransformFragment.java
Hash: dd78f1e8a7a130b86d4e608380cf9dcbb61ba22a
Date: Fri Dec 06 09:06:47 2024
ap...@google.com
Is this issue considered resolved? It appears to me to not be working completely -service is quite a bit slower and 'onStateChange' isn't received as reliably as before this issue. In particular, it isn't fired when I play the first song of a playlist, but usually (not always) is fired as it moves to new items in the list.
ap...@google.com
I have to confirm some of Michael Stephenson's findings. With the current behavior, there is no onStateChange({data: -1 /* UNSTARTED */}) event prior to the onReady event.
ap...@google.com
In the Delphi TWebbrowser and TEmbeddedWB components, playing of Youtube videos with the Youtube embed code always worked until one week ago or so. Now only a black screen is displayed. For example:
<iframe width="640" height="360" src="https://www.youtube.com/embed/LJnSWOHcS58?feature=player_detailpage " frameborder="0" allowfullscreen></iframe>
Loading this in the Delphi TWebbrowser and TEmbeddedWB components now does not work anymore!
See also here:http://goo.gl/R3eyR
<iframe width="640" height="360" src="
Loading this in the Delphi TWebbrowser and TEmbeddedWB components now does not work anymore!
See also here:
ap...@google.com
Hey, guys.
Our company is dependent on this missing event data for billing its advertiser-clients.
Do you know where we might get an official description/explanation that we might send our clients so that the client knows that 1) this was on the YT end, not our error and 2) all entities accessing the issue via this API were affected the same way?
I just don't want to have a June invoice payment collection problem because we were without data for a 24-period. We've got as much as 3% of our June revenue at risk.
Thanks very much.
Our company is dependent on this missing event data for billing its advertiser-clients.
Do you know where we might get an official description/explanation that we might send our clients so that the client knows that 1) this was on the YT end, not our error and 2) all entities accessing the issue via this API were affected the same way?
I just don't want to have a June invoice payment collection problem because we were without data for a 24-period. We've got as much as 3% of our June revenue at risk.
Thanks very much.
ap...@google.com
This still seems to be an issue are you viewing it as resolved? I can still recreate it on Chrome and Safari even after clearing the browser cache. Basically the onstatechange is not firing regardless if whether I wire it during the player initialization or if I try to attach an event via the onready event.
ap...@google.com
Here in Spain the problem still persists, however I discovered a clean workaround:
player = new YT.Player(element,{
events: {
onReady: function(){
/*
Do your stuff
*/
// Attach a void function to the event
player.addEventListener('onStateChange',function(){});
},
onStateChange: function(){
// Actual function that gets executed during the event
}
}
});
player = new YT.Player(element,{
events: {
onReady: function(){
/*
Do your stuff
*/
// Attach a void function to the event
player.addEventListener('onStateChange',function(){});
},
onStateChange: function(){
// Actual function that gets executed during the event
}
}
});
ap...@google.com
hi manolova ,
i used your code ,it is clean workaround.. Thank you..!
i used your code ,it is clean workaround.. Thank you..!
ap...@google.com
In Toronto, onStateChanged was fixed for a week or so but is now broken again.
ap...@google.com
ey...@gmail.com
Still not working on Brazil, Sorocaba. Not even OnReady event
cp...@google.com
[Comment deleted]
cp...@google.com
Not working in Quebec, CANADA. onStateChange disabled.
ju...@google.com
Not working in Buenos Aires, Argentina. Workarounds suggested in previous comments not helping so far. (not very experienced myself, so I might be missing something)
ap...@google.com
To the people reporting issues - to verify it's actually Google's issues and not yours, check if the demos work correctly: https://developers.google.com/youtube/youtube_player_demo
Pick the IFrame player, and as you pause/play the video you should see events being updated on the page, if all is well.
Pick the IFrame player, and as you pause/play the video you should see events being updated on the page, if all is well.
ap...@google.com
I'd ask that folks seeing currents issues somewhat related to YouTube Player API events file separate bugs with a concrete description of what you're seeing and specific steps to reproduce. Some of what people have recently mentioned in this bug sounds like it's covered by https://code.google.com/p/gdata-issues/issues/detail?id=4778 for instance.
ap...@google.com
Not working in San Francisco, California.
I am testing with the example given in the YouTube Player API Reference at:
https://developers.google.com/youtube/iframe_api_reference
In the example, there is an embedded YouTube player that is supposed to load a video, play that video, and then stop after 6 seconds.
=== On Safari 6.0.5 ===
The player loads.
onYouTubeIframeAPIReady is called.
Then I see these 3 errors:
1) Unable to post message tohttp://www.youtube.com . Recipient has origin https://www.youtube.com .
2) Unsafe JavaScript attempt to access frame with URL file:///Users/inieves/Desktop/test.html from frame with URLhttps://www.youtube.com/embed/M7lc1UVf-VE?enablejsapi=1 . Domains, protocols and ports must match.
3) Unable to post message tohttp://www.youtube.com . Recipient has origin https://www.youtube.com .
And the 3rd error continues on and on... The counter next to the line is reading out that the error has occurred about 500 times and is _still_ occurring.
onReady event handler is never called.
===On Chrome 27.0.1453.116 ===
The player loads.
onYouTubeIframeAPIReady is called.
Then I see this error:
1) Blocked a frame with origin "http://www.youtube.com " from accessing a frame with origin "null". The frame requesting access has a protocol of "http", the frame being accessed has a protocol of "file". Protocols must match.
onReady event handler is never called.
==On Firefox 21.0===
The player loads.
onYouTubeAPIReady is called.
onReady event handler IS CALLED!!
The video starts to play...he v
And then about 5 seconds later the onStateChange handler tells me that the video state is (-1) UNSTARTED and then it is (5) QUEUED.
And then the video just stops playing.
I can see in the console log that early on there is an error: "TypeError: Value not an object."
I am testing with the example given in the YouTube Player API Reference at:
In the example, there is an embedded YouTube player that is supposed to load a video, play that video, and then stop after 6 seconds.
=== On Safari 6.0.5 ===
The player loads.
onYouTubeIframeAPIReady is called.
Then I see these 3 errors:
1) Unable to post message to
2) Unsafe JavaScript attempt to access frame with URL file:///Users/inieves/Desktop/test.html from frame with URL
3) Unable to post message to
And the 3rd error continues on and on... The counter next to the line is reading out that the error has occurred about 500 times and is _still_ occurring.
onReady event handler is never called.
===On Chrome 27.0.1453.116 ===
The player loads.
onYouTubeIframeAPIReady is called.
Then I see this error:
1) Blocked a frame with origin "
onReady event handler is never called.
==On Firefox 21.0===
The player loads.
onYouTubeAPIReady is called.
onReady event handler IS CALLED!!
The video starts to play...he v
And then about 5 seconds later the onStateChange handler tells me that the video state is (-1) UNSTARTED and then it is (5) QUEUED.
And then the video just stops playing.
I can see in the console log that early on there is an error: "TypeError: Value not an object."
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Migrate leanback to use JSpecify annotations
Expand for full commit details
Migrate leanback to use JSpecify annotations
CL created by running `development/jspecify_update.py leanback`
We are updating all AndroidX libraries to use the Jspecify nullness annotations (https://docs.google.com/document/d/1XjainD032hUdCfgXIzRThHvP9FJANYuocKaTDXWuLXo/edit?usp=sharing)
Bug: 326456246
Test: `checkApi`, `lint`, `runErrorProne`
Relnote: "This library now uses [JSpecify nullness annotations](https://jspecify.dev/), which are type-use. Kotlin developers should use the following compiler arguments to enforce correct usage: -Xjspecify-annotations=strict, -Xtype-enhancement-improvements-strict-mode"
Change-Id: I5fdf1b885691c47b120b3b2f100213f9cb090eb3
Files:
- M
leanback/leanback-grid/build.gradle - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/BaseGridView.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/FacetProvider.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/FacetProviderAdapter.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/Grid.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/GridLayoutManager.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/HorizontalGridView.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/ItemAlignmentFacet.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/OnChildLaidOutListener.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/OnChildSelectedListener.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/OnChildViewHolderSelectedListener.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/SingleRow.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/VerticalGridView.java - M
leanback/leanback-grid/src/main/java/androidx/leanback/widget/ViewHolderTask.java - M
leanback/leanback-preference/build.gradle - M
leanback/leanback-preference/src/main/java/androidx/leanback/preference/BaseLeanbackPreferenceFragmentCompat.java - M
leanback/leanback-preference/src/main/java/androidx/leanback/preference/LeanbackEditTextPreferenceDialogFragmentCompat.java - M
leanback/leanback-preference/src/main/java/androidx/leanback/preference/LeanbackListPreferenceDialogFragment.java - M
leanback/leanback-preference/src/main/java/androidx/leanback/preference/LeanbackListPreferenceDialogFragmentCompat.java - M
leanback/leanback-preference/src/main/java/androidx/leanback/preference/LeanbackPreferenceFragmentCompat.java - M
leanback/leanback-preference/src/main/java/androidx/leanback/preference/LeanbackSettingsFragment.java - M
leanback/leanback-preference/src/main/java/androidx/leanback/preference/LeanbackSettingsFragmentCompat.java - M
leanback/leanback-preference/src/main/java/androidx/leanback/preference/LeanbackSettingsRootView.java - M
leanback/leanback-tab/build.gradle - M
leanback/leanback-tab/src/androidTest/java/androidx/leanback/tab/app/TabLayoutTestActivity.java - M
leanback/leanback-tab/src/androidTest/java/androidx/leanback/tab/app/TestFragment.java - M
leanback/leanback-tab/src/main/java/androidx/leanback/tab/LeanbackTabLayout.java - M
leanback/leanback-tab/src/main/java/androidx/leanback/tab/LeanbackViewPager.java - M
leanback/leanback/build.gradle - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/BrowseFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/BrowseFragmentTestActivity.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/BrowseSupportFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/DetailsFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/DetailsSupportFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/DetailsTestFragment.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/DetailsTestSupportFragment.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/GuidedStepFragmentTestActivity.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/GuidedStepTestFragment.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/GuidedStepTestSupportFragment.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/ListRowDataAdapterTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/PlaybackFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/PlaybackSupportFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/RowsFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/RowsSupportFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/SearchFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/SearchSupportFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/SingleFragmentTestActivity.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/StringPresenter.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/VerticalGridFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/VideoFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/VideoSupportFragmentTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/app/wizard/GuidedStepAttributesTestFragment.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/media/MediaControllerAdapterTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/media/MediaPlayerGlueTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/media/PlaybackGlueTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/GridActivity.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/GridWidgetTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/ItemBridgeAdapterTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/ListRowPresenterTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/ObjectAdapterTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/PlaybackTransportRowPresenterTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/PresenterTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/TestPresenter.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/picker/DatePickerActivity.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/picker/PinPickerTest.java - M
leanback/leanback/src/androidTest/java/androidx/leanback/widget/picker/TimePickerActivity.java - M
leanback/leanback/src/main/java/androidx/leanback/app/BackgroundManager.java - M
leanback/leanback/src/main/java/androidx/leanback/app/BaseFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/BaseRowFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/BaseRowSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/BaseSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/BrandedFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/BrandedSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/BrowseFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/BrowseSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/DetailsBackgroundVideoHelper.java - M
leanback/leanback/src/main/java/androidx/leanback/app/DetailsFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/DetailsFragmentBackgroundController.java - M
leanback/leanback/src/main/java/androidx/leanback/app/DetailsSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/DetailsSupportFragmentBackgroundController.java - M
leanback/leanback/src/main/java/androidx/leanback/app/ErrorFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/ErrorSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/GuidedStepFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/GuidedStepSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/HeadersFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/HeadersSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/ListRowDataAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/app/OnboardingFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/OnboardingSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/PlaybackFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/PlaybackSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/RowsFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/RowsSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/SearchFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/SearchSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/VerticalGridFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/VerticalGridSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/VideoFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/app/VideoSupportFragment.java - M
leanback/leanback/src/main/java/androidx/leanback/graphics/BoundsRule.java - M
leanback/leanback/src/main/java/androidx/leanback/graphics/CompositeDrawable.java - M
leanback/leanback/src/main/java/androidx/leanback/graphics/FitWidthBitmapDrawable.java - M
leanback/leanback/src/main/java/androidx/leanback/media/MediaControllerAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/media/MediaPlayerAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/media/MediaPlayerGlue.java - M
leanback/leanback/src/main/java/androidx/leanback/media/PlaybackBannerControlGlue.java - M
leanback/leanback/src/main/java/androidx/leanback/media/PlaybackBaseControlGlue.java - M
leanback/leanback/src/main/java/androidx/leanback/media/PlaybackControlGlue.java - M
leanback/leanback/src/main/java/androidx/leanback/media/PlaybackGlue.java - M
leanback/leanback/src/main/java/androidx/leanback/media/PlaybackTransportControlGlue.java - M
leanback/leanback/src/main/java/androidx/leanback/media/PlayerAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/media/SurfaceHolderGlueHost.java - M
leanback/leanback/src/main/java/androidx/leanback/transition/TransitionHelper.java - M
leanback/leanback/src/main/java/androidx/leanback/util/StateMachine.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/AbstractDetailsDescriptionPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/AbstractMediaItemPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/AbstractMediaListHeaderPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/Action.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ActionPresenterSelector.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ArrayObjectAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/BrowseFrameLayout.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ClassPresenterSelector.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ControlBarPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ControlButtonPresenterSelector.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/CursorObjectAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/DetailsOverviewLogoPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/DetailsOverviewRow.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/DetailsOverviewRowPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/DetailsParallaxDrawable.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/DiffCallback.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/DividerPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/FragmentAnimationProvider.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/FullWidthDetailsOverviewRowPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/GuidanceStylist.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/GuidedAction.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/GuidedActionAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/GuidedActionAdapterGroup.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/GuidedActionAppCompatEditText.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/GuidedActionDiffCallback.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/GuidedActionEditText.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/GuidedActionsStylist.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/GuidedDatePickerAction.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ImageCardView.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/LeanbackAppCompatViewInflater.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ListRowPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/MediaItemActionPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/MediaRowFocusView.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/NonOverlappingLinearLayoutWithForeground.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ObjectAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/OnActionClickedListener.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/PageRow.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/PagingIndicator.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/PlaybackControlsPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/PlaybackControlsRowPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/PlaybackControlsRowView.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/PlaybackRowPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/PlaybackTransportRowPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/Presenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/PresenterSelector.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/RowContainerView.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/RowHeaderPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/RowPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/SearchOrbView.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/SeekBar.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ShadowOverlayContainer.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/ShadowOverlayHelper.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/SinglePresenterSelector.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/SparseArrayObjectAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/StreamingTextView.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/TitleView.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/TitleViewAdapter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/VerticalGridPresenter.java - M
leanback/leanback/src/main/java/androidx/leanback/widget/picker/Picker.java
Hash: a25100162bc8fdc3c54a6298c1d3cf9d0160910a
Date: Sat Dec 14 10:59:26 2024
ap...@google.com
I think that error is back. The onReady event is never fired: http://jsfiddle.net/st_f/ApK7X/120/
log:
Detected baseUrl ashttps://towtruck.mozillalabs.com towtruck.js:82
GEThttp://www.google-analytics.com/__utm.gif?utmwv=5.4.3&utms=56&utmn=58698372 …questions%2F16050024%2Fyoutube-iframe-api-fails-to-post-message%3B&utmu=q~ [VM] ga.js (648):61
8
Blocked a frame with origin "https://www.youtube.com " from accessing a frame with origin "http://fiddle.jshell.net ". The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
www-embed-player-vflXN6WzI.js:1
Blocked a frame with origin "https://www.youtube.com " from accessing a frame with origin "http://fiddle.jshell.net ". The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
www-embed-player-vflXN6WzI.js:1
2
Blocked a frame with origin "https://www.youtube.com " from accessing a frame with origin "http://fiddle.jshell.net ". The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
www-embed-player-vflXN6WzI.js:1
Blocked a frame with origin "https://www.youtube.com " from accessing a frame with origin "http://jsfiddle.net ". The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
www-embed-player-vflXN6WzI.js:214
GEThttp://www.google-analytics.com/__utm.gif?utmwv=5.4.3&utms=57&utmn=74569278 …questions%2F16050024%2Fyoutube-iframe-api-fails-to-post-message%3B&utmu=6~ [VM] ga.js (648):61
GEThttp://www.google-analytics.com/__utm.gif?utmwv=5.4.3&utms=58&utmn=99435007 …questions%2F16050024%2Fyoutube-iframe-api-fails-to-post-message%3B&utmu=6~ [VM] ga.js (648):61
GEThttp://www.google-analytics.com/__utm.gif?utmwv=5.4.3&utms=59&utmn=15270125 …questions%2F16050024%2Fyoutube-iframe-api-fails-to-post-message%3B&utmu=6~ [VM] ga.js (648):61
3
Blocked a frame with origin "https://www.youtube.com " from accessing a frame with origin "http://fiddle.jshell.net ". The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
www-embed-player-vflXN6WzI.js:1
Blocked a frame with origin "https://www.youtube.com " from accessing a frame with origin "http://fiddle.jshell.net ". The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
log:
Detected baseUrl as
GET
8
Blocked a frame with origin "
www-embed-player-vflXN6WzI.js:1
Blocked a frame with origin "
www-embed-player-vflXN6WzI.js:1
2
Blocked a frame with origin "
www-embed-player-vflXN6WzI.js:1
Blocked a frame with origin "
www-embed-player-vflXN6WzI.js:214
GET
GET
GET
3
Blocked a frame with origin "
www-embed-player-vflXN6WzI.js:1
Blocked a frame with origin "
ap...@google.com
[Comment deleted]
ap...@google.com
when using the iFrame embed, the HTML5 player works fine but the Flash player doesn't (i.e. in Firefox). Flash player gives the following error after calling loadVideoById():
[15:10:31.655] TypeError: can't convert undefined to object @https://s.ytimg.com/yts/jsbin/www-embed-player-vflmfQzGM.js:9
[15:10:31.666] Error: Permission denied to access property 'toString'
[15:10:31.655] TypeError: can't convert undefined to object @
[15:10:31.666] Error: Permission denied to access property 'toString'
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Migrate contentpager to use JSpecify annotations
Expand for full commit details
Migrate contentpager to use JSpecify annotations
CL created by running `development/jspecify_update.py contentpager`
We are updating all AndroidX libraries to use the Jspecify nullness annotations (https://docs.google.com/document/d/1XjainD032hUdCfgXIzRThHvP9FJANYuocKaTDXWuLXo/edit?usp=sharing)
Bug: 326456246
Test: `checkApi`, `lint`, `runErrorProne`
Relnote: "This library now uses [JSpecify nullness annotations](https://jspecify.dev/), which are type-use. Kotlin developers should use the following compiler arguments to enforce correct usage: -Xjspecify-annotations=strict, -Xtype-enhancement-improvements-strict-mode"
Change-Id: I11231578b982b1918d87cf974d4811e14fee19d3
Files:
- M
contentpager/contentpager/build.gradle - M
contentpager/contentpager/src/androidTest/java/androidx/contentpager/content/ContentPagerTest.java - M
contentpager/contentpager/src/androidTest/java/androidx/contentpager/content/LoaderQueryRunnerTest.java - M
contentpager/contentpager/src/androidTest/java/androidx/contentpager/content/TestContentProvider.java - M
contentpager/contentpager/src/androidTest/java/androidx/contentpager/content/TestQueryCallback.java - M
contentpager/contentpager/src/main/java/androidx/contentpager/content/ContentPager.java - M
contentpager/contentpager/src/main/java/androidx/contentpager/content/LoaderQueryRunner.java - M
contentpager/contentpager/src/main/java/androidx/contentpager/content/Query.java
Hash: fcf9e480d7c1cd3db6b3bee16179e528d73b8898
Date: Mon Sep 30 15:11:28 2024
ap...@google.com
[Comment deleted]
ap...@google.com
I think this issue has again reproduced suddenly the calls to onReady and onStateChange have been stopped as they were working fine 2 days before.
Please also refer the code athttp://jsfiddle.net/77PJB/5/ which is not working.
Thanks.
Please also refer the code at
Thanks.
ap...@google.com
I'm seeing the same issue in Buenos Aires, Argentina
ap...@google.com
[Comment deleted]
ap...@google.com
[Comment deleted]
ap...@google.com
Seeing this issue again for the last few days. onReady and onStateChange events are not firing for videos where the iframe exists on the page when the api is initialised.
ap...@google.com
Seeing this issue again,
Description