Search bar should take text field as a slot [326627700]

Fixed

Feature Request

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Feb 23, 2024 07:55PM

The SearchBarInputField component should also be made public when this is done.

Comments

ap...@google.com <ap...@google.com> #2Mar 22, 2024 07:10PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ap...@google.com <ap...@google.com> #3Mar 22, 2024 07:10PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ap...@google.com <ap...@google.com> #4Mar 28, 2024 06:00PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 040e3103bc0cfb65b085ec7401e5f4aee7b2f893
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Mar 27 17:36:06 2024

Make SearchBar take input field as a slot

- SearchBarInputField moved into SearchBarDefaults and made public
- Deprecated SearchBarColors inputFieldColors param
- renamed "active" to "expanded" in new API to better align with spec language

Bug:

Fixes:

Relnote: "`SearchBar` and `DockedSearchBar` have new overloads that
take a text field parameter. This allows styling the text field
separately from the rest of the search bar as well as passing in
custom text fields. The text field of the current implementation
has been made available as `SearchBarDefaults.InputField`."
Test: tests updated
Change-Id: I50c73509b4a67247df7240207e7ad13d5863a7ff

M compose/material3/benchmark/src/androidTest/java/androidx/compose/material3/benchmark/SearchBarBenchmark.kt
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/SearchBarSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/SearchBarScreenshotTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/SearchBarTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/SearchBar.android.kt

https://android-review.googlesource.com/3016901

na...@google.com <na...@google.com> #5Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.0-alpha05
androidx.compose.material3:material3-android:1.3.0-alpha05
androidx.compose.material3:material3-desktop:1.3.0-alpha05

Issue 326627700

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 22, 2024 07:10PM

ap...@google.com <ap...@google.com> #3Mar 22, 2024 07:10PM

ap...@google.com <ap...@google.com> #4Mar 28, 2024 06:00PM

na...@google.com <na...@google.com> #5Apr 17, 2024 05:17PM

Add comment

Issue metadata