Material3 NavigationBar colors don't use LocalContentColor when color is unspecified [326894020]

Fixed

Bug

Status Update

No update yet.

Description

st...@gmail.com

created issue #1

Feb 26, 2024 02:02PM

Jetpack Compose version: 2024.02.01
Jetpack Compose component used: material3:1.2.0
Android Studio Build: N/A
Kotlin version: 1.9.22

As I was calling the bottom sheet, I was calling the colors function like this

colors = NavigationBarItemDefaults.colors(
  indicatorColor = MaterialTheme.colorScheme.surface,
  selectedIconColor = MaterialTheme.colorScheme.onSurface,
  unselectedIconColor = MaterialTheme.colorScheme.onSurface,
),

but the latest material3 version is not providing sane defaults as it used to for the colors that I am not specifying explicitly. Instead I get black text on dark and light mode since I am not specifying a specific color for selectedTextColor and unselectedTextColor.

These lines here https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt;l=312-321?q=NavigationBarItemDefaults are the ones that probably break this behavior. Which was introduced here https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt;l=312-321?q=NavigationBarItemDefaults This Unspecified color is then used over here https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt;l=445-451?q=NavigationBarItemDefaults Interestingly, the deprecated method which says "Use overload with disabledIconColor and disabledTextColor", does seem to properly set some sane defaults for the parameters you may not be specifying.

In contrast, for NavRail this was not broken in the latest update, see here https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationRail.kt;l=308-317?q=NavigationRailItemDefaults

I would expect here to get either a more sane default meaning something from the MaterialTheme which is more likely to have the right value for dark and light mode like it did before. This simply breaks the layout completely as the text is completely illegible by default.

Comments

st...@gmail.com <st...@gmail.com> #2Feb 26, 2024 02:22PM

deleted

Message last modified on Feb 26, 2024 02:23PM

co...@google.com <co...@google.com> #3Feb 26, 2024 08:30PM

Reassigned to ma...@google.com.

st...@gmail.com <st...@gmail.com> #4Feb 26, 2024 09:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit 46eea23c96f45f0ee1e57d8aef2f1375507b0dec
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Apr 11 14:38:58 2023

[M3][ModalBottomSheet] Enable edge to edge functionality for ModalBottomSheet

Bug: 274872542
Bug: 272973615
Bug: 272334475
Bug: 268432129
Bug: 275849044
Bug: 275486106
Bug: 268433162
RelNote: Add window insets parameter to ModalBottomSheet.
RelNote: Scrim for ModalBottomSheet may now be drawn behind status bar with windowInsets set to zero
RelNote: Updated default ModalBottomSheet functionality to stay outside of system bars including navigation
RelNote: Status bar inset handling is provided by drag handle in edge-to-edge mode.
RelNote: BottomSheetDefaults includes window insets for BottomSheetWindow.
Test: Parameterizes existing tests to work with and without edgeToEdge enabled.
Test: Manual EdgeToEdge testing on various devices and android APIs
Change-Id: I312008e48573ebd21326f77216be0bcd0372aa78

M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt

https://android-review.googlesource.com/2531428

ma...@google.com <ma...@google.com> Feb 26, 2024 09:39PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #5Feb 26, 2024 11:22PM

Marked as fixed.

Bottom sheet window can now be moved outside of specified inset areas with windowInsets parameter. However, there is a known issue where even if the top level insets are zero'd out, they seem to be consumed preventing content from using system bar padding. Currently investigating.

na...@google.com <na...@google.com> #6Mar 6, 2024 07:49PM

Will this be backported to 1.1 or will we have to wait months for 1.2?

Issue 326894020