Fixed
Status Update
No update yet.
Comments
st...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt - M
compose/foundation/foundation/api/restricted_current.txt - M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt - M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt - M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
co...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06androidx.compose.foundation:foundation-android:1.8.0-alpha06androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
st...@gmail.com
Thanks a lot for getting back to me here. So it was a simple mistake after all, that is great to hear. I was just a bit concerned that this has setting a different precedent than what we typically expect with these apis. Since it's a bug I'm happy to hear that. Looking forward to the fix, thank you again!
ma...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 8e9c6f5fc51c7fabc9411631f600e8b986ebf34f
Author: Max Alfonso-Ying <maxying@google.com>
Date: Mon Feb 26 21:38:49 2024
Fix NavigationBar custom colors to copy from defaults
Test: added unit tests
Fixes:
Change-Id: I631303a24dc47c400a5cdacbedb9ee102680a779
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/NavigationBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt
https://android-review.googlesource.com/2978731
Branch: androidx-main
commit 8e9c6f5fc51c7fabc9411631f600e8b986ebf34f
Author: Max Alfonso-Ying <maxying@google.com>
Date: Mon Feb 26 21:38:49 2024
Fix NavigationBar custom colors to copy from defaults
Test: added unit tests
Fixes:
Change-Id: I631303a24dc47c400a5cdacbedb9ee102680a779
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/NavigationBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.2.1androidx.compose.material3:material3-android:1.2.1androidx.compose.material3:material3-desktop:1.2.1androidx.compose.material3:material3:1.3.0-alpha02androidx.compose.material3:material3-android:1.3.0-alpha02androidx.compose.material3:material3-desktop:1.3.0-alpha02
Description
Jetpack Compose version: 2024.02.01
Jetpack Compose component used: material3:1.2.0
Android Studio Build: N/A
Kotlin version: 1.9.22
As I was calling the bottom sheet, I was calling the colors function like this
but the latest material3 version is not providing sane defaults as it used to for the colors that I am not specifying explicitly. Instead I get black text on dark and light mode since I am not specifying a specific color for selectedTextColor and unselectedTextColor.
These lines herehttps://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt;l=312-321?q=NavigationBarItemDefaults are the ones that probably break this behavior. Which was introduced here https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt;l=312-321?q=NavigationBarItemDefaults
This Unspecified color is then used over here https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt;l=445-451?q=NavigationBarItemDefaults
Interestingly, the deprecated method which says "Use overload with disabledIconColor and disabledTextColor", does seem to properly set some sane defaults for the parameters you may not be specifying.
In contrast, for NavRail this was not broken in the latest update, see herehttps://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationRail.kt;l=308-317?q=NavigationRailItemDefaults
I would expect here to get either a more sane default meaning something from the MaterialTheme which is more likely to have the right value for dark and light mode like it did before. This simply breaks the layout completely as the text is completely illegible by default.