Fix query parameter parsing for String type [327274038]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Feb 27, 2024 11:58PM

When parsing NavDeepLink, we consider a NavType.StringType value that is identical to the argument name as a valid value. For example:

NavDestination route = "www.example.com/{pathArg}"
NavController.navigate("www.example.com/{pathArg}")

The argument pathArg will contain value of {pathArg}. This should also apply to query arguments.

Comments

ap...@google.com <ap...@google.com> #2Mar 6, 2024 12:45AM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

cl...@google.com <cl...@google.com> #3Mar 6, 2024 02:34AM

Marked as fixed.

yea i'll take it.

pr...@google.com <pr...@google.com> #4Mar 20, 2024 08:26PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

Issue 327274038

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 6, 2024 12:45AM

cl...@google.com <cl...@google.com> #3Mar 6, 2024 02:34AM

pr...@google.com <pr...@google.com> #4Mar 20, 2024 08:26PM

Add comment

Issue metadata