Stability configuration: Stability of list of stable classes [327643787]

Fixed

Bug

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Feb 29, 2024 09:18PM

Versions

Jetpack Compose version: androidx.compose:compose-bom:2023.08.00
Android Studio Build: Android Studio Hedgehog | 2023.1.1 Patch 2
Kotlin version: 1.9.22

Steps to Reproduce or Code Sample to Reproduce:

Create empty Jetpack Compose project
Update Compose Compiler to 1.5.8 and Kotlin version to 1.9.22
Enable Compose Metrics
Make Lists stable by Stability Configuration file
Build the app
Check the composeMetrics

Stability configuration file

kotlin.collections.List

Used `data class`

data class UiState(
    val items: List<Item>,
) {
    data class Item(
        val texts: List<String>,
    )
}

Output stability

stable class Item {
  stable val texts: List<String>
  <runtime stability> = 
}

unstable class UiState {
  unstable val items: List<Item>
  <runtime stability> = Unstable
}

restartable scheme("[androidx.compose.ui.UiComposable]") fun Greeting(
  unstable state: UiState
)

Expected behavior

As the Item is stable thanks to forced List stability I would expect to have the UiState stable as it contains list (stable) of stable classes. Am I missing something?

Comments

as...@google.com <as...@google.com> #2Mar 4, 2024 10:55AM

Reassigned to be...@google.com.

I simpler example would be appreciated. I tried to download the pull request and build it but it relies on, for example, `rustc` to be installed which I don't have installed on my compose development machine.

Does the program work without the compiler switch. That is, is `"-P", "plugin:androidx.compose.compiler.plugins.kotlin:experimentalStrongSkipping=true",` required to reproduce or is just changing the runtime enough?

be...@google.com <be...@google.com> Mar 5, 2024 12:25AM

Accepted by be...@google.com.

ap...@google.com <ap...@google.com> #3Mar 7, 2024 09:51PM

Marked as fixed.

Yeah, changing compiler switch(enable/disable StrongSkipping, enable/disable nonSkippingGroup) has no effect, only changing runtime make sense.
Sorry for that, I will try to extract an example when I'm free.

pr...@google.com <pr...@google.com> #4Mar 20, 2024 08:26PM

I have find a sample code to reproduce that

        setContent {
            val dialogState = remember { DialogState() }
            dialogState.Intercept()
            LaunchedEffect(Unit) {
                delay(1000)
                dialogState.bgWork {
                    delay(5000)
                }
                dialogState.showSelectActions {
                    onSelect("a") {

                    }
                    onSelect("b") {

                    }
                }
            }
        }

You can find implementation of DialogState here https://github.com/FooIbar/EhViewer/blob/ef16bdeb755ae888c74eaa4a337bd5b708fcc97e/app/src/main/kotlin/com/hippo/ehviewer/ui/tools/Dialog.kt#L92
https://github.com/FooIbar/EhViewer/blob/main/app/src/main/kotlin/com/hippo/ehviewer/util/Progress.kt Launch that Activity, wait 6 seconds and it will crash