BiasAlignment does not directly expose bias but probably should [328088992]

Fixed

Bug

Status Update

No update yet.

Description

go...@jakewharton.com

created issue #1

Mar 4, 2024 07:33PM

Given a `BiasAlignment`, `BiasAlignment.Horizontal`, or `BiasAlignment.Vertical` I cannot directly extract the float bias values. I can do it with the `data class`-generated `copy` function, but that is very annoying. This would help partially solve

issue 328086355

as I could compose `BiasAlignment.Vertical` and `BiasAlignment.Horizontal` into a `BiasAlignment` which I then supply to something wanting an `Alignment` (but it does not solve that issue in the general case, hence why I filed it separately.

The bias float value already comes in via the constructor and is exposed via `copy` and `component1()`/`component2()`, so why not make the named properties available directly, too?

Compose foundation 1.6.2

Comments

go...@jakewharton.com <go...@jakewharton.com> #2Mar 6, 2024 03:22AM

http://r.android.com/2990349

le...@google.com <le...@google.com> Mar 8, 2024 01:48PM

Reassigned to uo...@google.com.

go...@jakewharton.com <go...@jakewharton.com> #3Mar 8, 2024 02:34PM

Comment has been deleted.

Message last modified on Mar 8, 2024 02:34PM

ap...@google.com <ap...@google.com> #4Mar 8, 2024 03:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2cba85654e8521636f6e19a3d3e946de428719df
Author: Jake Wharton <jw@squareup.com>
Date: Tue Mar 05 15:50:59 2024

Consistently expose bias float properties

Bug: 328088992
Test: ./gradlew :compose:ui:ui:bOS
Relnote: Consistently expose bias float properties on all bias-based alignment subtypes.
Change-Id: I69f0fb6798bb99d81287d69f9a9618bc89d99ffd

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/Alignment.kt

https://android-review.googlesource.com/2990349

uo...@google.com <uo...@google.com> Apr 2, 2024 02:47AM

Marked as fixed.

Issue 328088992