Add option to toggle visibility of the navigation bar/rail with animation [328674235]

Fixed

Feature Request

Status Update

No update yet.

Description

am...@gmail.com

created issue #1

Mar 8, 2024 11:09AM

Jetpack Compose M3 Adaptive Navigation Suite: 1.0.0-alpha05 Kotlin version: 1.9.22

Currently, to hide the navigation bar/rail, we have to either:

set layoutType to NavigationSuiteType.NONE
wrap navigationSuite content in an AnimatedVisiblity composable.

First option leads to this which has a jarring effect.

Second is also similar. Just that the container hides after the animation completes.

Ideally there should be a way to hide the navigation bar/rail with proper animation.

Comments

co...@google.com <co...@google.com> Apr 12, 2024 06:26PM

Assigned to le...@google.com.

am...@gmail.com <am...@gmail.com> #2May 12, 2024 09:30AM

Relevant APIs: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ProgressIndicator.kt;l=318

le...@google.com <le...@google.com> Sep 30, 2024 08:18PM

Status: Duplicate of

369945539

le...@google.com <le...@google.com> Oct 9, 2024 03:37PM

Status: Assigned (reopened)

le...@google.com <le...@google.com> Jan 9, 2025 07:39PM

Accepted by le...@google.com.

le...@google.com <le...@google.com> Jan 14, 2025 07:47PM

Marked as fixed.

na...@google.com <na...@google.com> #3Jan 29, 2025 06:12PM

After some brief poking around:

Relevant code in LayoutNode: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt;l=421?q=semantics%20f:layoutnode&ss=androidx%2Fplatform%2Fframeworks%2Fsupport:compose%2F

Ends up here: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt;l=2152?q=onSemanticsChange%20lang:kt&ss=androidx%2Fplatform%2Fframeworks%2Fsupport:compose%2F

If accessibility is off, looks like changing progress semantics a no op which would be a big improvement to performance.

Otherwise semantics does a remeasure / relayout, and walks the full semantics tree. This would likely have no immediate benefit if accessibility is turned on.